Skip to content

[fix](insert-overwrite) should use un strict replace - #61082

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:iow-bug2
Mar 6, 2026
Merged

[fix](insert-overwrite) should use un strict replace#61082
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:iow-bug2

Conversation

@morrySnow

@morrySnowmorrySnow commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

related PR: #60914

Problem Summary:

This pull request introduces a minor update to the partition replacement logic in InsertOverwriteUtil.java. The change ensures that the partition replacement operation does not enforce strict range checking by default.

  • Partition replacement logic:
    • Added the property PROPERTIES_STRICT_RANGE with a value of "false" to the properties map when constructing a ReplacePartitionOp, disabling strict range enforcement during partition replacement.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow

morrySnow commented Mar 5, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Mar 5, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 27652 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83eba7da39681a8e12ab8663d46fb79becc1776e, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17617	4441	4302	4302
q2	q3	10648	799	515	515
q4	4684	377	262	262
q5	7555	1192	1024	1024
q6	179	175	146	146
q7	773	829	668	668
q8	9297	1456	1330	1330
q9	4902	4683	4719	4683
q10	6245	1906	1670	1670
q11	493	279	235	235
q12	697	565	469	469
q13	18028	2945	2163	2163
q14	230	229	216	216
q15	904	795	815	795
q16	732	738	690	690
q17	703	857	454	454
q18	5979	5404	5268	5268
q19	1262	1004	608	608
q20	494	484	385	385
q21	4782	2116	1497	1497
q22	396	321	272	272
Total cold run time: 96600 ms
Total hot run time: 27652 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5808	4585	4591	4585
q2	q3	3843	4322	3844	3844
q4	862	1190	817	817
q5	4047	4367	4347	4347
q6	194	185	142	142
q7	1791	1656	1509	1509
q8	2453	2682	2778	2682
q9	7357	7519	7275	7275
q10	3728	3967	3636	3636
q11	550	431	407	407
q12	495	576	458	458
q13	2732	3146	2350	2350
q14	330	310	292	292
q15	847	806	787	787
q16	699	764	726	726
q17	1138	1402	1336	1336
q18	7150	6854	6622	6622
q19	876	867	1091	867
q20	2095	2152	2000	2000
q21	3951	3541	3645	3541
q22	490	443	381	381
Total cold run time: 51436 ms
Total hot run time: 48604 ms

@doris-robot

doris-robot commented Mar 5, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 153021 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83eba7da39681a8e12ab8663d46fb79becc1776e, data reload: false
query5	4314	631	526	526
query6	330	219	220	219
query7	4213	458	280	280
query8	349	262	239	239
query9	8727	2792	2740	2740
query10	531	390	338	338
query11	7324	5875	5608	5608
query12	195	128	128	128
query13	1277	449	361	361
query14	6004	3776	3563	3563
query14_1	2778	2809	2817	2809
query15	199	194	175	175
query16	998	467	453	453
query17	1095	715	621	621
query18	2503	448	355	355
query19	242	202	174	174
query20	137	127	130	127
query21	220	134	119	119
query22	4814	5097	4873	4873
query23	16564	16062	15680	15680
query23_1	15824	15822	15763	15763
query24	7571	1608	1204	1204
query24_1	1225	1232	1218	1218
query25	544	470	405	405
query26	1235	256	143	143
query27	2804	461	284	284
query28	4511	1891	1886	1886
query29	859	543	463	463
query30	309	251	208	208
query31	1385	1306	1223	1223
query32	78	71	74	71
query33	505	318	272	272
query34	909	906	554	554
query35	630	672	598	598
query36	1112	1117	992	992
query37	129	93	82	82
query38	2926	2961	2952	2952
query39	1019	868	843	843
query39_1	828	812	839	812
query40	227	149	133	133
query41	73	68	68	68
query42	289	304	298	298
query43	240	250	220	220
query44 query45	198	187	186	186
query46	878	961	599	599
query47	2132	2114	2032	2032
query48	317	310	235	235
query49	625	462	369	369
query50	681	277	223	223
query51	4043	4053	4042	4042
query52	288	297	281	281
query53	287	329	278	278
query54	293	267	260	260
query55	88	87	87	87
query56	316	347	312	312
query57	1386	1337	1283	1283
query58	286	280	270	270
query59	1297	1424	1292	1292
query60	337	330	316	316
query61	182	142	142	142
query62	635	583	537	537
query63	307	272	275	272
query64	5128	1268	975	975
query65 query66	1446	454	365	365
query67	16353	16300	16165	16165
query68 query69	391	305	282	282
query70	1018	990	913	913
query71	345	311	304	304
query72	2762	2654	2543	2543
query73	544	537	327	327
query74	10007	9935	9807	9807
query75	2882	2779	2485	2485
query76	2308	1051	679	679
query77	368	390	311	311
query78	11126	11274	10647	10647
query79	1135	796	611	611
query80	733	646	562	562
query81	497	275	250	250
query82	1368	153	123	123
query83	389	277	249	249
query84	263	123	106	106
query85	912	550	513	513
query86	368	334	316	316
query87	3136	3064	3020	3020
query88	3543	2678	2667	2667
query89	436	376	353	353
query90	1942	177	178	177
query91	165	161	134	134
query92	76	73	69	69
query93	901	852	511	511
query94	442	326	285	285
query95	586	398	314	314
query96	642	508	228	228
query97	2528	2514	2447	2447
query98	233	215	219	215
query99	972	976	910	910
Total cold run time: 233064 ms
Total hot run time: 153021 ms

@hello-stephen

hello-stephen commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 6, 2026
@github-actions

github-actionsBot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit ab2b54d into apache:masterMar 6, 2026
31 of 32 checks passed
@morrySnow
morrySnow deleted the iow-bug2 branch March 6, 2026 03:41
mrhhsg pushed a commit that referenced this pull request Mar 6, 2026
@morrySnow@mrhhsg
[fix](insert-overwrite) should use un strict replace (#61082)
9424724
related PR: #60914
Problem Summary:
This pull request introduces a minor update to the partition replacement
logic in `InsertOverwriteUtil.java`. The change ensures that the
partition replacement operation does not enforce strict range checking
by default.
- Partition replacement logic:
* Added the property `PROPERTIES_STRICT_RANGE` with a value of `"false"`
to the properties map when constructing a `ReplacePartitionOp`,
disabling strict range enforcement during partition replacement.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Mar 10, 2026
@morrySnow
branch-4.0: [fix](insert-overwrite) should use un strict replaceapac…
6e792a4
…he#61082
picked from apache#61082
@morrySnowmorrySnow mentioned this pull request Mar 10, 2026
Merged
yiguolei pushed a commit that referenced this pull request Mar 11, 2026
@morrySnow
branch-4.0: [fix](insert-overwrite) should use un strict replace#61082…
cc58e4f
… (#61185)
picked from #61082
@yiguoleiyiguolei mentioned this pull request Mar 27, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
@seawindeseawindeseawinde approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.5-mergeddev/4.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morrySnow@Thearas@doris-robot@hello-stephen@starocean999@seawinde@yiguolei