[fix](filecache) add async lru update machanism and fix partial hit in cache reader by freemandealer · Pull Request #61083 · apache/doris

freemandealer · 2026-03-05T10:47:11Z

CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead)
Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting
Established performance unit tests for cache lock

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-03-05T10:47:17Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

freemandealer · 2026-03-05T10:47:25Z

run buildall

doris-robot · 2026-03-05T12:42:20Z

TPC-H: Total hot run time: 27941 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cbe632c41f6e353337e80523342e3349b42e24e4, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17635	4422	4283	4283
q2	q3	10665	829	530	530
q4	4678	390	267	267
q5	7568	1192	1035	1035
q6	175	179	148	148
q7	784	852	671	671
q8	9293	1502	1378	1378
q9	4853	4743	4775	4743
q10	6316	1908	1665	1665
q11	471	261	241	241
q12	738	564	472	472
q13	18054	2942	2166	2166
q14	229	236	223	223
q15	944	807	807	807
q16	786	723	681	681
q17	713	852	427	427
q18	5961	5441	5366	5366
q19	1127	1000	612	612
q20	513	495	405	405
q21	4448	2181	1544	1544
q22	438	361	277	277
Total cold run time: 96389 ms
Total hot run time: 27941 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4657	4538	4575	4538
q2	q3	3877	4339	3894	3894
q4	873	1226	774	774
q5	4055	4393	4374	4374
q6	192	180	147	147
q7	1822	1643	1542	1542
q8	2465	2873	2578	2578
q9	7794	7389	7320	7320
q10	3727	3990	3566	3566
q11	519	434	445	434
q12	528	622	450	450
q13	2812	3200	2323	2323
q14	287	295	279	279
q15	843	795	816	795
q16	711	778	756	756
q17	1159	1450	1358	1358
q18	7183	6756	6705	6705
q19	891	870	889	870
q20	2104	2294	1995	1995
q21	3967	3506	3307	3307
q22	436	420	401	401
Total cold run time: 50902 ms
Total hot run time: 48406 ms

doris-robot · 2026-03-05T12:52:27Z

TPC-DS: Total hot run time: 152871 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cbe632c41f6e353337e80523342e3349b42e24e4, data reload: false
query5	4336	642	521	521
query6	339	224	204	204
query7	4228	480	264	264
query8	349	263	241	241
query9	8750	2822	2780	2780
query10	533	400	374	374
query11	7283	5811	5622	5622
query12	196	126	123	123
query13	1261	460	361	361
query14	5690	3796	3584	3584
query14_1	2846	2829	2840	2829
query15	209	202	176	176
query16	973	482	475	475
query17	1118	722	623	623
query18	2447	457	357	357
query19	219	223	183	183
query20	136	133	126	126
query21	227	146	140	140
query22	4872	5002	4741	4741
query23	15976	15533	15347	15347
query23_1	16196	15852	15945	15852
query24	7452	1686	1349	1349
query24_1	1279	1266	1314	1266
query25	593	522	490	490
query26	1419	282	165	165
query27	3106	540	302	302
query28	5004	1886	1870	1870
query29	817	555	478	478
query30	304	244	208	208
query31	1344	1296	1228	1228
query32	80	71	74	71
query33	503	338	267	267
query34	948	922	557	557
query35	627	672	593	593
query36	1094	1095	951	951
query37	133	94	79	79
query38	2935	2904	2932	2904
query39	934	851	838	838
query39_1	824	829	826	826
query40	225	154	139	139
query41	66	69	67	67
query42	303	300	293	293
query43	242	241	224	224
query44 query45	199	197	180	180
query46	901	994	601	601
query47	2137	2160	2046	2046
query48	315	319	230	230
query49	628	458	390	390
query50	683	287	214	214
query51	4096	4116	4026	4026
query52	287	302	279	279
query53	292	332	282	282
query54	296	281	267	267
query55	92	88	82	82
query56	306	326	308	308
query57	1346	1345	1264	1264
query58	283	278	281	278
query59	1342	1462	1277	1277
query60	336	344	319	319
query61	158	145	152	145
query62	635	598	540	540
query63	314	279	272	272
query64	4994	1260	991	991
query65 query66	1452	458	351	351
query67	16162	16382	16320	16320
query68 query69	390	319	281	281
query70	933	967	929	929
query71	342	303	301	301
query72	2845	2682	2462	2462
query73	544	563	318	318
query74	9990	9936	9749	9749
query75	2836	2749	2459	2459
query76	2279	1036	655	655
query77	359	375	297	297
query78	11246	11436	10732	10732
query79	1164	760	629	629
query80	1462	646	534	534
query81	560	274	247	247
query82	1003	148	116	116
query83	354	273	270	270
query84	245	117	108	108
query85	1216	473	432	432
query86	413	284	298	284
query87	3126	3097	3010	3010
query88	3509	2677	2672	2672
query89	415	371	346	346
query90	1881	173	173	173
query91	176	160	143	143
query92	78	74	77	74
query93	977	860	519	519
query94	675	333	302	302
query95	588	351	390	351
query96	634	509	229	229
query97	2473	2503	2423	2423
query98	239	223	222	222
query99	1007	1002	867	867
Total cold run time: 233914 ms
Total hot run time: 152871 ms

doris-robot · 2026-03-05T14:48:59Z

BE UT Coverage Report

Increment line coverage 100.00% (23/23) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.56% (19648/37381)
Line Coverage	36.18% (183435/507001)
Region Coverage	32.51% (142408/438111)
Branch Coverage	33.44% (61754/184670)

hello-stephen · 2026-03-05T15:54:12Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (23/23) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.16% (26779/36603)
Line Coverage	56.52% (285692/505448)
Region Coverage	54.15% (239466/442248)
Branch Coverage	55.59% (102965/185234)

freemandealer · 2026-03-11T02:16:34Z

run p0

freemandealer · 2026-03-27T06:36:31Z

run buildall

github-actions · 2026-03-27T06:47:30Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-03-27T06:47:32Z

PR approved by anyone and no changes requested.

doris-robot · 2026-03-27T10:01:37Z

TPC-H: Total hot run time: 26787 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b7db78d6bdcb9b0046caa5f752c067a7465ebe3, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17590	4586	4358	4358
q2	q3	10652	798	536	536
q4	4684	358	252	252
q5	7575	1219	1028	1028
q6	184	177	152	152
q7	809	856	681	681
q8	9320	1538	1378	1378
q9	4889	4720	4702	4702
q10	6315	1945	1652	1652
q11	509	265	246	246
q12	703	592	467	467
q13	18035	2727	1925	1925
q14	233	236	220	220
q15	q16	756	744	670	670
q17	737	843	471	471
q18	6227	5479	5311	5311
q19	1113	981	628	628
q20	546	504	383	383
q21	4306	1840	1440	1440
q22	586	392	287	287
Total cold run time: 95769 ms
Total hot run time: 26787 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4749	4646	4596	4596
q2	q3	3900	4357	3832	3832
q4	888	1181	782	782
q5	4066	4374	4433	4374
q6	188	179	144	144
q7	1884	1656	1532	1532
q8	2582	2713	2594	2594
q9	7833	7317	7550	7317
q10	3877	3973	3627	3627
q11	498	445	411	411
q12	485	584	460	460
q13	2515	2940	2113	2113
q14	290	346	288	288
q15	q16	726	782	737	737
q17	1210	1353	1345	1345
q18	6978	6757	6629	6629
q19	909	887	936	887
q20	2069	2132	1972	1972
q21	3934	3490	3537	3490
q22	475	420	374	374
Total cold run time: 50056 ms
Total hot run time: 47504 ms

doris-robot · 2026-03-27T10:12:23Z

TPC-DS: Total hot run time: 168987 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b7db78d6bdcb9b0046caa5f752c067a7465ebe3, data reload: false
query5	4339	649	508	508
query6	323	221	211	211
query7	4220	483	264	264
query8	333	236	228	228
query9	8686	2716	2687	2687
query10	519	396	359	359
query11	7006	5087	4885	4885
query12	192	132	134	132
query13	1286	463	353	353
query14	5762	3699	3455	3455
query14_1	2932	2866	2846	2846
query15	201	195	175	175
query16	993	489	460	460
query17	1116	752	629	629
query18	2451	453	361	361
query19	224	219	192	192
query20	135	125	128	125
query21	217	140	113	113
query22	13294	13985	14652	13985
query23	17199	16427	16330	16330
query23_1	16095	15744	15618	15618
query24	7181	1620	1230	1230
query24_1	1227	1276	1241	1241
query25	537	457	393	393
query26	1231	262	149	149
query27	2768	476	295	295
query28	4494	1833	1852	1833
query29	825	568	479	479
query30	298	226	188	188
query31	1007	943	865	865
query32	84	71	67	67
query33	506	328	280	280
query34	895	873	516	516
query35	633	676	593	593
query36	1077	1138	983	983
query37	138	103	83	83
query38	3001	2925	2856	2856
query39	869	834	824	824
query39_1	797	795	786	786
query40	229	147	135	135
query41	61	60	58	58
query42	260	255	263	255
query43	240	255	225	225
query44 query45	192	183	184	183
query46	872	971	597	597
query47	2123	2143	2080	2080
query48	309	313	227	227
query49	622	460	380	380
query50	692	275	205	205
query51	4098	4185	3974	3974
query52	260	270	259	259
query53	310	349	296	296
query54	312	265	262	262
query55	102	92	85	85
query56	324	323	331	323
query57	1926	1659	1801	1659
query58	280	292	266	266
query59	2819	2949	2735	2735
query60	337	343	327	327
query61	156	154	153	153
query62	619	590	535	535
query63	304	290	276	276
query64	5014	1288	1008	1008
query65 query66	1456	443	364	364
query67	24283	24363	24284	24284
query68 query69	407	305	298	298
query70	884	981	918	918
query71	346	305	294	294
query72	2808	2684	2421	2421
query73	529	545	309	309
query74	9658	9576	9446	9446
query75	2861	2742	2477	2477
query76	2273	1030	653	653
query77	352	371	312	312
query78	11073	11120	10475	10475
query79	1124	773	570	570
query80	1333	623	525	525
query81	547	255	222	222
query82	1000	153	121	121
query83	330	261	239	239
query84	249	119	93	93
query85	918	488	443	443
query86	411	316	294	294
query87	3157	3119	3011	3011
query88	3540	2639	2660	2639
query89	434	362	348	348
query90	2029	168	176	168
query91	174	166	139	139
query92	82	74	69	69
query93	956	836	494	494
query94	639	337	308	308
query95	599	355	324	324
query96	645	526	227	227
query97	2431	2510	2404	2404
query98	235	219	231	219
query99	1016	980	916	916
Total cold run time: 250153 ms
Total hot run time: 168987 ms

doris-robot · 2026-03-27T10:34:57Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.90% (19938/37689)
Line Coverage	36.43% (186840/512921)
Region Coverage	32.69% (144894/443255)
Branch Coverage	33.89% (63539/187497)

hello-stephen · 2026-03-27T15:21:34Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.34% (21166/36911)
Line Coverage	40.46% (206888/511373)
Region Coverage	37.42% (167412/447377)
Branch Coverage	38.14% (71728/188063)

…artial hit in cache reader (pick #61083) (#61812) - CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead) - Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting - Established performance unit tests for cache lock Signed-off-by: zhengyu <zhangzhengyu@selectdb.com> ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  --------- Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer · 2026-04-23T03:32:06Z

run buildall

hello-stephen · 2026-05-27T11:14:07Z

TPC-H: Total hot run time: 32010 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0b40d997a1f5f6d7b75aa6a75fd467ba7ea1ac43, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17655	4015	3980	3980
q2	q3	10751	1434	819	819
q4	4683	474	342	342
q5	7600	2266	2124	2124
q6	235	171	140	140
q7	975	785	638	638
q8	9403	1712	1696	1696
q9	5459	5040	4977	4977
q10	6464	2203	1907	1907
q11	448	275	242	242
q12	692	429	294	294
q13	18223	3444	2806	2806
q14	264	263	241	241
q15	q16	818	776	714	714
q17	916	979	943	943
q18	6855	5876	5711	5711
q19	1190	1368	1290	1290
q20	574	458	281	281
q21	6055	2890	2545	2545
q22	546	363	320	320
Total cold run time: 99806 ms
Total hot run time: 32010 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4868	4887	4857	4857
q2	q3	5091	5226	4691	4691
q4	2142	2321	1394	1394
q5	5097	4774	4681	4681
q6	236	179	129	129
q7	1926	1933	1602	1602
q8	2417	2137	2118	2118
q9	7901	7397	7391	7391
q10	4764	4657	4196	4196
q11	534	395	354	354
q12	732	747	526	526
q13	2997	3361	2817	2817
q14	269	277	267	267
q15	q16	677	697	618	618
q17	1287	1274	1257	1257
q18	7154	6990	6933	6933
q19	1150	1094	1122	1094
q20	2231	2223	1941	1941
q21	5280	4578	4387	4387
q22	532	449	421	421
Total cold run time: 57285 ms
Total hot run time: 51674 ms

hello-stephen · 2026-05-27T11:25:07Z

TPC-DS: Total hot run time: 172076 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0b40d997a1f5f6d7b75aa6a75fd467ba7ea1ac43, data reload: false
query5	4326	668	522	522
query6	343	228	208	208
query7	4245	590	334	334
query8	330	240	239	239
query9	8831	4185	4138	4138
query10	444	348	302	302
query11	5743	2577	2232	2232
query12	185	140	130	130
query13	1324	606	426	426
query14	6198	5569	5238	5238
query14_1	4540	4533	4496	4496
query15	221	208	188	188
query16	1035	473	470	470
query17	1148	758	623	623
query18	2733	493	372	372
query19	230	209	171	171
query20	139	136	135	135
query21	218	137	122	122
query22	13573	13592	13343	13343
query23	17351	16500	16241	16241
query23_1	16500	16376	16310	16310
query24	7528	1820	1312	1312
query24_1	1326	1331	1328	1328
query25	612	521	457	457
query26	1299	324	179	179
query27	2666	579	359	359
query28	4456	2047	2061	2047
query29	1030	652	526	526
query30	314	244	201	201
query31	1115	1117	962	962
query32	91	82	76	76
query33	532	355	304	304
query34	1172	1137	668	668
query35	780	795	704	704
query36	1443	1378	1230	1230
query37	146	99	86	86
query38	3219	3206	3080	3080
query39	918	907	912	907
query39_1	919	887	884	884
query40	223	144	126	126
query41	66	62	63	62
query42	114	109	107	107
query43	331	333	296	296
query44 query45	224	206	204	204
query46	1115	1250	728	728
query47	2384	2418	2253	2253
query48	424	449	299	299
query49	628	502	393	393
query50	977	354	256	256
query51	4383	4253	4273	4253
query52	107	106	94	94
query53	247	284	212	212
query54	317	276	258	258
query55	96	92	84	84
query56	305	307	315	307
query57	1459	1430	1340	1340
query58	301	278	267	267
query59	1572	1693	1422	1422
query60	329	327	318	318
query61	152	156	148	148
query62	706	653	580	580
query63	253	203	211	203
query64	2379	803	646	646
query65 query66	1665	521	367	367
query67	29797	29721	29655	29655
query68 query69	464	352	307	307
query70	995	999	987	987
query71	300	270	268	268
query72	3042	2746	2438	2438
query73	819	803	438	438
query74	5113	5004	4798	4798
query75	2692	2618	2294	2294
query76	2289	1158	763	763
query77	409	415	351	351
query78	12337	12465	11917	11917
query79	1506	1063	754	754
query80	679	570	458	458
query81	455	284	237	237
query82	1415	166	126	126
query83	373	282	250	250
query84	266	141	112	112
query85	879	568	454	454
query86	399	317	341	317
query87	3451	3429	3252	3252
query88	3637	2736	2729	2729
query89	444	402	353	353
query90	1903	185	177	177
query91	179	181	151	151
query92	84	81	78	78
query93	1500	1432	849	849
query94	556	373	307	307
query95	707	483	349	349
query96	1034	775	327	327
query97	2719	2758	2657	2657
query98	240	226	238	226
query99	1163	1158	1018	1018
Total cold run time: 254811 ms
Total hot run time: 172076 ms

freemandealer · 2026-05-27T12:40:58Z

run p0

hello-stephen · 2026-05-27T13:58:57Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (23/23) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.71% (28028/38027)
Line Coverage	57.68% (304459/527872)
Region Coverage	54.94% (255333/464771)
Branch Coverage	56.34% (110074/195358)

hello-stephen · 2026-05-27T14:29:05Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (23/23) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.71% (28030/38027)
Line Coverage	57.68% (304485/527872)
Region Coverage	54.94% (255348/464771)
Branch Coverage	56.35% (110083/195358)

github-actions · 2026-05-28T04:04:12Z

PR approved by at least one committer and no changes requested.

freemandealer · 2026-05-28T07:31:04Z

/review

github-actions

I found two test reliability issues that should be fixed before merging. The direct partial-hit fix itself is covered by a focused unit test, and the async touch implementation is guarded by a new mutable config, but the new tests currently leave global state polluted and one async-LRU assertion is still scheduler dependent.

Critical checkpoint conclusions:

Goal/test proof: the PR fixes direct partial-hit continuation and adds async LRU touch coverage, but the new tests are not fully deterministic yet.
Scope: implementation changes are mostly focused, aside from enabling direct cache-file reads by default.
Concurrency: the changed paths involve cache mutex/background LRU update concurrency; no production deadlock issue was confirmed, but the test reads outcomes via wall-clock scheduling.
Lifecycle/static initialization: no new cross-TU static initialization hazard found.
Configuration: a new async-touch config is added and the direct-read default changes; test config restoration is incomplete.
Compatibility/storage format: no storage/protocol compatibility issue found.
Parallel paths: direct and indirect cache-read paths were reviewed; no additional missed production path was confirmed.
Test coverage/results: tests exist, but two reliability issues below need correction.
Observability: existing metrics/logging appear sufficient for this change.
Transaction/persistence/data-write correctness: not applicable to this cache-reader/test-focused PR.
FE/BE variable passing: not applicable.
Performance: async touch reduces work under the cache mutex when enabled; no blocking performance regression was confirmed.

User focus: no additional user-provided review focus was specified.

the test is correct

…n cache reader (#61083) - CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead) - Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting - Established performance unit tests for cache lock Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

…n cache reader (apache#61083) - CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead) - Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting - Established performance unit tests for cache lock Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>

…artial hit in cache reader(pick#61083) (#64234) Original PR: #61083 Picked to: branch-4.1 Pick branch: freemandealer:pick-branch-4.1-pr-61083 Validation: - git diff --check - build-support/check-format.sh with clang-format 16 Notes: The first two original commits were already present in branch-4.1 and were skipped as empty; picked the remaining commits.

### What problem does this PR solve? Issue Number: None Related PR: #61083 Problem Summary: The branch-4.0 pick of #61083 added an mtime() override to the mock file reader used by cached_remote_file_reader_lock_wait_test.cpp. branch-4.0 FileReader does not define mtime(), so BE UT compilation fails with only virtual member functions can be marked override. Remove the branch-incompatible mock method so the test matches the branch-4.0 FileReader interface and the BE UT target compiles. ### Release note None ### Check List (For Author) - Test: Unit Test - DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 sh run-be-ut.sh --run --filter=CachedRemoteFileReaderLockWaitTest.AsyncTouchOnGetOrSetDefersLruUpdate - build-support/check-format.sh with clang-format 16 - git diff --check - Behavior changed: No - Does this need documentation: No

…artial hit in cache reader #61083 (#63957) Cherry-picked from #61083 --------- Signed-off-by: zhengyu <zhangzhengyu@selectdb.com> Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>

freemandealer requested review from dataroaring and gavinchou as code owners March 5, 2026 10:47

freemandealer changed the title ~~Task opt lock apply two commits with conflict reso~~[fix](filecache) add async lru update machanism and fix partial hit in cache readerMar 5, 2026

gavinchou previously approved these changes Mar 11, 2026
View reviewed changes

gavinchou added dev/3.1.x dev/4.0.x labels Mar 11, 2026

freemandealer dismissed gavinchou’s stale review via 6b7db78March 27, 2026 06:36

gavinchou added the dev/4.1.x label Mar 27, 2026

gavinchou previously approved these changes Mar 27, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2026

github-actionsBot added the reviewed label Mar 27, 2026

pingchunzhang approved these changes Mar 27, 2026
View reviewed changes

freemandealer dismissed gavinchou’s stale review via 883b1f2April 23, 2026 10:06

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 23, 2026

gavinchou approved these changes May 28, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 28, 2026

github-actionsBot previously requested changes May 28, 2026
View reviewed changes

Comment threadbe/test/io/cache/block_file_cache_test_lru_dump.cpp
Comment threadbe/test/io/cache/cached_remote_file_reader_test.cpp

freemandealer merged commit c084174 into apache:masterJun 1, 2026
40 of 50 checks passed

github-actionsBot mentioned this pull request Jun 1, 2026
branch-4.0: [fix](filecache) add async lru update machanism and fix partial hit in cache reader #61083 #63957
Merged

github-actionsBot added the dev/4.1.x-conflict label Jun 1, 2026

freemandealer added the dev/3.1.5-merged label Jun 8, 2026

freemandealer mentioned this pull request Jun 8, 2026
branch-4.1: [fix](filecache) add async lru update machanism and fix partial hit in cache reader(pick#61083) #64234
Merged

yiguolei added dev/4.1.2-merged and removed dev/4.1.x dev/4.1.x-conflict labels Jun 9, 2026

morningman added dev/4.0.7-merged and removed dev/4.0.x labels Jun 11, 2026

yiguolei mentioned this pull request Jun 14, 2026
4.1.2 Release Notes #64485
Closed

gavinchou removed the dev/3.1.x label Jun 24, 2026

morningman mentioned this pull request Jul 9, 2026
4.0.7 Release Notes #65399
Closed

Uh oh!

Conversation

freemandealer commented Mar 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 5, 2026

Uh oh!

freemandealer commented Mar 5, 2026

Uh oh!

doris-robot commented Mar 5, 2026

Uh oh!

doris-robot commented Mar 5, 2026

Uh oh!

doris-robot commented Mar 5, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Mar 5, 2026

BE Regression && UT Coverage Report

Uh oh!

freemandealer commented Mar 11, 2026

Uh oh!

freemandealer commented Mar 27, 2026

Uh oh!

github-actionsBot commented Mar 27, 2026

Uh oh!

github-actionsBot commented Mar 27, 2026

Uh oh!

doris-robot commented Mar 27, 2026

Uh oh!

doris-robot commented Mar 27, 2026

Uh oh!

doris-robot commented Mar 27, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Mar 27, 2026

BE Regression && UT Coverage Report

Uh oh!

freemandealer commented Apr 23, 2026

Uh oh!

hello-stephen commented May 27, 2026

Uh oh!

hello-stephen commented May 27, 2026

Uh oh!

freemandealer commented May 27, 2026

Uh oh!

hello-stephen commented May 27, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented May 27, 2026

BE Regression && UT Coverage Report

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

freemandealer commented May 28, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

freemandealer commented Mar 5, 2026•
edited
Loading