Skip to content

[chore](test) fix duplicated table name in predefined_typed_to_sparse_1shard - #61115

Merged
eldenmoon merged 2 commits into
apache:masterfrom
eldenmoon:ct
Mar 9, 2026
Merged

[chore](test) fix duplicated table name in predefined_typed_to_sparse_1shard#61115
eldenmoon merged 2 commits into
apache:masterfrom
eldenmoon:ct

Conversation

@eldenmoon

Copy link
Copy Markdown
Member

No description provided.

CopilotAI review requested due to automatic review settings March 6, 2026 14:44
@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon

Copy link
Copy Markdown
MemberAuthor

run buildall

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression test flakiness risk by ensuring the _1shard variant predefine test uses a unique table name, avoiding collisions with the non-_1shard suite.

Changes:

  • Update the test table name in test_predefine_typed_to_sparse_1shard to be unique (test_predefine_typed_to_sparse_1shard).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eldenmooneldenmoon changed the title [chore](test) fix duplicated table name in test_predefine_typed_to_sp…[chore](test) fix duplicated table name in predefined_typed_to_sparse_1shardMar 6, 2026
@eldenmoon

Copy link
Copy Markdown
MemberAuthor

run buildall

@csun5285csun5285 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 9, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@eldenmoon
eldenmoon merged commit 2d46dae into apache:masterMar 9, 2026
30 checks passed
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Mar 16, 2026
yiguolei pushed a commit that referenced this pull request Mar 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/4.1.0-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@eldenmoon@Thearas@hello-stephen@csun5285@yiguolei