[Fix](tz) Fix some issues about timezone by linrrzqqq · Pull Request #61151 · apache/doris

linrrzqqq · 2026-03-09T09:07:38Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

fix the issue that TimestampTz-related test functions are useless in p0.
Fix the issue hour_ceil and hour_floor functions fail to identify TimestampTz type

-- before
Doris>select hour_ceil('2023-12-31 23:59:59.999+00:00', 6) Before;
+-------------------------+
| Before |
+-------------------------+
| 2024-01-0112:00:00.000 |
+-------------------------+-- now
Doris>select hour_ceil('2023-12-31 23:59:59.999+00:00', 6) Fixed;
+-------------------------------+
| Fixed |
+-------------------------------+
| 2024-01-0112:00:00.000+08:00 |
+-------------------------------+

Fixed the issue of internal cache not supporting a 45 minute offset.

SET time_zone ='+08:45';
-- before
Doris>select hour_ceil('2023-12-31 23:59:59.999+00:00', 6) Before;
+-------------------------------+
| Before |
+-------------------------------+
| 2024-01-0100:00:00.000+00:00 |
+-------------------------------+-- now
Doris>select date_ceil('2023-12-31 23:00:00+00:00', interval 6 hour) Fixed;
+---------------------------+
| Fixed |
+---------------------------+
| 2024-01-0112:00:00+08:45 |
+---------------------------+

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-03-09T09:07:46Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

linrrzqqq · 2026-03-09T09:34:43Z

run buildall

doris-robot · 2026-03-09T10:11:34Z

TPC-H: Total hot run time: 27609 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c8709af0d03ee8d50792c9d0d24e6f2f67b1ac9, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17635	4548	4305	4305
q2	q3	10646	786	499	499
q4	4679	364	247	247
q5	7543	1209	1023	1023
q6	173	176	148	148
q7	789	849	656	656
q8	9298	1493	1341	1341
q9	4912	4748	4658	4658
q10	6305	1904	1661	1661
q11	460	263	236	236
q12	730	567	460	460
q13	18037	2964	2157	2157
q14	231	224	216	216
q15	949	807	825	807
q16	758	722	666	666
q17	720	836	433	433
q18	6035	5450	5273	5273
q19	1126	989	628	628
q20	490	488	393	393
q21	4456	2126	1539	1539
q22	400	320	263	263
Total cold run time: 96372 ms
Total hot run time: 27609 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4694	4704	4558	4558
q2	q3	3918	4312	3831	3831
q4	845	1196	766	766
q5	4035	4329	4382	4329
q6	185	173	150	150
q7	1811	1691	1525	1525
q8	2475	2741	2561	2561
q9	7514	7491	7396	7396
q10	3746	3950	3619	3619
q11	501	426	417	417
q12	482	611	447	447
q13	2891	3273	2383	2383
q14	286	294	282	282
q15	847	812	806	806
q16	718	758	710	710
q17	1152	1449	1397	1397
q18	7314	6796	6619	6619
q19	864	846	858	846
q20	2105	2183	2053	2053
q21	4013	3463	3419	3419
q22	478	421	368	368
Total cold run time: 50874 ms
Total hot run time: 48482 ms

doris-robot · 2026-03-09T10:21:36Z

TPC-DS: Total hot run time: 153453 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c8709af0d03ee8d50792c9d0d24e6f2f67b1ac9, data reload: false
query5	4326	644	517	517
query6	335	237	219	219
query7	4212	468	268	268
query8	346	244	229	229
query9	8741	2762	2714	2714
query10	489	369	362	362
query11	7365	5889	5619	5619
query12	178	129	128	128
query13	1267	448	361	361
query14	5792	3803	3578	3578
query14_1	2826	2823	2823	2823
query15	204	198	179	179
query16	1001	491	470	470
query17	1116	718	614	614
query18	2453	457	354	354
query19	209	211	181	181
query20	155	133	132	132
query21	227	147	133	133
query22	5067	5146	4916	4916
query23	15888	15657	15280	15280
query23_1	15513	16592	15907	15907
query24	7720	1707	1259	1259
query24_1	1280	1284	1328	1284
query25	596	529	541	529
query26	1401	313	176	176
query27	3206	517	299	299
query28	4993	1980	2018	1980
query29	902	599	606	599
query30	398	264	222	222
query31	1398	1357	1294	1294
query32	84	75	75	75
query33	558	355	291	291
query34	916	940	569	569
query35	627	676	594	594
query36	1118	1142	1022	1022
query37	128	91	86	86
query38	2960	2927	2846	2846
query39	918	862	866	862
query39_1	836	835	832	832
query40	233	151	140	140
query41	65	60	60	60
query42	302	296	303	296
query43	236	251	222	222
query44 query45	204	190	184	184
query46	869	986	609	609
query47	2150	2150	2066	2066
query48	307	327	232	232
query49	672	446	377	377
query50	696	274	217	217
query51	4091	4097	4082	4082
query52	287	289	279	279
query53	286	336	279	279
query54	288	270	272	270
query55	90	93	88	88
query56	318	329	314	314
query57	1365	1330	1313	1313
query58	292	272	272	272
query59	1335	1422	1338	1338
query60	320	350	323	323
query61	152	150	142	142
query62	637	586	534	534
query63	307	279	281	279
query64	5129	1254	1015	1015
query65 query66	1461	469	348	348
query67	16255	16262	16285	16262
query68 query69	393	306	291	291
query70	971	944	973	944
query71	347	306	295	295
query72	2771	2652	2472	2472
query73	540	563	313	313
query74	9951	9898	9802	9802
query75	2858	2793	2439	2439
query76	2281	1030	664	664
query77	358	420	317	317
query78	11104	11293	10684	10684
query79	2948	808	610	610
query80	1752	617	533	533
query81	566	272	246	246
query82	975	146	115	115
query83	328	259	247	247
query84	248	110	106	106
query85	881	496	439	439
query86	429	299	298	298
query87	3139	3114	2997	2997
query88	3544	2639	2646	2639
query89	425	378	350	350
query90	2033	176	184	176
query91	169	164	135	135
query92	79	76	69	69
query93	1212	835	492	492
query94	633	313	302	302
query95	583	391	310	310
query96	654	508	223	223
query97	2475	2518	2425	2425
query98	236	217	222	217
query99	1029	964	950	950
Total cold run time: 236822 ms
Total hot run time: 153453 ms

linrrzqqq · 2026-03-10T09:12:39Z

run buildall

doris-robot · 2026-03-10T09:51:17Z

TPC-H: Total hot run time: 27560 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 74ff421911ac244357147bd94d2c95c8b5aac444, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17675	4533	4309	4309
q2	q3	10644	809	509	509
q4	4670	360	255	255
q5	7558	1204	1030	1030
q6	177	176	148	148
q7	775	834	671	671
q8	9291	1446	1309	1309
q9	4853	4760	4699	4699
q10	6294	1897	1646	1646
q11	472	276	247	247
q12	735	585	473	473
q13	18056	2956	2172	2172
q14	232	227	220	220
q15	951	802	806	802
q16	770	726	675	675
q17	745	894	389	389
q18	5959	5435	5227	5227
q19	1126	1008	607	607
q20	503	498	389	389
q21	4461	2047	1494	1494
q22	395	341	289	289
Total cold run time: 96342 ms
Total hot run time: 27560 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4732	4728	4608	4608
q2	q3	3934	4389	3857	3857
q4	902	1210	788	788
q5	4055	4322	4359	4322
q6	182	177	144	144
q7	1757	1689	1541	1541
q8	2442	2704	2616	2616
q9	7634	7357	7358	7357
q10	3773	4124	3768	3768
q11	538	436	431	431
q12	485	592	441	441
q13	2698	3382	2407	2407
q14	297	301	296	296
q15	851	791	815	791
q16	723	764	739	739
q17	1326	1423	1366	1366
q18	7268	6937	6719	6719
q19	934	1011	938	938
q20	2071	2160	2004	2004
q21	3981	3429	3392	3392
q22	475	419	417	417
Total cold run time: 51058 ms
Total hot run time: 48942 ms

doris-robot · 2026-03-10T10:01:18Z

TPC-DS: Total hot run time: 153509 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 74ff421911ac244357147bd94d2c95c8b5aac444, data reload: false
query5	4314	660	529	529
query6	330	221	210	210
query7	4209	474	268	268
query8	340	247	240	240
query9	8695	2746	2736	2736
query10	504	373	356	356
query11	7309	5803	5592	5592
query12	183	128	137	128
query13	1273	453	348	348
query14	5792	3810	3569	3569
query14_1	2870	2851	2845	2845
query15	211	199	175	175
query16	988	496	460	460
query17	900	745	636	636
query18	2442	455	356	356
query19	239	220	189	189
query20	133	134	131	131
query21	227	148	123	123
query22	4642	4876	4729	4729
query23	15939	15549	15319	15319
query23_1	15485	16300	15949	15949
query24	7661	1667	1318	1318
query24_1	1322	1324	1312	1312
query25	593	504	454	454
query26	1261	276	169	169
query27	3057	482	292	292
query28	4936	1948	1926	1926
query29	900	683	476	476
query30	318	261	222	222
query31	1454	1351	1323	1323
query32	83	79	93	79
query33	555	360	283	283
query34	906	913	580	580
query35	627	681	583	583
query36	1085	1086	981	981
query37	135	92	81	81
query38	2980	2937	2860	2860
query39	886	869	849	849
query39_1	824	815	830	815
query40	238	151	134	134
query41	63	57	56	56
query42	314	301	295	295
query43	239	247	231	231
query44 query45	200	188	185	185
query46	880	976	599	599
query47	2108	2115	2022	2022
query48	324	320	230	230
query49	627	478	391	391
query50	667	278	216	216
query51	4110	4149	4051	4051
query52	292	291	280	280
query53	293	335	283	283
query54	296	282	263	263
query55	92	85	86	85
query56	325	333	314	314
query57	1360	1336	1263	1263
query58	293	279	280	279
query59	1340	1409	1275	1275
query60	329	337	319	319
query61	151	148	146	146
query62	631	591	540	540
query63	311	281	276	276
query64	5077	1300	1000	1000
query65 query66	1468	471	352	352
query67	16444	16532	16362	16362
query68 query69	404	318	283	283
query70	1010	998	976	976
query71	340	305	300	300
query72	2789	2774	2630	2630
query73	577	554	331	331
query74	10019	9966	9845	9845
query75	2871	2793	2508	2508
query76	2278	1062	689	689
query77	360	384	331	331
query78	11121	11205	10695	10695
query79	2979	813	607	607
query80	1761	674	545	545
query81	587	285	239	239
query82	1013	150	115	115
query83	332	266	244	244
query84	295	119	94	94
query85	906	484	428	428
query86	490	304	299	299
query87	3143	3178	3005	3005
query88	3552	2690	2677	2677
query89	422	368	346	346
query90	2067	181	176	176
query91	168	157	133	133
query92	87	69	72	69
query93	1769	831	500	500
query94	640	317	293	293
query95	606	397	322	322
query96	632	516	226	226
query97	2459	2477	2465	2465
query98	237	220	220	220
query99	967	1000	924	924
Total cold run time: 236226 ms
Total hot run time: 153509 ms

doris-robot · 2026-03-11T08:42:57Z

TPC-H: Total hot run time: 27756 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08532e6726b7b0072eca361bd9c1125213204958, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17647	4426	4313	4313
q2	q3	10631	779	519	519
q4	4675	385	252	252
q5	7547	1204	1044	1044
q6	174	176	145	145
q7	787	833	670	670
q8	9295	1490	1388	1388
q9	4944	4834	4739	4739
q10	6259	1899	1644	1644
q11	457	269	247	247
q12	696	576	459	459
q13	18033	2934	2186	2186
q14	228	230	214	214
q15	894	794	804	794
q16	753	732	679	679
q17	748	885	419	419
q18	5980	5443	5248	5248
q19	1239	1003	616	616
q20	505	507	387	387
q21	4725	2230	1535	1535
q22	413	345	258	258
Total cold run time: 96630 ms
Total hot run time: 27756 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4734	4537	4524	4524
q2	q3	3875	4369	3843	3843
q4	911	1230	788	788
q5	4140	4367	4388	4367
q6	196	185	150	150
q7	1789	1677	1540	1540
q8	2511	2866	2554	2554
q9	7640	7525	7099	7099
q10	3793	4079	3580	3580
q11	551	452	419	419
q12	507	647	463	463
q13	2753	3102	2324	2324
q14	308	325	286	286
q15	883	817	805	805
q16	728	759	756	756
q17	1247	1405	1333	1333
q18	7329	6822	6547	6547
q19	912	963	913	913
q20	2104	2189	2081	2081
q21	3985	3560	3337	3337
q22	531	471	374	374
Total cold run time: 51427 ms
Total hot run time: 48083 ms

doris-robot · 2026-03-11T08:52:58Z

TPC-DS: Total hot run time: 153720 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08532e6726b7b0072eca361bd9c1125213204958, data reload: false
query5	4322	663	522	522
query6	337	243	216	216
query7	4221	474	276	276
query8	346	253	250	250
query9	8755	2747	2759	2747
query10	557	386	386	386
query11	7286	5874	5620	5620
query12	192	136	132	132
query13	1290	476	346	346
query14	5902	3904	3622	3622
query14_1	2899	2811	2816	2811
query15	198	194	180	180
query16	1000	457	454	454
query17	1115	722	614	614
query18	2438	464	352	352
query19	215	217	190	190
query20	136	134	131	131
query21	220	147	119	119
query22	4946	5121	4870	4870
query23	16631	16364	15798	15798
query23_1	15904	15850	16062	15850
query24	7697	1645	1241	1241
query24_1	1247	1253	1237	1237
query25	581	495	486	486
query26	1243	272	152	152
query27	2764	471	300	300
query28	4522	1867	1854	1854
query29	897	570	474	474
query30	317	249	214	214
query31	1348	1281	1226	1226
query32	83	76	73	73
query33	512	334	277	277
query34	934	939	550	550
query35	654	679	601	601
query36	1096	1133	1007	1007
query37	138	93	86	86
query38	2916	2918	2859	2859
query39	956	872	836	836
query39_1	828	827	856	827
query40	224	155	134	134
query41	63	99	60	60
query42	298	303	307	303
query43	249	253	217	217
query44 query45	197	193	185	185
query46	902	991	611	611
query47	2153	2136	2052	2052
query48	313	323	235	235
query49	639	463	392	392
query50	700	288	212	212
query51	4211	4141	4102	4102
query52	292	293	286	286
query53	292	339	285	285
query54	309	274	265	265
query55	91	86	85	85
query56	340	347	308	308
query57	1353	1341	1302	1302
query58	288	306	281	281
query59	1383	1486	1323	1323
query60	348	336	322	322
query61	176	149	157	149
query62	651	577	536	536
query63	308	285	281	281
query64	5190	1311	1013	1013
query65 query66	1473	474	369	369
query67	16332	16437	16347	16347
query68 query69	399	315	275	275
query70	956	979	964	964
query71	347	322	303	303
query72	2819	2705	2413	2413
query73	554	565	324	324
query74	9975	9887	9739	9739
query75	2891	2769	2470	2470
query76	2306	1059	687	687
query77	388	384	320	320
query78	11148	11313	10668	10668
query79	1171	811	591	591
query80	1352	628	534	534
query81	568	283	246	246
query82	1005	151	122	122
query83	341	267	244	244
query84	249	125	97	97
query85	921	481	476	476
query86	428	296	306	296
query87	3200	3103	3019	3019
query88	3593	2699	2659	2659
query89	437	373	342	342
query90	2023	180	184	180
query91	170	168	135	135
query92	83	74	73	73
query93	971	848	503	503
query94	653	331	292	292
query95	604	352	384	352
query96	641	528	231	231
query97	2476	2521	2457	2457
query98	235	226	235	226
query99	1023	1013	915	915
Total cold run time: 234924 ms
Total hot run time: 153720 ms

hello-stephen · 2026-03-11T09:35:51Z

FE UT Coverage Report

Increment line coverage 100.00% (18/18) 🎉
Increment coverage report
Complete coverage report

zclllyybb

LGTM

zclllyybb · 2026-03-12T02:43:44Z

/review

github-actions · 2026-03-12T02:44:41Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-03-12T02:44:43Z

PR approved by anyone and no changes requested.

hello-stephen · 2026-03-12T08:56:39Z

skip check_coverage

Cherry-picked from #61151 Co-authored-by: linrrarity <linzhenqi@selectdb.com>

[Fix](tz) Fix some issues about timezone
6c8709a

linrrzqqq force-pushed the fix-tz-p0 branch from 5402385 to 6c8709aCompare March 9, 2026 09:34

yiguolei added the dev/4.0.x label Mar 10, 2026

fix-p0
74ff421

fix test
08532e6

zclllyybb approved these changes Mar 12, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2026

github-actionsBot added the reviewed label Mar 12, 2026

wyxxxcat approved these changes Mar 12, 2026
View reviewed changes

zclllyybb added the dev/4.1.x label Mar 12, 2026

hello-stephen merged commit 406c483 into apache:masterMar 12, 2026
29 of 31 checks passed

linrrzqqq deleted the fix-tz-p0 branch March 12, 2026 08:58

github-actionsBot pushed a commit that referenced this pull request Mar 12, 2026
[Fix](tz) Fix some issues about timezone (#61151)
f80df42

github-actionsBot mentioned this pull request Mar 12, 2026
branch-4.0: [Fix](tz) Fix some issues about timezone #61151 #61264
Merged

yiguolei pushed a commit that referenced this pull request Mar 13, 2026
branch-4.0: [Fix](tz) Fix some issues about timezone#61151(#61264)
bd2b354
Cherry-picked from #61151 Co-authored-by: linrrarity <linzhenqi@selectdb.com>

yiguolei removed the dev/4.0.x label Mar 13, 2026

yiguolei added dev/4.0.5-merged dev/4.1.0-merged and removed dev/4.1.x labels Mar 13, 2026

yiguolei mentioned this pull request Mar 27, 2026
4.0.5 Release Notes #61817
Closed

Uh oh!

Conversation

linrrzqqq commented Mar 9, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Mar 9, 2026

Uh oh!

linrrzqqq commented Mar 9, 2026

Uh oh!

doris-robot commented Mar 9, 2026

Uh oh!

doris-robot commented Mar 9, 2026

Uh oh!

linrrzqqq commented Mar 10, 2026

Uh oh!

doris-robot commented Mar 10, 2026

Uh oh!

doris-robot commented Mar 10, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

hello-stephen commented Mar 11, 2026

FE UT Coverage Report

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

zclllyybb commented Mar 12, 2026

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

hello-stephen commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants