Skip to content

[fix](load) fix load memory usage is more than branch-3.1 - #61173

Merged
yiguolei merged 3 commits into
apache:branch-4.0from
jacktengg:260309-test-memtable-4.0
Mar 12, 2026
Merged

[fix](load) fix load memory usage is more than branch-3.1#61173
yiguolei merged 3 commits into
apache:branch-4.0from
jacktengg:260309-test-memtable-4.0

Conversation

@jacktengg

@jacktenggjacktengg commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
jacktenggforce-pushed the 260309-test-memtable-4.0 branch 2 times, most recently from 744bbad to 06779b7CompareMarch 11, 2026 03:00
@jacktengg
jacktenggforce-pushed the 260309-test-memtable-4.0 branch from 80d531a to 7f3ce25CompareMarch 12, 2026 01:32
@jacktenggjacktengg changed the title [test](memtable) test memtable mem tracker[fix](load) fix load memory usage is more than branch-3.1Mar 12, 2026
yiguolei
yiguolei reviewed Mar 12, 2026
View reviewed changes
Comment threadbe/src/vec/common/pod_array.h
yiguolei
yiguolei reviewed Mar 12, 2026
View reviewed changes
Comment threadbe/src/vec/common/pod_array.h
yiguolei
yiguolei reviewed Mar 12, 2026
View reviewed changes
Comment threadbe/src/vec/common/pod_array_fwd.h
*/
template <typename T, size_t initial_bytes = 4096,
typename TAllocator = Allocator<false, false, false, DefaultMemoryAllocator, false>>
template <typename T, size_t initial_bytes = 4096, typename TAllocator = Allocator<false>>

@yiguoleiyiguoleiMar 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不要直接这么写，要回滚到，之前那个pr的写法

@jacktenggjacktenggMar 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的写法，就是123c649328cb84f6394db29a149b11fdc5809c9b， pr #50737的写法，也就是 "opt Optimize PODArray memory tracking accuracy (#50549)"前面那个pr的写法。

yiguolei
yiguolei reviewed Mar 12, 2026
View reviewed changes
Comment threadbe/src/vec/common/pod_array.h
@jacktengg

jacktengg commented Mar 12, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

yiguolei
yiguolei previously approved these changes Mar 12, 2026
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2026
@github-actions

github-actionsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@jacktengg
jacktenggforce-pushed the 260309-test-memtable-4.0 branch from 0dc7fd3 to ea370f6CompareMarch 12, 2026 03:59
@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Mar 12, 2026
@jacktengg
jacktenggforce-pushed the 260309-test-memtable-4.0 branch from ea370f6 to 9c0fd99CompareMarch 12, 2026 04:39
@jacktengg

jacktengg commented Mar 12, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@jacktengg

jacktengg commented Mar 12, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 77.78% (7/9) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.00% (19160/36153)
Line Coverage36.18% (178413/493143)
Region Coverage32.80% (138298/421641)
Branch Coverage33.80% (60085/177744)

@hello-stephen

hello-stephen commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 88.89% (8/9) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.42% (25293/35414)
Line Coverage54.01% (266008/492519)
Region Coverage51.61% (219944/426132)
Branch Coverage53.17% (94912/178505)

@yiguolei
yiguolei merged commit 6ef6140 into apache:branch-4.0Mar 12, 2026
26 of 28 checks passed
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Mar 14, 2026
@jacktengg
[fix](load) fix load memory usage is more than branch-3.1 (apache#61173)
049b8c6
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Mar 15, 2026
@jacktengg
[fix](load) fix load memory usage is more than branch-3.1 (#61173) (#…
f4d58b3
…61327)
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change. - [ ] No code files have been
changed. - [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacktengg@Thearas@hello-stephen@yiguolei