[be](refactor) move rowtype template parameter from key util by yiguolei · Pull Request #61226 · apache/doris

yiguolei · 2026-03-11T08:38:53Z

What problem does this PR solve?

remove rowtype template parameter from encode key methods
move encode key methods from key util to rowcurosr because it only encode rowcursor.
move _key_is_not_in_segment to base tablet

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-03-11T08:38:59Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yiguolei · 2026-03-11T08:39:03Z

run buildall

doris-robot · 2026-03-11T09:09:22Z

TPC-H: Total hot run time: 27572 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 572e3cdf615929dad24405b09fe00278011233cd, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17598	4524	4279	4279
q2	q3	10658	802	530	530
q4	4675	363	253	253
q5	7553	1194	1012	1012
q6	176	177	150	150
q7	791	840	659	659
q8	9302	1486	1333	1333
q9	4945	4728	4728	4728
q10	6307	1913	1664	1664
q11	472	268	239	239
q12	745	580	476	476
q13	18077	2934	2201	2201
q14	229	237	216	216
q15	924	811	806	806
q16	766	734	679	679
q17	736	891	406	406
q18	5961	5437	5283	5283
q19	1244	993	618	618
q20	505	491	390	390
q21	4742	1833	1398	1398
q22	339	280	252	252
Total cold run time: 96745 ms
Total hot run time: 27572 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4400	4365	4340	4340
q2	q3	3845	4266	3769	3769
q4	837	1173	770	770
q5	4034	4327	4346	4327
q6	181	177	137	137
q7	1747	1609	1484	1484
q8	2430	2645	2514	2514
q9	7207	7079	7079	7079
q10	3652	3891	3592	3592
q11	504	422	422	422
q12	462	571	440	440
q13	2586	2981	2191	2191
q14	266	285	268	268
q15	822	788	779	779
q16	689	761	697	697
q17	1088	1327	1335	1327
q18	7116	6722	6545	6545
q19	838	816	880	816
q20	2007	2097	1938	1938
q21	3889	3443	3310	3310
q22	454	417	373	373
Total cold run time: 49054 ms
Total hot run time: 47118 ms

doris-robot · 2026-03-11T09:19:21Z

TPC-DS: Total hot run time: 152673 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 572e3cdf615929dad24405b09fe00278011233cd, data reload: false
query5	4334	650	514	514
query6	335	229	230	229
query7	4206	471	266	266
query8	350	243	230	230
query9	8707	2763	2782	2763
query10	511	402	365	365
query11	7427	5786	5669	5669
query12	189	128	126	126
query13	1264	467	356	356
query14	6760	3839	3641	3641
query14_1	2851	2847	2785	2785
query15	205	200	179	179
query16	981	478	473	473
query17	1266	718	635	635
query18	2721	451	352	352
query19	206	211	185	185
query20	142	126	129	126
query21	227	147	124	124
query22	4942	4914	4930	4914
query23	15867	15569	15376	15376
query23_1	15410	15414	15492	15414
query24	7185	1626	1220	1220
query24_1	1235	1248	1246	1246
query25	581	502	440	440
query26	1252	280	158	158
query27	2729	476	291	291
query28	4452	1899	1883	1883
query29	885	592	508	508
query30	326	255	217	217
query31	1384	1304	1233	1233
query32	85	86	78	78
query33	537	342	292	292
query34	920	918	570	570
query35	652	702	599	599
query36	1084	1130	966	966
query37	140	106	90	90
query38	2909	2947	2879	2879
query39	1017	904	860	860
query39_1	871	839	832	832
query40	242	158	184	158
query41	68	61	62	61
query42	313	314	307	307
query43	248	246	233	233
query44 query45	198	186	182	182
query46	883	978	602	602
query47	2108	2129	2029	2029
query48	306	318	228	228
query49	629	463	397	397
query50	684	276	218	218
query51	4382	4111	4032	4032
query52	293	293	282	282
query53	292	352	291	291
query54	299	288	277	277
query55	94	87	83	83
query56	312	323	313	313
query57	1345	1317	1287	1287
query58	287	282	286	282
query59	1293	1473	1291	1291
query60	355	334	324	324
query61	151	145	139	139
query62	609	570	545	545
query63	311	284	287	284
query64	4973	1251	988	988
query65 query66	1382	464	369	369
query67	16279	16396	16287	16287
query68 query69	392	316	285	285
query70	939	979	923	923
query71	342	309	290	290
query72	2986	2614	2391	2391
query73	543	548	326	326
query74	9988	9951	9828	9828
query75	2845	2750	2477	2477
query76	2309	1024	684	684
query77	367	434	325	325
query78	11277	11285	10606	10606
query79	2610	790	615	615
query80	1798	620	523	523
query81	575	290	250	250
query82	955	152	119	119
query83	332	264	238	238
query84	247	111	99	99
query85	895	499	469	469
query86	413	321	290	290
query87	3106	3161	3037	3037
query88	3519	2652	2648	2648
query89	431	373	352	352
query90	2028	186	178	178
query91	160	161	133	133
query92	80	89	76	76
query93	1027	826	498	498
query94	655	329	294	294
query95	596	393	309	309
query96	641	522	232	232
query97	2465	2468	2430	2430
query98	233	220	221	220
query99	1006	1001	880	880
Total cold run time: 236290 ms
Total hot run time: 152673 ms

yiguolei · 2026-03-11T09:46:51Z

run buildall

doris-robot · 2026-03-11T11:42:37Z

TPC-H: Total hot run time: 27751 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03ec06adb44be618faf8fa12323182f018db4a90, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17636	4619	4349	4349
q2	q3	10638	799	531	531
q4	4679	353	254	254
q5	7558	1214	999	999
q6	178	178	146	146
q7	806	817	681	681
q8	9934	1500	1394	1394
q9	5568	4892	4742	4742
q10	6323	1951	1653	1653
q11	477	258	235	235
q12	751	577	466	466
q13	18046	3008	2200	2200
q14	234	230	222	222
q15	935	808	830	808
q16	741	728	670	670
q17	734	851	415	415
q18	6168	5513	5258	5258
q19	1166	986	590	590
q20	488	501	385	385
q21	4676	1999	1476	1476
q22	393	332	277	277
Total cold run time: 98129 ms
Total hot run time: 27751 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4721	4610	4718	4610
q2	q3	3993	4347	3865	3865
q4	883	1224	778	778
q5	4094	4381	4319	4319
q6	185	175	139	139
q7	1758	1678	1535	1535
q8	2478	2776	2557	2557
q9	7668	7408	7354	7354
q10	3804	4047	3643	3643
q11	499	426	408	408
q12	482	598	449	449
q13	2828	3164	2340	2340
q14	279	304	280	280
q15	894	829	815	815
q16	734	794	707	707
q17	1144	1404	1377	1377
q18	7204	6879	6650	6650
q19	929	895	878	878
q20	2077	2160	2007	2007
q21	4013	3414	3494	3414
q22	444	433	381	381
Total cold run time: 51111 ms
Total hot run time: 48506 ms

doris-robot · 2026-03-11T11:52:38Z

TPC-DS: Total hot run time: 153172 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03ec06adb44be618faf8fa12323182f018db4a90, data reload: false
query5	4336	640	515	515
query6	332	221	209	209
query7	4204	476	261	261
query8	345	244	226	226
query9	8751	2777	2739	2739
query10	473	405	330	330
query11	7339	5897	5640	5640
query12	191	129	125	125
query13	1252	456	339	339
query14	5759	3826	3643	3643
query14_1	2843	2793	2843	2793
query15	203	197	177	177
query16	1003	409	461	409
query17	904	743	597	597
query18	2419	433	333	333
query19	204	215	181	181
query20	135	128	124	124
query21	226	145	122	122
query22	4836	5082	4855	4855
query23	16006	15494	15347	15347
query23_1	15447	16274	15851	15851
query24	8837	1688	1314	1314
query24_1	1304	1316	1293	1293
query25	578	539	454	454
query26	1455	279	166	166
query27	2855	506	327	327
query28	4940	1985	1992	1985
query29	882	597	501	501
query30	342	265	222	222
query31	1440	1368	1368	1368
query32	90	84	80	80
query33	510	345	288	288
query34	949	976	577	577
query35	678	677	592	592
query36	1086	1111	976	976
query37	139	108	96	96
query38	2982	2943	2925	2925
query39	900	859	833	833
query39_1	945	824	823	823
query40	230	150	135	135
query41	62	59	57	57
query42	303	302	299	299
query43	235	260	222	222
query44 query45	203	190	183	183
query46	885	1003	614	614
query47	2100	2146	2077	2077
query48	351	312	241	241
query49	619	488	382	382
query50	682	280	216	216
query51	4147	4108	4070	4070
query52	285	286	284	284
query53	286	333	286	286
query54	306	269	267	267
query55	93	88	83	83
query56	313	313	307	307
query57	1358	1334	1268	1268
query58	286	280	279	279
query59	1318	1416	1297	1297
query60	350	336	302	302
query61	147	146	141	141
query62	633	592	535	535
query63	306	282	281	281
query64	5124	1272	986	986
query65 query66	1467	455	362	362
query67	16333	16357	16173	16173
query68 query69	381	312	293	293
query70	1042	1000	941	941
query71	343	322	312	312
query72	2969	2822	2554	2554
query73	531	566	320	320
query74	10090	9971	9820	9820
query75	2866	2780	2487	2487
query76	2296	1037	691	691
query77	373	395	320	320
query78	11135	11257	10644	10644
query79	3211	775	592	592
query80	1711	623	535	535
query81	589	286	248	248
query82	980	148	120	120
query83	328	263	244	244
query84	307	112	101	101
query85	906	468	434	434
query86	456	328	302	302
query87	3123	3108	3006	3006
query88	3527	2666	2620	2620
query89	418	370	344	344
query90	1996	184	176	176
query91	163	157	134	134
query92	73	76	73	73
query93	1421	818	500	500
query94	653	323	258	258
query95	577	334	316	316
query96	625	515	228	228
query97	2490	2461	2422	2422
query98	244	230	213	213
query99	996	982	914	914
Total cold run time: 236861 ms
Total hot run time: 153172 ms

hello-stephen · 2026-03-11T13:06:50Z

BE UT Coverage Report

Increment line coverage 87.30% (55/63) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.56% (19648/37384)
Line Coverage	36.17% (183249/506650)
Region Coverage	32.31% (141572/438114)
Branch Coverage	33.46% (61741/184510)

hello-stephen · 2026-03-11T14:40:50Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (63/63) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.59% (26207/36606)
Line Coverage	54.34% (274480/505109)
Region Coverage	51.52% (227864/442262)
Branch Coverage	53.05% (98191/185086)

github-actions · 2026-03-12T02:20:30Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-03-12T02:20:32Z

PR approved by anyone and no changes requested.

mrhhsg

LGTM

…61226) 1. remove rowtype template parameter from encode key methods 2. move encode key methods from key util to rowcurosr because it only encode rowcursor. 3. move _key_is_not_in_segment to base tablet Related PR: #xxx Problem Summary: None - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

yiguolei added 6 commits March 11, 2026 14:42

remove rowtype from encode key
8f4264d

f
642e4a6

f
45529f9

f
28b31dc

f
39ef0d0

f
572e3cd

yiguolei added 3 commits March 11, 2026 17:33

f
42e8641

f
7e8cf2a

f
03ec06a

mymeiyi approved these changes Mar 12, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2026

github-actionsBot added the reviewed label Mar 12, 2026

mrhhsg approved these changes Mar 12, 2026
View reviewed changes

yiguolei merged commit 22207ce into apache:masterMar 12, 2026
31 of 34 checks passed

Navigation Menu

Uh oh!

[be](refactor) move rowtype template parameter from key util - #61226

[be](refactor) move rowtype template parameter from key util#61226
yiguolei merged 9 commits into
apache:masterfrom
yiguolei:f2

yiguolei commented Mar 11, 2026•
edited
Loading

Uh oh!

Thearas commented Mar 11, 2026

Uh oh!

yiguolei commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

yiguolei commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

hello-stephen commented Mar 11, 2026

Uh oh!

hello-stephen commented Mar 11, 2026

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

mrhhsg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

yiguolei commented Mar 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 11, 2026

Uh oh!

yiguolei commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

yiguolei commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

doris-robot commented Mar 11, 2026

Uh oh!

hello-stephen commented Mar 11, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Mar 11, 2026

BE Regression && UT Coverage Report

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

github-actionsBot commented Mar 12, 2026

Uh oh!

mrhhsg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yiguolei commented Mar 11, 2026•
edited
Loading