Skip to content

[fix](ms) Add job check for stale commit rowset - #61427

Merged
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:check_idempotent_with_tablet_id
Mar 24, 2026
Merged

[fix](ms) Add job check for stale commit rowset#61427
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:check_idempotent_with_tablet_id

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Mar 17, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

when enable_recycle_delete_rowset_key_check is false, idempotent check is invalid
bug pr related: #58459

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
wyxxxcatforce-pushed the check_idempotent_with_tablet_id branch from 51eab19 to d16491bCompareMarch 17, 2026 07:33
@wyxxxcat

wyxxxcat commented Mar 17, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat
wyxxxcatforce-pushed the check_idempotent_with_tablet_id branch from d16491b to 50ab9d5CompareMarch 17, 2026 08:17
@wyxxxcat

wyxxxcat commented Mar 17, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat

wyxxxcat commented Mar 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@wyxxxcat
wyxxxcatforce-pushed the check_idempotent_with_tablet_id branch from 50ab9d5 to e2a6b6eCompareMarch 24, 2026 02:37
@wyxxxcat

wyxxxcat commented Mar 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

doris-robot commented Mar 24, 2026

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.63% (1796/2284)
Line Coverage64.36% (32266/50130)
Region Coverage65.27% (16160/24758)
Branch Coverage55.67% (8604/15454)

@github-actions

github-actionsBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2026
@gavinchou
gavinchou merged commit 528c7a2 into apache:masterMar 24, 2026
31 of 32 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 24, 2026
@wyxxxcatYour Name
[fix](ms) Add job check for stale commit rowset (#61427)
3f96b19
when enable_recycle_delete_rowset_key_check is false, idempotent check is invalid
bug pr related: #58459
@github-actionsgithub-actionsBot mentioned this pull request Mar 24, 2026
Merged
github-actionsBot pushed a commit that referenced this pull request Mar 24, 2026
@wyxxxcatYour Name
[fix](ms) Add job check for stale commit rowset (#61427)
89ffa0c
when enable_recycle_delete_rowset_key_check is false, idempotent check is invalid
bug pr related: #58459
@github-actionsgithub-actionsBot mentioned this pull request Mar 24, 2026
Merged
yiguolei pushed a commit that referenced this pull request Mar 24, 2026
@github-actions@wyxxxcat
branch-4.1: [fix](ms) Add job check for stale commit rowset#61427(#…
436d6c6
…61660)
Cherry-picked from #61427
Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
yiguolei pushed a commit that referenced this pull request Mar 24, 2026
@github-actions@wyxxxcat
branch-4.0: [fix](ms) Add job check for stale commit rowset#61427(#…
9ec0ca8
…61658)
Cherry-picked from #61427
Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
@yiguoleiyiguolei mentioned this pull request Mar 27, 2026
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Mar 31, 2026
@wyxxxcat@HappenLee
[fix](ms) Add job check for stale commit rowset (apache#61427)
89fb402
when enable_recycle_delete_rowset_key_check is false, idempotent check is invalid
bug pr related: apache#58459
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringAwaiting requested review from dataroaring
@w41terw41terAwaiting requested review from w41ter
+1 more reviewer
@linrrzqqqlinrrzqqqlinrrzqqq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.5-mergeddev/4.1.0-mergedint/3.1.5-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat@Thearas@doris-robot@gavinchou@linrrzqqq@yiguolei