Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [fix](backup) reject upload snapshots on broken storage path #61251 - #61435
Merged
Conversation
Backup upload reuses snapshot paths returned by MAKE_SNAPSHOT. When a data dir is later marked as broken, the stale snapshot directory can still remain on that disk and be picked up by upload. In that case the upload task may continue into file checksum and remote upload logic with a snapshot source that is no longer safe to read. This change adds a broken-storage-path validation step to SnapshotLoader local source path checking for upload. The check canonicalizes the snapshot path, matches it to its DataDir, and rejects the source early when the owning DataDir is offline or the path is listed in broken_storage_path. That turns the broken-disk case into a normal task error instead of letting upload continue on an invalid local snapshot source. The unit tests cover both the direct broken-path case and a canonicalized symlink path to ensure the validation cannot be bypassed by path indirection.
Thearas
commented
Mar 17, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Thearas
commented
Mar 17, 2026
Contributor
run buildall |
luwei16
commented
Mar 20, 2026
Contributor
run beut |
### What problem does this PR solve? Issue Number: None Related PR: #61251 Problem Summary: Adjust the SnapshotLoader broken-path unit tests on branch-4.0 to preseed broken storage state through EngineOptions instead of calling add_broken_path(), so the tests keep the same coverage without triggering unrelated config persistence and stacktrace code paths in this branch worktree. ### Release note None ### Check List (For Author) - Test: Targeted BE UT build started in the isolated worktree but has not completed yet because the first worktree build is still compiling dependencies and BE UT objects - Unit Test - Behavior changed: No - Does this need documentation: No
luwei16
commented
Mar 20, 2026
Contributor
run buildall |
doris-robot
commented
Mar 20, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Mar 20, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Mar 23, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61251