Skip to content

pick memcpy alignement and datetime related pr to 4.1 - #61620

Merged
yiguolei merged 3 commits into
apache:branch-4.1from
yiguolei:branch-4.1
Mar 23, 2026
Merged

pick memcpy alignement and datetime related pr to 4.1#61620
yiguolei merged 3 commits into
apache:branch-4.1from
yiguolei:branch-4.1

Conversation

@yiguolei

@yiguoleiyiguolei commented Mar 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

#60695#61277#61529

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

BiteTheDDDDtand others added 3 commits March 23, 2026 14:49
@BiteTheDDDDt@yiguolei
[Improvement](memcpy) use assume_aligned to hint aligned memcpy (apac…
c86689e
…he#60695)
This pull request improves the performance and correctness of fixed-size
memory copy operations in hash map key handling by adding
alignment-aware logic. The main changes introduce runtime alignment
checks and use compiler hints to optimize memory copying, which can help
leverage SIMD instructions and avoid undefined behavior due to
misaligned accesses.
@yiguolei
[enhancement](zonemap) add beut for olap string convertor for zonemap (…
b2a0cdf
…apache#61277)
And there is also a potential bug in zonemap. Should opt.ignore_scale =
(field_type != FieldType::OLAP_FIELD_TYPE_DECIMAL);
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@yiguolei
[bugfix](zonemap string) datetimev2 should always using scale 6 to pr…
1d56dec
…oduce string (apache#61529)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@hello-stephen

hello-stephen commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei

yiguolei commented Mar 23, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yiguoleiyiguolei changed the title Branch 4.1pick memcpy alignement and datetime related pr to 4.1Mar 23, 2026
@doris-robot

doris-robot commented Mar 23, 2026

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 54.86% (79/144) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.68% (19515/37041)
Line Coverage36.11% (182041/504091)
Region Coverage32.36% (140080/432894)
Branch Coverage33.54% (61358/182948)

@hello-stephen

hello-stephen commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 84.72% (122/144) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage72.83% (26403/36253)
Line Coverage56.08% (281750/502383)
Region Coverage53.55% (233920/436866)
Branch Coverage55.30% (101464/183468)

eldenmoon
eldenmoon approved these changes Mar 23, 2026
View reviewed changes

@eldenmooneldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 05c3316 into apache:branch-4.1Mar 23, 2026
29 of 33 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybbzclllyybbzclllyybb approved these changes
@eldenmooneldenmooneldenmoon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yiguolei@hello-stephen@doris-robot@zclllyybb@eldenmoon@BiteTheDDDDt