Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](fe) Fix bugs in SummaryProfile and StmtExecutor metric reporting #61601 - #61644
Merged
Merged
Conversation
#61601) ### What problem does this PR solve? Issue Number: close #xxx Problem Summary: Fix three bugs found in SummaryProfile and StmtExecutor: 1. **Wrong field assignment in `addNereidsPartitiionPruneTime()`** (SummaryProfile.java): The method was incorrectly accumulating partition prune time into `externalTvfInitTime` instead of `nereidsPartitiionPruneTime`. This caused: - `nereidsPartitiionPruneTime` to always be 0, so `HISTO_PLAN_PARTITION_PRUNE_DURATION` metric never collected correct data - `externalTvfInitTime` to be polluted with unrelated partition prune time data 2. **Wrong guard variable for translate metric** (StmtExecutor.java): When reporting `HISTO_PLAN_TRANSLATE_DURATION`, the condition checked `nereidsOptimizeTimeMs >= 0` instead of `nereidsTranslateTimeMs >= 0`. This means the translate metric was gated by the optimize time value rather than the translate time value itself.
yiguolei
commented
Mar 24, 2026
Contributor
run buildall |
yiguolei
approved these changes
Mar 24, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61601