Uh oh!
There was an error while loading. Please reload this page.
[fix](delete) avoid quorum stalls on delete push failures - #61647
Merged
Conversation
hello-stephen
commented
Mar 24, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Hastyshell
commented
Mar 24, 2026
CollaboratorAuthor
run buildall |
1 similar comment
Hastyshell
commented
Mar 24, 2026
CollaboratorAuthor
run buildall |
doris-robot
commented
Mar 24, 2026
TPC-H: Total hot run time: 26845 ms |
doris-robot
commented
Mar 24, 2026
TPC-DS: Total hot run time: 168796 ms |
hello-stephen
commented
Mar 24, 2026
Contributor
FE UT Coverage ReportIncrement line coverage |
Hastyshell
commented
Mar 24, 2026
CollaboratorAuthor
run buildall |
doris-robot
commented
Mar 24, 2026
TPC-H: Total hot run time: 26350 ms |
doris-robot
commented
Mar 24, 2026
TPC-DS: Total hot run time: 169756 ms |
Hastyshell
commented
Mar 24, 2026
CollaboratorAuthor
nonConcurrent |
gavinchou
previously approved these changes
Mar 25, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Hastyshellforce-pushed
the
fix-delete-ndsd-upstream
branch
from
March 26, 2026 00:04
efd4fcb to
bed1576CompareHastyshell
commented
Mar 26, 2026
CollaboratorAuthor
run buildall |
doris-robot
commented
Mar 26, 2026
TPC-H: Total hot run time: 26618 ms |
doris-robot
commented
Mar 26, 2026
TPC-DS: Total hot run time: 169026 ms |
Hastyshell
commented
Mar 30, 2026
CollaboratorAuthor
run buildall |
doris-robot
commented
Mar 30, 2026
TPC-H: Total hot run time: 26892 ms |
Yukang-Lian
approved these changes
Mar 30, 2026
Hastyshell
commented
Mar 30, 2026
CollaboratorAuthor
run vault_p0 |
doris-robot
commented
Mar 30, 2026
TPC-H: Total hot run time: 26941 ms |
doris-robot
commented
Mar 30, 2026
TPC-DS: Total hot run time: 169842 ms |
luwei16
approved these changes
Mar 31, 2026
Contributor
PR approved by at least one committer and no changes requested. |
gavinchou
approved these changes
Apr 7, 2026
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Apr 8, 2026
This ports two enterprise delete fixes to upstream master: - Avoid poisoning delete latch status for non-INVALID_ARGUMENT realtime push failures - Make PushTask.failedWithMsg count down delete latch without forcing non-OK latch status - Remove the extra half-timeout wait after delete already reaches QUORUM_FINISHED - Add a FE unit test for delete push failure handling in MasterImpl
github-actionsBot
pushed a commit
that referenced
this pull request
Apr 8, 2026
This ports two enterprise delete fixes to upstream master: - Avoid poisoning delete latch status for non-INVALID_ARGUMENT realtime push failures - Make PushTask.failedWithMsg count down delete latch without forcing non-OK latch status - Remove the extra half-timeout wait after delete already reaches QUORUM_FINISHED - Add a FE unit test for delete push failure handling in MasterImpl
yiguolei pushed a commit
that referenced
this pull request
Apr 9, 2026
morningman pushed a commit
that referenced
this pull request
Jun 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: N/A
Problem Summary:
This ports the two enterprise delete fixes to upstream
masterin a clean branch based directly onupstream/master:INVALID_ARGUMENTrealtime push failures, so quorum success can still commitPushTask.failedWithMsgcount down delete latch without forcing non-OK latch status, to keep majority-success semantics when FE-side push submission failsQUORUM_FINISHEDMasterImplChecklist(Required)
Further comments
Attempted local test:
mvn -pl fe-core -Dtest=MasterImplDeleteTaskTest test -DfailIfNoTests=falseIt is blocked in this environment due missing snapshot dependency
org.apache.doris:fe-foundation:1.2-SNAPSHOTfrom configured Maven repositories.