Skip to content

[fix](date) fix allow_zero_date function incorrect result issue - #61900

Merged
yiguolei merged 4 commits into
apache:branch-4.0from
LuGuangming:4.0_allow_zero_date
Apr 9, 2026
Merged

[fix](date) fix allow_zero_date function incorrect result issue#61900
yiguolei merged 4 commits into
apache:branch-4.0from
LuGuangming:4.0_allow_zero_date

Conversation

@LuGuangming

@LuGuangmingLuGuangming commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close#61789

Related PR: #xxx

Problem Summary:
when set be.conf allow_zero_date=true, we found it's do not work

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LuGuangming

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.95% (19211/36284)
Line Coverage36.12% (178991/495559)
Region Coverage32.69% (138544/423758)
Branch Coverage33.70% (60257/178806)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.29% (25324/35521)
Line Coverage53.95% (266897/494676)
Region Coverage51.56% (220690/428034)
Branch Coverage53.02% (95140/179449)

@zclllyybbzclllyybb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 7, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei

Copy link
Copy Markdown
Contributor

run buildall

@zclllyybbzclllyybb mentioned this pull request Apr 7, 2026
3 tasks
@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.92% (19239/36357)
Line Coverage36.11% (179247/496413)
Region Coverage32.73% (139161/425114)
Branch Coverage33.66% (60328/179214)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.34% (25391/35591)
Line Coverage54.05% (267821/495519)
Region Coverage51.66% (221801/429387)
Branch Coverage53.07% (95445/179857)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.32% (25385/35591)
Line Coverage54.02% (267699/495519)
Region Coverage51.63% (221681/429387)
Branch Coverage53.05% (95408/179857)

@yiguolei
yiguolei merged commit 7d94c30 into apache:branch-4.0Apr 9, 2026
28 of 30 checks passed
@morningmanmorningman mentioned this pull request Jun 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.6-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@LuGuangming@hello-stephen@doris-robot@yiguolei@zclllyybb