Skip to content

branch-4.1: [fix](http) Fix jetty_server_max_http_header_size not applied in Jetty 12 (#61197) - #61904

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
liaoxin01:pick-pr-61197-to-branch-4.1
Mar 31, 2026
Merged

branch-4.1: [fix](http) Fix jetty_server_max_http_header_size not applied in Jetty 12 (#61197)#61904
yiguolei merged 1 commit into
apache:branch-4.1from
liaoxin01:pick-pr-61197-to-branch-4.1

Conversation

@liaoxin01

@liaoxin01liaoxin01 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Pick #61197

@liaoxin01wesleyliao
[fix](http) Fix jetty_server_max_http_header_size not applied in Jett…
dc07450
…y 12 (apache#61197)
HTTP 431 "Request Header Fields Too Large" error occurs when sending
requests with large headers (>8KB) to FE, even though
`jetty_server_max_http_header_size` is configured to 10MB.
This issue appears in cloud-4.1.2 (Jetty 12 + Spring Boot 3) but not in
cloud-4.0.10 (Jetty 9 + Spring Boot 2).
In Jetty 12 with Spring Boot 3, the `server.max-http-header-size`
property does not automatically apply to custom `HttpConfiguration`
objects created in `WebServerFactoryCustomizer`. The default 8KB limit
remains in effect.
Explicitly set `requestHeaderSize` on all server connectors in
`WebServerFactoryCustomizerConfig` by adding a server customizer that
configures the `HttpConfiguration` for each connector.
- Added regression test `test_large_http_header.groovy` that verifies
100KB headers are accepted
- Verified before fix: HTTP 431 error with large headers
- Verified after fix: HTTP 200 success with large headers
CopilotAI review requested due to automatic review settings March 30, 2026 14:22
@Thearas

Thearas commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

CopilotAI reviewed Mar 30, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports a fix to ensure the FE’s jetty_server_max_http_header_size configuration is actually applied when running on Jetty 12, and adds a regression test to validate large request headers are accepted.

Changes:

  • Customize the embedded Jetty server to apply Config.jetty_server_max_http_header_size to connector HTTP configurations.
  • Add an HTTP regression test that sends a ~100KB request header to /api/health and checks for absence of HTTP 431.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

FileDescription
regression-test/suites/http_p0/test_large_http_header.groovyAdds a regression test exercising large request headers against FE health endpoint.
fe/fe-core/src/main/java/org/apache/doris/httpv2/config/WebServerFactoryCustomizerConfig.javaApplies configured request header size to Jetty connector HTTP configuration(s).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadfe/fe-core/src/main/java/org/apache/doris/httpv2/config/WebServerFactoryCustomizerConfig.java
Comment threadregression-test/suites/http_p0/test_large_http_header.groovy
Comment threadregression-test/suites/http_p0/test_large_http_header.groovy
@liaoxin01

liaoxin01 commented Mar 30, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@yiguolei
yiguolei merged commit 99a82e8 into apache:branch-4.1Mar 31, 2026
31 of 35 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liaoxin01@Thearas@hello-stephen@yiguolei