[fix](fe) Fix null pointer exception in sessionVariables after upgrade by feiniaofeiafei · Pull Request #61959 · apache/doris

feiniaofeiafei · 2026-03-31T12:05:52Z

What problem does this PR solve?

After upgrading from 4.0.2 to 4.0.4+, executing SHOW CREATE MATERIALIZED VIEW throws a NullPointerException. The root cause is that the sessionVariables field was newly added in MTMV.java after 4.0.2. In 4.0.2, materialized views did not persist this field, so after upgrade, the deserialized sessionVariables is null. However, ShowCreateMTMVInfo.java:93 directly calls mtmv.getSessionVariables().toString() without null pointer protection, causing NPE.

Solution

Modified gsonPostProcess() method in 5 classes to initialize sessionVariables to empty HashMap during deserialization:

MTMV.java - Added null check for sessionVariables
View.java - Added null check for sessionVariables
AliasFunction.java - Implemented GsonPostProcessable and added null check
Column.java - Added null check for sessionVariables
MaterializedIndexMeta.java - Added null check for sessionVariables

Release note

Fixed NullPointerException when executing SHOW CREATE MATERIALIZED VIEW after upgrading from version 4.0.2 to 4.0.4+.

Test

Unit tests added (SessionVariablesNullFixTest) with comprehensive coverage
All existing tests pass
FE build successful

Thearas · 2026-03-31T12:05:58Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

…e from 4.0.2 After upgrading from 4.0.2 to 4.0.4+, executing SHOW CREATE MATERIALIZED VIEW throws a NullPointerException. The root cause is that the sessionVariables field was newly added in MTMV.java after 4.0.2. In 4.0.2, materialized views did not persist this field, so after upgrade, the deserialized sessionVariables is null. However, ShowCreateMTMVInfo.java:93 directly calls mtmv.getSessionVariables().toString() without null pointer protection, causing NPE. Fixed NullPointerException when executing SHOW CREATE MATERIALIZED VIEW after upgrading from version 4.0.2 to 4.0.4+. - Test: Unit tests added and passed - Added SessionVariablesNullFixTest with comprehensive test cases - Test cases verify null sessionVariables initialization in gsonPostProcess - All tests pass in FE build - Behavior changed: No (internal fix only) - Does this need documentation: No Modified classes to initialize sessionVariables to empty HashMap in gsonPostProcess method: 1. MTMV.java - Already implemented GsonPostProcessable, added null check 2. View.java - Already implemented GsonPostProcessable, added null check 3. AliasFunction.java - Added GsonPostProcessable implementation 4. Column.java - Already implemented GsonPostProcessable, added null check 5. MaterializedIndexMeta.java - Already implemented GsonPostProcessable, added null check This prevents NPE when calling toString() on null sessionVariables during deserialization of objects created with 4.0.2 or earlier versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feiniaofeiafei · 2026-03-31T12:11:49Z

run buildall

doris-robot · 2026-03-31T12:27:42Z

TPC-H: Total hot run time: 26499 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c857b431ebed88c407bea78206d3b2838c9dd9e1, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	16837	4583	4317	4317
q2	q3	10310	770	516	516
q4	4606	369	253	253
q5	7570	1201	1028	1028
q6	179	174	146	146
q7	787	865	685	685
q8	9321	1477	1350	1350
q9	4917	4739	4735	4735
q10	6238	1918	1636	1636
q11	486	248	241	241
q12	702	598	473	473
q13	18022	2737	1929	1929
q14	230	245	210	210
q15	q16	718	719	663	663
q17	725	851	439	439
q18	5925	5360	5279	5279
q19	1112	986	598	598
q20	532	491	374	374
q21	4499	1829	1383	1383
q22	347	295	244	244
Total cold run time: 94063 ms
Total hot run time: 26499 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4910	4723	4554	4554
q2	q3	3895	4364	3865	3865
q4	894	1198	765	765
q5	4110	4430	4335	4335
q6	189	175	142	142
q7	1819	1639	1510	1510
q8	2519	2720	2629	2629
q9	7694	7333	7491	7333
q10	3864	3996	3537	3537
q11	496	432	409	409
q12	491	583	435	435
q13	2507	2910	2079	2079
q14	284	302	286	286
q15	q16	735	744	707	707
q17	1140	1389	1386	1386
q18	7199	6792	6712	6712
q19	896	924	956	924
q20	2125	2137	2020	2020
q21	3912	3451	3344	3344
q22	497	428	495	428
Total cold run time: 50176 ms
Total hot run time: 47400 ms

doris-robot · 2026-03-31T12:38:38Z

TPC-DS: Total hot run time: 169039 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c857b431ebed88c407bea78206d3b2838c9dd9e1, data reload: false
query5	4343	652	522	522
query6	323	226	200	200
query7	4210	468	268	268
query8	330	245	229	229
query9	8722	2694	2725	2694
query10	571	395	336	336
query11	7032	5119	4853	4853
query12	179	125	125	125
query13	1270	447	355	355
query14	5742	3641	3498	3498
query14_1	2819	2796	2817	2796
query15	203	192	169	169
query16	968	482	441	441
query17	881	700	612	612
query18	2450	449	352	352
query19	218	212	185	185
query20	127	139	129	129
query21	215	141	114	114
query22	13219	15109	14687	14687
query23	16772	16278	15836	15836
query23_1	15632	15615	15603	15603
query24	7122	1627	1237	1237
query24_1	1228	1232	1246	1232
query25	564	499	443	443
query26	1249	267	153	153
query27	2772	496	296	296
query28	4383	1851	1844	1844
query29	849	587	489	489
query30	303	229	194	194
query31	1021	950	881	881
query32	85	71	71	71
query33	540	358	296	296
query34	883	862	514	514
query35	651	697	604	604
query36	1126	1143	1016	1016
query37	141	93	89	89
query38	3021	2884	2852	2852
query39	868	846	822	822
query39_1	803	801	808	801
query40	290	150	132	132
query41	61	59	58	58
query42	259	254	252	252
query43	242	243	213	213
query44 query45	196	192	180	180
query46	882	967	594	594
query47	2200	2191	2076	2076
query48	309	317	232	232
query49	632	457	388	388
query50	686	277	214	214
query51	4141	4057	3995	3995
query52	263	268	253	253
query53	307	338	287	287
query54	304	273	256	256
query55	90	92	84	84
query56	308	316	312	312
query57	1927	1621	1808	1621
query58	277	272	263	263
query59	2826	2939	2746	2746
query60	338	333	326	326
query61	152	156	151	151
query62	636	607	550	550
query63	302	288	274	274
query64	4851	1334	1012	1012
query65 query66	1461	470	352	352
query67	24309	24315	24237	24237
query68 query69	400	320	290	290
query70	1016	970	976	970
query71	331	305	290	290
query72	2784	2623	2420	2420
query73	532	535	314	314
query74	9702	9553	9373	9373
query75	2874	2745	2465	2465
query76	2122	1025	678	678
query77	349	430	302	302
query78	10928	11247	10440	10440
query79	1126	770	565	565
query80	1343	617	553	553
query81	551	271	218	218
query82	973	156	124	124
query83	340	274	253	253
query84	303	121	108	108
query85	919	523	449	449
query86	440	310	302	302
query87	3114	3122	2984	2984
query88	3541	2630	2614	2614
query89	420	370	347	347
query90	2024	183	176	176
query91	171	164	135	135
query92	81	78	75	75
query93	926	831	493	493
query94	633	331	291	291
query95	587	341	319	319
query96	653	507	231	231
query97	2456	2487	2376	2376
query98	233	223	216	216
query99	1021	995	913	913
Total cold run time: 249376 ms
Total hot run time: 169039 ms

hello-stephen · 2026-03-31T13:25:20Z

FE UT Coverage Report

Increment line coverage 81.82% (9/11) 🎉
Increment coverage report
Complete coverage report

feiniaofeiafei · 2026-04-01T02:05:17Z

run cloud_p0

feiniaofeiafei · 2026-04-01T02:05:27Z

run nonConcurrent

feiniaofeiafei · 2026-04-02T02:23:59Z

run cloud_p0

feiniaofeiafei · 2026-04-02T03:06:23Z

run cloud_p0

github-actions · 2026-04-02T04:17:35Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-04-02T04:17:38Z

PR approved by anyone and no changes requested.

seawinde

LGTM

feiniaofeiafei · 2026-04-02T09:09:14Z

run cloud_p0

apache#61959) ## What problem does this PR solve? After upgrading from 4.0.2 to 4.0.4+, executing SHOW CREATE MATERIALIZED VIEW throws a NullPointerException. The root cause is that the sessionVariables field was newly added in MTMV.java after 4.0.2. In 4.0.2, materialized views did not persist this field, so after upgrade, the deserialized sessionVariables is null. However, ShowCreateMTMVInfo.java:93 directly calls mtmv.getSessionVariables().toString() without null pointer protection, causing NPE. ## Solution Modified gsonPostProcess() method in 5 classes to initialize sessionVariables to empty HashMap during deserialization: - MTMV.java - Added null check for sessionVariables - View.java - Added null check for sessionVariables - AliasFunction.java - Implemented GsonPostProcessable and added null check - Column.java - Added null check for sessionVariables - MaterializedIndexMeta.java - Added null check for sessionVariables ## Release note Fixed NullPointerException when executing SHOW CREATE MATERIALIZED VIEW after upgrading from version 4.0.2 to 4.0.4+. ## Test - Unit tests added (SessionVariablesNullFixTest) with comprehensive coverage - All existing tests pass - FE build successful Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

apache#61959) After upgrading from 4.0.2 to 4.0.4+, executing SHOW CREATE MATERIALIZED VIEW throws a NullPointerException. The root cause is that the sessionVariables field was newly added in MTMV.java after 4.0.2. In 4.0.2, materialized views did not persist this field, so after upgrade, the deserialized sessionVariables is null. However, ShowCreateMTMVInfo.java:93 directly calls mtmv.getSessionVariables().toString() without null pointer protection, causing NPE. Modified gsonPostProcess() method in 5 classes to initialize sessionVariables to empty HashMap during deserialization: - MTMV.java - Added null check for sessionVariables - View.java - Added null check for sessionVariables - AliasFunction.java - Implemented GsonPostProcessable and added null check - Column.java - Added null check for sessionVariables - MaterializedIndexMeta.java - Added null check for sessionVariables Fixed NullPointerException when executing SHOW CREATE MATERIALIZED VIEW after upgrading from version 4.0.2 to 4.0.4+. - Unit tests added (SessionVariablesNullFixTest) with comprehensive coverage - All existing tests pass - FE build successful Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…fter upgrade #61959 (#62897) picked from #61959 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…fter upgrade #61959 (#62896) picked from #61959 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feiniaofeiafei force-pushed the fix_nullptr branch from 066c571 to c857b43Compare March 31, 2026 12:11

feiniaofeiafei changed the title ~~[fix](fe) Fix null pointer exception in sessionVariables after upgrade from 4.0.2~~[fix](fe) Fix null pointer exception in sessionVariables after upgradeApr 2, 2026

morrySnow added dev/4.0.x dev/4.1.x labels Apr 2, 2026

morrySnow approved these changes Apr 2, 2026
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 2, 2026

seawinde approved these changes Apr 2, 2026
View reviewed changes

morrySnow closed this Apr 7, 2026

morrySnow reopened this Apr 7, 2026

morrySnow merged commit 4ad3989 into apache:masterApr 7, 2026
48 of 49 checks passed

github-actionsBot added dev/4.0.x-conflict dev/4.1.x-conflict labels Apr 7, 2026

mymeiyi mentioned this pull request Apr 21, 2026
[fix](wal) Fix WAL replay loading 0 rows due to columns being marked as missing #62658
Merged

feiniaofeiafei mentioned this pull request Apr 28, 2026
branch-4.0:[fix](fe) Fix null pointer exception in sessionVariables after upgrade #61959 #62896
Merged

feiniaofeiafei mentioned this pull request Apr 28, 2026
branch-4.1:[fix](fe) Fix null pointer exception in sessionVariables after upgrade #61959 #62897
Merged

yiguolei pushed a commit that referenced this pull request Apr 29, 2026
branch-4.1:[fix](fe) Fix null pointer exception in sessionVariables a…
e745a8d
…fter upgrade #61959 (#62897) picked from #61959 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

yiguolei added dev/4.1.1-merged and removed dev/4.1.x dev/4.1.x-conflict labels Apr 29, 2026

yiguolei added dev/4.0.6-merged and removed dev/4.0.x dev/4.0.x-conflict labels May 7, 2026

yiguolei pushed a commit that referenced this pull request May 7, 2026
branch-4.0:[fix](fe) Fix null pointer exception in sessionVariables a…
9b1a764
…fter upgrade #61959 (#62896) picked from #61959 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

yiguolei mentioned this pull request May 20, 2026
4.1.1 Release Notes #63426
Closed

morningman mentioned this pull request Jun 3, 2026
4.0.6 Release Notes #64065
Closed

Uh oh!

Conversation

feiniaofeiafei commented Mar 31, 2026

What problem does this PR solve?

Solution

Release note

Test

Uh oh!

Thearas commented Mar 31, 2026

Uh oh!

feiniaofeiafei commented Mar 31, 2026

Uh oh!

doris-robot commented Mar 31, 2026

Uh oh!

doris-robot commented Mar 31, 2026

Uh oh!

hello-stephen commented Mar 31, 2026

FE UT Coverage Report

Uh oh!

feiniaofeiafei commented Apr 1, 2026

Uh oh!

feiniaofeiafei commented Apr 1, 2026

Uh oh!

feiniaofeiafei commented Apr 2, 2026

Uh oh!

feiniaofeiafei commented Apr 2, 2026

Uh oh!

github-actionsBot commented Apr 2, 2026

Uh oh!

github-actionsBot commented Apr 2, 2026

Uh oh!

seawinde left a comment

Choose a reason for hiding this comment

Uh oh!

feiniaofeiafei commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants