Skip to content

[fix](cloud) Fix balanced_tablets_shards memory leak and warmup inflight count (#59093) (#60480) - #61985

Merged
yiguolei merged 2 commits into
apache:branch-4.0from
deardeng:pick-60480-40
Apr 22, 2026
Merged

[fix](cloud) Fix balanced_tablets_shards memory leak and warmup inflight count (#59093) (#60480)#61985
yiguolei merged 2 commits into
apache:branch-4.0from
deardeng:pick-60480-40

Conversation

@deardeng

@deardengdeardeng commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

This commit merges two bug fixes related to cloud components:

  1. Fix balanced_tablets_shards leak memory and fix some file cache cases ([fix](cloud) Fix balanced_tablets_shards leak memory and fix some file cache case #59093).
  2. Fix warmup inflight count not decremented on early return ([fix](cloud) Fix warmup inflight count not decremented on early return #60480).

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@deardeng
deardeng requested a review from yiguolei as a code ownerApril 1, 2026 04:09
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 27.27% (15/55) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage52.96% (19257/36361)
Line Coverage36.16% (179474/496372)
Region Coverage32.77% (139313/425095)
Branch Coverage33.68% (60350/179184)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 27.27% (15/55) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage69.94% (24895/35595)
Line Coverage52.52% (260244/495478)
Region Coverage50.26% (215782/429367)
Branch Coverage51.42% (92469/179827)

@deardeng

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 27.27% (15/55) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage69.94% (24895/35595)
Line Coverage52.52% (260244/495478)
Region Coverage50.26% (215782/429367)
Branch Coverage51.42% (92469/179827)

…ght count (apache#59093) (apache#60480)
This commit merges two bug fixes related to cloud components:
1. Fix balanced_tablets_shards leak memory and fix some file cache cases (apache#59093).
2. Fix warmup inflight count not decremented on early return (apache#60480).
@deardeng

Copy link
Copy Markdown
ContributorAuthor

run buildall

@deardeng

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 30.61% (15/49) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.05% (19286/36354)
Line Coverage36.25% (179926/496406)
Region Coverage32.81% (139458/425107)
Branch Coverage33.74% (60476/179223)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 30.61% (15/49) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage69.77% (24828/35588)
Line Coverage52.39% (259591/495520)
Region Coverage49.80% (213853/429382)
Branch Coverage51.15% (91989/179854)

@yiguoleiyiguolei reopened this Apr 22, 2026
@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 57c6c3b into apache:branch-4.0Apr 22, 2026
45 of 48 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@deardeng@hello-stephen@yiguolei