Skip to content

[fix](audit) Fix UnboundAlias digest when name comes from child - #62160

Merged
starocean999 merged 1 commit into
apache:masterfrom
HonestManXin:fix_digest
Apr 7, 2026
Merged

[fix](audit) Fix UnboundAlias digest when name comes from child#62160
starocean999 merged 1 commit into
apache:masterfrom
HonestManXin:fix_digest

Conversation

@HonestManXin

@HonestManXinHonestManXin commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Previously, the digest generated by select sum(a) +1 from tablewas select SUM(a)+? AS sum(a)+1 from table, which would result in generating too many digest hash

@hello-stephen

hello-stephen commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow

morrySnow commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

/review

@morrySnow

morrySnow commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

github-actionsBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 7, 2026
@github-actions

github-actionsBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

No issues found in this review. The change correctly limits digest alias emission to explicit aliases, and the updated parser digest tests cover the affected cases. FE unit test execution could not be completed in this runner because thirdparty/installed/bin/protoc is missing.

@hello-stephen

hello-stephen commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@starocean999
starocean999 merged commit 6365495 into apache:masterApr 7, 2026
32 of 34 checks passed
github-actionsBot pushed a commit that referenced this pull request Apr 7, 2026
@HonestManXinYour Name
[fix](audit) Fix UnboundAlias digest when name comes from child (#62160)
b5af7dc
Previously, the digest generated by `select sum(a) +1 from table`was
`select SUM(a)+? AS sum(a)+1 from table`, which would result in
generating too many digest hash
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2026
Merged
github-actionsBot pushed a commit that referenced this pull request Apr 7, 2026
@HonestManXinYour Name
[fix](audit) Fix UnboundAlias digest when name comes from child (#62160)
5c438e0
Previously, the digest generated by `select sum(a) +1 from table`was
`select SUM(a)+? AS sum(a)+1 from table`, which would result in
generating too many digest hash
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2026
Merged
yiguolei pushed a commit that referenced this pull request Apr 8, 2026
@github-actions@HonestManXin
branch-4.1: [fix](audit) Fix UnboundAlias digest when name comes from…
702bbdc
… child #62160 (#62175)
Cherry-picked from #62160
Co-authored-by: HonestManXin <HonestManXin@gmail.com>
yiguolei pushed a commit that referenced this pull request Apr 15, 2026
@github-actions@HonestManXin
branch-4.0: [fix](audit) Fix UnboundAlias digest when name comes from…
29edf65
… child #62160 (#62174)
Cherry-picked from #62160
Co-authored-by: HonestManXin <HonestManXin@gmail.com>
@mymeiyimymeiyi mentioned this pull request Apr 21, 2026
Merged
@morningmanmorningman mentioned this pull request Jun 3, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999starocean999starocean999 approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.6-mergeddev/4.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HonestManXin@hello-stephen@morrySnow@starocean999@yiguolei