Skip to content

branch-4.1: [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo #62082 - #62163

Closed
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-62082-branch-4.1
Closed

branch-4.1: [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo #62082#62163
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-62082-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #62082

…r scheduleInfo (#62082)
### What problem does this PR solve?
When a MySQL client (e.g., DataWorks/SKYNET) connects to a **follower
FE**, the `scheduleInfo` connection attribute is lost in the lineage
`queryText` output.
In HA mode, DML statements are forwarded from follower FE to master FE
via thrift RPC. The `TMasterOpRequest` had no field for
`connect_attributes`, causing them to be silently dropped. The master FE
creates an empty `ConnectContext`, so
`LineageUtils.buildLineageContext()` produces `queryText` without the
`/* scheduleInfo={...} */` prefix.
### Fix
1. **Thrift**: Add `connect_attributes` (field 33) to `TMasterOpRequest`
2. **FEOpExecutor**: Serialize `connectAttributes` into forward params
(inherited by `MasterOpExecutor`)
3. **ConnectProcessor**: Restore `connectAttributes` in `proxyExecute()`
on master FE
@github-actions
github-actionsBot requested a review from yiguolei as a code ownerApril 7, 2026 08:21
@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.47% (1797/2290)
Line Coverage64.15% (32266/50299)
Region Coverage65.00% (16167/24871)
Branch Coverage55.51% (8620/15530)

@yiguoleiyiguolei closed this Apr 8, 2026
@morrySnow
morrySnow deleted the auto-pick-62082-branch-4.1 branch August 31, 2026 07:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas@hello-stephen@yiguolei@dataroaring@seawinde