[refactor](be) Remove io_helper helper indirection from BE cast paths by zclllyybb · Pull Request #62179 · apache/doris

zclllyybb · 2026-04-07T13:56:51Z

Problem Summary: Remove the legacy io_helper wrapper layer and move its parsing and formatting entry points onto the existing cast implementations so serde and conversion code depends on the real owners of that behavior.

hello-stephen · 2026-04-07T13:56:57Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb · 2026-04-07T13:57:06Z

run buildall

hello-stephen · 2026-04-07T17:03:42Z

BE UT Coverage Report

Increment line coverage 85.29% (116/136) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.99% (20101/37937)
Line Coverage	36.53% (188919/517160)
Region Coverage	32.77% (146508/447075)
Branch Coverage	33.93% (64207/189229)

hello-stephen · 2026-04-07T17:15:26Z

BE Regression && UT Coverage Report

Increment line coverage 86.96% (140/161) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.82% (26681/37149)
Line Coverage	54.76% (282318/515555)
Region Coverage	51.81% (233773/451199)
Branch Coverage	53.24% (101049/189805)

zclllyybb · 2026-04-08T14:41:47Z

run buildall

zclllyybb · 2026-04-08T14:46:18Z

/review

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR removes the legacy util/io_helper wrapper layer and routes parsing/formatting through the corresponding cast implementations so serialization/conversion code depends on the real owners of that behavior.

Changes:

Deleted be/src/util/io_helper.h/.cpp and replaced helper call sites with CastTo* entry points.
Centralized numeric parsing helpers into cast_to_basic_number_common.h and decimal text parsing into CastToDecimal.
Updated tests and conversion/serde code paths to use CastToString::from_int128 and CastTo*::from_string*_mode(...).

Reviewed changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
be/test/exec/column_type_convert_test.cpp	Updates tests to use cast-owned parsing/formatting APIs.
be/test/core/field_test.cpp	Switches test dependency from `io_helper` to `cast_to_string`.
be/test/common/check_overflow.cpp	Replaces `io_helper` include with numeric cast parsing header.
be/src/util/io_helper.h	Removes legacy helper declarations (deleted file).
be/src/util/io_helper.cpp	Removes legacy helper implementations (deleted file).
be/src/util/counts.h	Drops `io_helper` include after refactor.
be/src/storage/olap_scan_common.h	Drops `io_helper` include after refactor.
be/src/format/column_type_convert.h	Replaces helper calls with `CastTo*` parsing/formatting implementations.
be/src/exprs/function/function_json.cpp	Drops `io_helper` include after refactor.
be/src/exprs/function/cast/cast_to_timestamptz.h	Drops `io_helper` include after refactor.
be/src/exprs/function/cast/cast_to_string.h	Adds `from_int128` entry points and updates `Int128` string conversion.
be/src/exprs/function/cast/cast_to_jsonb.h	Drops `io_helper` include after refactor.
be/src/exprs/function/cast/cast_to_decimal.h	Moves decimal text parsing helper into `CastToDecimal`.
be/src/exprs/function/cast/cast_to_boolean.h	Inlines boolean parsing via `StringParser` instead of `io_helper`.
be/src/exprs/function/cast/cast_to_basic_number_common.h	Moves numeric text parsing helpers from `io_helper` into cast common header.
be/src/exprs/function/cast/cast_base.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/moments.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_uniq.h	Drops `io_helper` include and adjusts includes.
be/src/exprs/aggregate/aggregate_function_topn.h	Drops `io_helper` include and adjusts includes.
be/src/exprs/aggregate/aggregate_function_sequence_match.h	Replaces `io_helper` include with numeric cast parsing header.
be/src/exprs/aggregate/aggregate_function_rpc.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_product.h	Fixes logging for `int128_t` product by using cast-owned formatting.
be/src/exprs/aggregate/aggregate_function_min_max.h	Drops `io_helper` include and adjusts includes.
be/src/exprs/aggregate/aggregate_function_java_udaf.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_histogram.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_corr.h	Drops `io_helper` include and adds required standard/core includes.
be/src/exprs/aggregate/aggregate_function_collect.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_bit.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_avg_weighted.h	Drops `io_helper` include after refactor.
be/src/exprs/aggregate/aggregate_function_array_agg.h	Drops `io_helper` include after refactor.
be/src/exec/common/histogram_helpers.hpp	Drops `io_helper` include after refactor.
be/src/exec/common/hash_table/hash_table.h	Drops `io_helper` include after refactor.
be/src/core/field.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type_serde/data_type_number_serde.cpp	Uses cast-owned parsing/formatting instead of helper functions.
be/src/core/data_type_serde/data_type_ipv6_serde.cpp	Uses `CastToIPv6` parsing instead of `io_helper` helpers.
be/src/core/data_type_serde/data_type_ipv4_serde.cpp	Uses `CastToIPv4` parsing instead of `io_helper` helpers.
be/src/core/data_type_serde/data_type_decimal_serde.cpp	Uses `CastToDecimal::read_text` instead of helper parsing.
be/src/core/data_type_serde/data_type_datev2_serde.cpp	Uses `CastToDateV2` parsing instead of helper parsing.
be/src/core/data_type_serde/data_type_datetimev2_serde.cpp	Uses `CastToDatetimeV2` parsing instead of helper parsing.
be/src/core/data_type_serde/data_type_date_or_datetime_serde.cpp	Uses `CastToDateOrDatetime` parsing directly and normalizes types post-parse.
be/src/core/data_type/data_type_quantilestate.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_number_base.cpp	Uses `CastToString::from_int128` for 128-bit formatting.
be/src/core/data_type/data_type_ipv6.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_ipv4.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_hll.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_decimal.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_date_time.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_date_or_datetime_v2.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_date.cpp	Drops `io_helper` include after refactor.
be/src/core/data_type/data_type_bitmap.cpp	Drops `io_helper` include after refactor.

Comments suppressed due to low confidence (3)

be/src/format/column_type_convert.h:1

CastParameters params; is default-initialized here. If CastParameters contains fundamental fields (e.g. bool is_strict) without default member initializers, this can leave them uninitialized and cause nondeterministic parsing behavior. Prefer explicit initialization (e.g. CastParameters params{}; plus setting required fields, or use the same designated initialization pattern used elsewhere such as .status = Status::OK(), .is_strict = false).
be/src/exprs/function/cast/cast_to_basic_number_common.h:1
The static_assert message refers to readFloatTextImpl, which doesn’t match the new function name (try_read_float_text). Updating the message to the current API name will make future failures clearer and reduce confusion during refactors.
be/src/exprs/function/cast/cast_to_string.h:1
This switches 128-bit formatting from FMT_COMPILE(\"{}\") (previously used by int128_to_string) to a runtime format string. For hot formatting paths, consider using FMT_COMPILE with fmt::format_to (or an equivalent compiled-format approach) to avoid repeated runtime parsing of the format string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-08T15:02:51Z

No issues found in this refactor after reviewing the full BE cast/serde call chain.

Critical checkpoints:

Goal and correctness: Yes. The change removes io_helper indirection and replaces it with equivalent direct cast/parser helpers. The modified paths still normalize DATE/DATETIME values where required, and no behavior regression was identified in the touched call sites.
Scope/minimality: Yes. The functional changes are tightly scoped to parser/stringification helper relocation plus include cleanup.
Concurrency: Not applicable. The touched code is stateless parsing/serialization helpers with no new shared mutable state or lock interaction.
Lifecycle/static init: No issue. No new static/global lifecycle hazards were introduced.
Config/compatibility: Not applicable. No config, protocol, symbol-contract, or storage-format compatibility issue was introduced by this patch.
Parallel paths: Checked. Equivalent helper replacements were applied consistently across the touched cast, serde, field, and conversion paths.
Conditional checks: No problematic new special-case checks found.
Test coverage: Adequate for this refactor level. Existing touched BE unit tests cover relevant conversion paths; no obvious missing mandatory test was identified for this behavior-preserving change.
Observability: Not needed for this refactor.
Transaction/persistence/data-write concerns: Not applicable.
FE/BE variable passing: Not applicable.
Performance: Acceptable. The refactor removes an indirection layer without adding obvious extra work.
Other issues: None found.

Residual risk: compile-only fallout from transitive include changes is still possible, but I did not find orphaned references to the deleted helper in the repository.

hello-stephen · 2026-04-08T18:26:46Z

BE Regression && UT Coverage Report

Increment line coverage 76.00% (133/175) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.55% (27336/37168)
Line Coverage	57.18% (295051/515966)
Region Coverage	54.30% (245286/451734)
Branch Coverage	56.02% (106446/190000)

zclllyybb · 2026-04-09T04:41:02Z

/review

github-actions

Found 1 issue.

Goal of the task: remove the legacy io_helper wrapper and route parsing/formatting through the real cast owners. The refactor mostly does that, but it does not fully preserve behavior because TYPE_TIME input parsing is now broken in the generic number serde path.
Modification size/focus: mostly small and focused, but the new explicit DataTypeNumberSerDe<TYPE_TIME> instantiation unintentionally expands the affected surface beyond a pure wrapper removal.
Concurrency: no concurrency-sensitive changes were involved.
Lifecycle/static initialization: no special lifecycle or static initialization issues found.
Configuration: no config changes.
Compatibility/incompatible changes: no storage-format change was introduced, but there is a behavioral regression for deprecated TYPE_TIME text input paths.
Parallel code paths: the wrapper removal was applied across most cast/serde/convert paths, but the parallel TYPE_TIME parse path in try_parse_impl() was left incomplete.
Special conditional checks: no problematic new conditional checks beyond the missing TYPE_TIME branch.
Test coverage: the added serde/converter tests are useful, but there is still no coverage for TYPE_TIME generic-serde text parsing (from_string/from_fe_string/batch variants), which is why this regression slipped through.
Observability: no additional observability is needed for this refactor.
Transaction/persistence: not applicable.
Data write/atomicity: not applicable.
FE-BE variable passing: not applicable.
Performance: neutral overall; no clear performance regression found in the reviewed paths.
Other issues: none beyond the regression below.

Critical checkpoints conclusion: the PR does not fully accomplish its goal yet because one reachable input path regresses.

zclllyybb · 2026-04-09T04:53:13Z

run buildall

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (6)

be/test/exec/column_type_convert_test.cpp:1

reinterpret_cast<ColumnPtr&>(src_col) is undefined-behavior prone and can easily break if the smart-pointer types/layouts differ. Prefer creating a real ColumnPtr variable (e.g., ColumnPtr src = src_col;) and passing that to convert, or adjust convert to accept the concrete pointer type used by the tests.
be/test/exec/column_type_convert_test.cpp:1
reinterpret_cast<ColumnPtr&>(src_col) is undefined-behavior prone and can easily break if the smart-pointer types/layouts differ. Prefer creating a real ColumnPtr variable (e.g., ColumnPtr src = src_col;) and passing that to convert, or adjust convert to accept the concrete pointer type used by the tests.
be/test/exec/column_type_convert_test.cpp:1
reinterpret_cast<ColumnPtr&>(src_col) is undefined-behavior prone and can easily break if the smart-pointer types/layouts differ. Prefer creating a real ColumnPtr variable (e.g., ColumnPtr src = src_col;) and passing that to convert, or adjust convert to accept the concrete pointer type used by the tests.
be/test/exec/column_type_convert_test.cpp:1
reinterpret_cast<ColumnPtr&>(src_col) is undefined-behavior prone and can easily break if the smart-pointer types/layouts differ. Prefer creating a real ColumnPtr variable (e.g., ColumnPtr src = src_col;) and passing that to convert, or adjust convert to accept the concrete pointer type used by the tests.
be/src/format/column_type_convert.h:1
This header now directly includes several *_impl.hpp files. If column_type_convert.h is widely included, this can significantly increase compile times and may also increase the risk of ODR/link issues if any of those impl headers contain non-inline definitions. If feasible, keep column_type_convert.h depending on stable interface headers only and move impl-heavy dependencies behind a .cpp boundary (or introduce a smaller adapter header with forward declarations/inline-only glue).
be/src/exprs/function/cast/cast_to_string.h:1
For a hot formatting path like int128→string, using a compile-time format string (e.g., FMT_COMPILE(\"{}\")) can reduce formatting overhead in fmt. This is optional, but worth considering if from_int128 is used frequently in tight loops.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hello-stephen · 2026-04-09T08:02:00Z

BE UT Coverage Report

Increment line coverage 93.66% (133/142) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.01% (20122/37957)
Line Coverage	36.55% (189191/517629)
Region Coverage	32.82% (146915/447680)
Branch Coverage	33.92% (64271/189486)

hello-stephen · 2026-04-09T08:16:40Z

BE Regression && UT Coverage Report

Increment line coverage 93.48% (129/138) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.69% (27387/37167)
Line Coverage	57.27% (295515/516013)
Region Coverage	54.39% (245750/451799)
Branch Coverage	56.10% (106632/190060)

zclllyybb · 2026-04-09T17:23:16Z

/review

github-actions

I found 1 issue in the current head.

Critical checkpoints

Goal and correctness: Partially. The refactor does remove the io_helper indirection, but TYPE_TIME text parsing is now regressed on the generic number serde path, so the current code is not behavior-preserving for all touched owners.
Scope/minimality: Yes. The change set stays focused on helper removal and owner API consolidation.
Concurrency: Not applicable. I did not find new shared-state or lock interactions in the touched code.
Lifecycle/static init: No issue found. No new static/global lifetime hazards were introduced.
Config changes: Not applicable.
Incompatible changes: No storage/protocol format change found, but there is a behavioral incompatibility on TYPE_TIME string parsing.
Parallel paths: Mostly checked. The main remaining gap is that the generic serde/text path was updated without preserving the old TYPE_TIME handling.
Special conditional checks: No problematic new conditionals beyond the bug below.
Test coverage: Improved, but still missing coverage for DataTypeNumberSerDe<TYPE_TIME>::from_string()/from_olap_string(); that is why this regression survived.
Observability: Not needed for this refactor.
Transaction/persistence/data-write concerns: Not applicable.
FE/BE variable passing: Not applicable.
Performance: Acceptable overall; no blocking performance issue found.
Other issues: None beyond the finding below.

Finding

be/src/core/data_type_serde/data_type_number_serde.cpp:728: try_parse_impl() still only supports float/double, bool, and integer primitive types, but this file now explicitly instantiates DataTypeNumberSerDe<TYPE_TIME> at the bottom. That makes from_string() and from_olap_string() for deprecated TIME columns go through try_parse_impl<TYPE_TIME, ...>(), which now throws NOT_IMPLEMENTED_ERROR instead of parsing the value. This is a real behavior regression for text-input paths that rely on the generic serde owner, including default values / schema-change style flows that call these APIs. Please either keep TYPE_TIME out of the generic DataTypeNumberSerDe text-parsing expansion, or add a PT == TYPE_TIME branch that parses with the same float-like path used elsewhere in this file.

Copilot

Pull request overview

Copilot reviewed 58 out of 58 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T17:30:54Z

+ StringParser::ParseResult result;
+ duration =
+ StringParser::string_to_int<NativeType, false>(pos, end - pos, &result);
+ while (pos < end && *pos >= '0' && *pos <= '9') {
+ ++pos;
+ }


StringParser::string_to_int is called with end - pos (the rest of the pattern), but then pos is advanced only over the leading digits. This can cause parsing to fail when the number is immediately followed by non-digit characters (e.g. ")"), leaving duration as an unspecified/incorrect value while pos != prev_pos so no error is reported. Parse using the digit-only slice ([prev_pos, digit_end)) and check the parse result (or at least silence the unused result variable).

Copilot · 2026-04-09T17:30:54Z

+ StringParser::ParseResult result;
+ event_number =
+ StringParser::string_to_int<UInt64, false>(pos, end - pos, &result);
+ while (pos < end && *pos >= '0' && *pos <= '9') {
+ ++pos;
+ }


Same issue as the duration parsing above: string_to_int uses end - pos (including trailing pattern chars), but pos is later advanced only over digits. This can make event_number parse fail while still consuming digits, producing an incorrect event_number without triggering the pos == prev_pos check. Parse using the digit-only substring and check (or explicitly ignore) the parse result.

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Add focused sequence_match unit coverage for time-condition parsing and malformed numeric tokens, and make parser failures clear parser state so malformed patterns fail closed instead of leaving partial matches behind. ### Release note None ### Check List (For Author) - Test: BE Unit Test - ./run-be-ut.sh --run --filter='*FunctionCastToFloatTest.test_from_decimal*:*FunctionCastToFloatTest.test_decimalv2_keeps_scale_when_cast_to_float_and_double*:*FunctionCastToIntTest.test_from_decimal*:*FunctionCastToDecimalTest*:*ColumnTypeConvertTest*:*CastToStringTest*:*VSequenceMatchTest*' -j60 - Behavior changed: No - Does this need documentation: No

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Restore CastToDecimal as the owner-facing decimal-to-decimal API so external callers do not encode decimal storage families, and route decimal-to-int/float cast loops back through the stable public wrappers instead of underscored helpers. ### Release note None ### Check List (For Author) - Test: BE Unit Test - ./run-be-ut.sh --run --filter='*FunctionCastToFloatTest.test_from_decimal*:*FunctionCastToFloatTest.test_decimalv2_keeps_scale_when_cast_to_float_and_double*:*FunctionCastToIntTest.test_from_decimal*:*FunctionCastToDecimalTest*:*ColumnTypeConvertTest*:*CastToStringTest*:*VSequenceMatchTest*' -j60 - Behavior changed: No - Does this need documentation: No

zclllyybb · 2026-04-15T07:17:27Z

/review

zclllyybb · 2026-04-15T07:17:31Z

run buildall

github-actions

Overall: Request changes. The refactor itself looks mostly behavior-preserving in the reviewed live paths, but the newly added Arrow string coverage is not checking the actual internal representation it claims to validate.

Critical checkpoints:

Goal of task: Remove io_helper indirection and route parsing/formatting to cast owners. Mostly achieved. The new coverage intended to prove Arrow STRING -> date-like parsing is currently incorrect, so the goal is not fully demonstrated by tests.
Small/clear/focused: Yes, mostly mechanical and focused.
Concurrency: No concurrency-sensitive changes in the reviewed paths.
Lifecycle/static init: No new lifecycle/SIOF issue found.
Configuration: None.
Compatibility/storage/protocol: No incompatible API/storage/protocol change found.
Parallel code paths: Reviewed the replaced io_helper wrappers; current live paths remain aligned.
Special conditionals/comments: No blocking issue found.
Test coverage: Affected paths have some BE test coverage, but the new Arrow date-like test is not validating the real packed DateV2/DateTimeV2 values.
Modified test results: One new test is incorrect and should be fixed before merge.
Observability: N/A for this refactor.
Transaction/persistence/data writes: N/A.
FE/BE variable passing: N/A.
Performance: No blocking performance issue found.
Other issues: None beyond the incorrect test.

Copilot

Pull request overview

Copilot reviewed 59 out of 59 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wrong

github-actions · 2026-04-15T09:12:35Z

PR approved by at least one committer and no changes requested.

hello-stephen · 2026-04-15T10:23:11Z

BE UT Coverage Report

Increment line coverage 83.91% (266/317) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.11% (20177/37993)
Line Coverage	36.67% (190055/518222)
Region Coverage	32.91% (147497/448164)
Branch Coverage	34.06% (64610/189680)

hello-stephen · 2026-04-15T10:29:00Z

BE Regression && UT Coverage Report

Increment line coverage 86.41% (267/309) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.73% (27428/37202)
Line Coverage	57.35% (296258/516604)
Region Coverage	54.45% (246260/452274)
Branch Coverage	56.15% (106826/190248)

zclllyybb · 2026-04-29T07:51:57Z

wait #62865 to pick to 4.1

…#62179) Problem Summary: Remove the legacy io_helper wrapper layer and move its parsing and formatting entry points onto the existing cast implementations so serde and conversion code depends on the real owners of that behavior.

…E cast paths (#62179) (#62961) pick #62179

zclllyybb marked this pull request as draft April 7, 2026 14:09

zclllyybb force-pushed the agent/task-a4cc5335-io-helper-refactor branch from 26312d6 to 7b1a486Compare April 8, 2026 14:41

zclllyybb marked this pull request as ready for review April 8, 2026 14:41

zclllyybb requested a review from Copilot April 8, 2026 14:46

CopilotAI reviewed Apr 8, 2026
View reviewed changes

Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp
Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp
Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp

Copilotstarted reviewing on behalf of zclllyybb April 8, 2026 14:59 View session

zclllyybb requested a review from Copilot April 9, 2026 04:40

Copilotstarted reviewing on behalf of zclllyybb April 9, 2026 04:41 View session

github-actionsBot reviewed Apr 9, 2026
View reviewed changes

Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp

CopilotAI reviewed Apr 9, 2026

zclllyybb requested a review from Copilot April 9, 2026 07:35

CopilotAI reviewed Apr 9, 2026
View reviewed changes

Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp

Copilotstarted reviewing on behalf of zclllyybb April 9, 2026 08:31 View session

zclllyybb requested a review from Copilot April 9, 2026 17:23

Copilotstarted reviewing on behalf of zclllyybb April 9, 2026 17:24 View session

github-actionsBot reviewed Apr 9, 2026
View reviewed changes

Comment threadbe/src/core/data_type_serde/data_type_number_serde.cpp

CopilotAI reviewed Apr 9, 2026
View reviewed changes

zclllyybb added 2 commits April 15, 2026 15:16

zclllyybb force-pushed the agent/task-a4cc5335-io-helper-refactor branch from 73d11be to 79669b5Compare April 15, 2026 07:17

github-actionsBot previously requested changes Apr 15, 2026
View reviewed changes

Comment threadbe/test/core/data_type_serde/data_type_serde_number_test.cpp

zclllyybb requested a review from Copilot April 15, 2026 08:02

zclllyybb added the dev/4.1.x label Apr 15, 2026

Copilotstarted reviewing on behalf of zclllyybb April 15, 2026 08:03 View session

CopilotAI reviewed Apr 15, 2026
View reviewed changes

Comment threadbe/src/format/column_type_convert.h

Mryange approved these changes Apr 15, 2026
View reviewed changes

jacktengg approved these changes Apr 15, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 15, 2026

zclllyybb merged commit 42bf5b2 into apache:masterApr 15, 2026
36 of 37 checks passed

zclllyybb deleted the agent/task-a4cc5335-io-helper-refactor branch April 15, 2026 12:07

github-actionsBot added the dev/4.1.x-conflict label Apr 15, 2026

mymeiyi mentioned this pull request Apr 21, 2026
[fix](wal) Fix WAL replay loading 0 rows due to columns being marked as missing #62658
Merged

zclllyybb mentioned this pull request Apr 30, 2026
branch-4.1: [refactor](be) Remove io_helper helper indirection from BE cast paths (#62179) #62961
Merged

yiguolei pushed a commit that referenced this pull request May 1, 2026
branch-4.1: [refactor](be) Remove io_helper helper indirection from B…
f632c93
…E cast paths (#62179) (#62961) pick #62179

yiguolei added dev/4.1.1-merged and removed dev/4.1.x dev/4.1.x-conflict labels May 1, 2026

yiguolei mentioned this pull request May 20, 2026
4.1.1 Release Notes #63426
Closed

Uh oh!

Conversation

zclllyybb commented Apr 7, 2026

Uh oh!

hello-stephen commented Apr 7, 2026

Uh oh!

zclllyybb commented Apr 7, 2026

Uh oh!

hello-stephen commented Apr 7, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Apr 7, 2026

BE Regression && UT Coverage Report

Uh oh!

zclllyybb commented Apr 8, 2026

Uh oh!

zclllyybb commented Apr 8, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Apr 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hello-stephen commented Apr 8, 2026

BE Regression && UT Coverage Report

Uh oh!

zclllyybb commented Apr 9, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zclllyybb commented Apr 9, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

hello-stephen commented Apr 9, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Apr 9, 2026

BE Regression && UT Coverage Report

Uh oh!

zclllyybb commented Apr 9, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

CopilotAIApr 9, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIApr 9, 2026

Choose a reason for hiding this comment

Uh oh!

zclllyybb commented Apr 15, 2026

Uh oh!

zclllyybb commented Apr 15, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

github-actionsBot commented Apr 8, 2026•
edited
Loading