Skip to content

branch-4.1:[fix](storage) fix IOContext Use-After-Free (#59947) - #62241

Merged
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:pick-branch-4.1-pr-59947-20260408-193616
Apr 24, 2026
Merged

branch-4.1:[fix](storage) fix IOContext Use-After-Free (#59947)#62241
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:pick-branch-4.1-pr-59947-20260408-193616

Conversation

@freemandealer

Copy link
Copy Markdown
Member

Backport of #59947 to branch-4.1.

Original PR: #59947

No compile/test run for this pick.

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

Copy link
Copy Markdown
MemberAuthor

run buildall

use shared_ptr instead of raw pointer to manage lifespan
of ioctx in storage layer.
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
(cherry picked from commit b6e8f69)
@freemandealer
freemandealerforce-pushed the pick-branch-4.1-pr-59947-20260408-193616 branch from 8bbc905 to d324b65CompareApril 22, 2026 18:18
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 17.65% (27/153) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.22% (19969/37519)
Line Coverage36.70% (188133/512607)
Region Coverage33.04% (146280/442712)
Branch Coverage34.14% (64010/187476)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.41% (26225/36726)
Line Coverage54.31% (277469/510890)
Region Coverage51.66% (230742/446649)
Branch Coverage53.00% (99637/187998)

@freemandealer

Copy link
Copy Markdown
MemberAuthor

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.42% (26229/36726)
Line Coverage54.33% (277580/510890)
Region Coverage51.69% (230883/446649)
Branch Coverage53.01% (99665/187998)

@freemandealer

Copy link
Copy Markdown
MemberAuthor

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 69.93% (107/153) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.48% (26253/36726)
Line Coverage54.37% (277786/510890)
Region Coverage51.73% (231035/446649)
Branch Coverage53.06% (99751/187998)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit f15ec09 into apache:branch-4.1Apr 24, 2026
27 of 31 checks passed
yiguolei pushed a commit that referenced this pull request May 21, 2026
### What problem does this PR solve?
Introduced by #62241
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@freemandealer@Thearas@hello-stephen@yiguolei