[refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare by csun5285 · Pull Request #62327 · apache/doris

csun5285 · 2026-04-10T07:23:14Z

Remove SchemaCache entirely. Each scanner now always builds its own independent TabletSchema via std::make_shared<TabletSchema>(), eliminating shared mutable state between concurrent scanners.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-04-10T07:23:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

csun5285 · 2026-04-10T07:26:57Z

run buildall

csun5285 · 2026-04-10T07:29:17Z

run buildall

…::prepare After lightweight schema change adds a variant column, old-partition tablets still have num_variant_columns()==0 in their _max_version_schema. This causes OlapScanner::prepare() to cache the rebuilt schema (which now contains the variant column) into SchemaCache. Subsequent scanners for the same tablet get the exact same TabletSchema pointer via cache hit, then concurrently modify it in merge_dropped_columns() / _init_variant_columns(), leading to SIGSEGV in inherit_column_attributes(). Remove SchemaCache so each scanner always builds its own independent TabletSchema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

csun5285 · 2026-04-10T12:15:03Z

run buildall

hello-stephen · 2026-04-12T11:28:08Z

BE UT Coverage Report

Increment line coverage 7.69% (1/13) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.05% (20145/37975)
Line Coverage	36.59% (189424/517715)
Region Coverage	32.86% (147118/447723)
Branch Coverage	33.98% (64387/189460)

hello-stephen · 2026-04-12T11:33:38Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.62% (27379/37188)
Line Coverage	57.25% (295475/516118)
Region Coverage	54.35% (245559/451828)
Branch Coverage	56.11% (106635/190042)

eldenmoon

LGTM

github-actions · 2026-04-13T02:08:12Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-04-13T02:08:14Z

PR approved by anyone and no changes requested.

…anner::prepare (#62327) Remove SchemaCache entirely. Each scanner now always builds its own independent TabletSchema via `std::make_shared<TabletSchema>()`, eliminating shared mutable state between concurrent scanners. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…sh in OlapScanner::prepare #62327 (#62414) Cherry-picked from #62327 Co-authored-by: Chenyang Sun <sunchenyang@selectdb.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…anner::prepare (apache#62327) Remove SchemaCache entirely. Each scanner now always builds its own independent TabletSchema via `std::make_shared<TabletSchema>()`, eliminating shared mutable state between concurrent scanners. Issue Number: close #xxx Related PR: #xxx Problem Summary: None - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit aa1e21d)

…Scanner::prepare (#62327) (#62427) pick from master #62327 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

csun5285 changed the title ~~[fix](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare~~[refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepareApr 10, 2026

csun5285 force-pushed the fix/remove-schema-cache-variant-crash branch from f387677 to 881c2bdCompare April 10, 2026 07:28

csun5285 force-pushed the fix/remove-schema-cache-variant-crash branch from 881c2bd to 9470d25Compare April 10, 2026 12:14

eldenmoon added dev/4.1.x dev/4.0.x labels Apr 13, 2026

eldenmoon approved these changes Apr 13, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2026

github-actionsBot added the reviewed label Apr 13, 2026

yiguolei approved these changes Apr 13, 2026
View reviewed changes

yiguolei merged commit aa1e21d into apache:masterApr 13, 2026
31 of 33 checks passed

yiguolei added the usercase Important user case type label label Apr 13, 2026

github-actionsBot added the dev/4.0.x-conflict label Apr 13, 2026

github-actionsBot mentioned this pull request Apr 13, 2026
branch-4.1: [refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare #62327 #62414
Merged

yiguolei added dev/4.1.0-merged and removed dev/4.1.x labels Apr 13, 2026

csun5285 mentioned this pull request Apr 13, 2026
[branch-4.0](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare (#62327) #62427
Merged

eldenmoon added the dev/3.1.x label Apr 13, 2026

yiguolei pushed a commit that referenced this pull request Apr 15, 2026
[branch-4.0](scan) remove SchemaCache to fix concurrent crash in Olap…
a528fe0
…Scanner::prepare (#62327) (#62427) pick from master #62327 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

yiguolei added dev/4.0.6-merged and removed dev/4.0.x dev/4.0.x-conflict labels Apr 15, 2026

mymeiyi mentioned this pull request Apr 21, 2026
[fix](wal) Fix WAL replay loading 0 rows due to columns being marked as missing #62658
Merged

morningman mentioned this pull request Jun 3, 2026
4.0.6 Release Notes #64065
Closed

csun5285 removed the dev/3.1.x label Jun 5, 2026

Navigation Menu

Uh oh!

[refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare - #62327

[refactor](scan) remove SchemaCache to fix concurrent crash in OlapScanner::prepare#62327
yiguolei merged 1 commit into
apache:masterfrom
csun5285:fix/remove-schema-cache-variant-crash

csun5285 commented Apr 10, 2026•
edited
Loading

Uh oh!

Thearas commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

hello-stephen commented Apr 12, 2026

Uh oh!

hello-stephen commented Apr 12, 2026

Uh oh!

eldenmoon left a comment

Uh oh!

github-actionsBot commented Apr 13, 2026

Uh oh!

github-actionsBot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

csun5285 commented Apr 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

csun5285 commented Apr 10, 2026

Uh oh!

hello-stephen commented Apr 12, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Apr 12, 2026

BE Regression && UT Coverage Report

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 13, 2026

Uh oh!

github-actionsBot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

csun5285 commented Apr 10, 2026•
edited
Loading