Uh oh!
There was an error while loading. Please reload this page.
[fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner - #62343
Conversation
…appings_scanner PR apache#62077 added schema_role_mappings_scanner.cpp with compile_check_begin/end.h includes, but PR apache#62300 subsequently deleted those headers globally. This causes a compile failure on master: 'common/compile_check_begin.h' file not found. Generated by Claude Code
hello-stephen
commented
Apr 10, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
dataroaring
commented
Apr 10, 2026
run buildall |
There was a problem hiding this comment.
Pull request overview
Fixes a build break on master by removing references to deleted compile-check wrapper headers from the BE information_schema role mappings scanner.
Changes:
- Removed stale
common/compile_check_begin.h/common/compile_check_end.hincludes fromschema_role_mappings_scanner.cpp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
hello-stephen
commented
Apr 10, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Apr 12, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Apr 15, 2026
/review |
There was a problem hiding this comment.
No blocking findings.
Critical checkpoint conclusions:
- Goal and correctness: The PR removes two stale
common/compile_check_begin.h/common/compile_check_end.hincludes frombe/src/information_schema/schema_role_mappings_scanner.cpp, which directly resolves the reported build failure after those headers were deleted in #62300. The file content remains consistent with sibling scanners in the same directory. - Scope and clarity: The change is as small and focused as possible: exactly the two invalid includes are removed, with no behavioral edits.
- Concurrency: Not applicable. This change does not modify any threaded code, shared state, or lock behavior.
- Lifecycle/static initialization: No new lifecycle or static initialization behavior is introduced.
- Configuration: No config changes.
- Compatibility: No FE/BE protocol, storage format, symbol, or rolling-upgrade compatibility impact.
- Parallel code paths: I checked the
be/src/information_schemascanner implementations and they already follow the post-#62300 pattern without these headers, so this file is being brought back into line rather than creating divergence. - Special conditions: No new conditional logic is added.
- Test coverage: There is no targeted test in the PR. For this compile-only fix, the relevant validation is successful BE compilation; I did not run a build in this review environment.
- Observability: Not applicable. No runtime path changes.
- Transaction/persistence/data writes: Not applicable. No transaction, persistence, or data-modification logic is touched.
- FE-BE variable passing: Not applicable. No new transmitted fields.
- Performance: No performance impact.
- Other issues: None identified from the changed code and surrounding module conventions.
Residual risk:
- The only remaining risk is whether CI confirms the intended compile fix, since no local build was run during review.
Uh oh!
There was an error while loading. Please reload this page.
Summary
#include "common/compile_check_begin.h"and#include "common/compile_check_end.h"fromschema_role_mappings_scanner.cppschema_role_mappings_scanner.cpp(added by [feature](fe) Add information_schema role mappings table #62077) still referenced them, causing a compile failure on masterRoot Cause
PR #62077 and PR #62300 were prepared independently. #62077 added a new file with the compile_check includes, while #62300 deleted those headers. After both merged, master fails to compile with:
Test plan
🤖 Generated by ThinkOps — autonomous agent pipeline