Skip to content

[Exec](status) materialization_opertor return the error status by row_id_fetcher#62513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zclllyybb merged 1 commit into from
Apr 16, 2026
Merged

[Exec](status) materialization_opertor return the error status by row_id_fetcher #62513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions be/src/exec/operator/materialization_opertor.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,6 +416,12 @@ Status MaterializationOperator::push(RuntimeState* state, Block* in_block, bool
" target_backend_id:" + std::to_string(backend_id);
return Status::InternalError(error_text);
}
if (rpc_struct.response.status().status_code() != 0) {

@github-actionsgithub-actionsBotApr 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does catch the backend-side row_id_fetcher failure, but it rewrites every remote PStatus into Status::InternalError(...).

RowIdStorageReader::read_by_rowids() can return non-INTERNAL_ERROR codes (CANCELLED, Error<false>(e.code(), ...), etc.), and nearby RPC callers preserve them with Status::create(response.status()) (for example be/src/service/internal_service.cpp:1250 and be/src/storage/rowset_version_mgr.cpp:272). Converting them all to INTERNAL_ERROR changes the status seen upstream and can affect cancellation / retry handling.

Please build the extra backend/node context around Status::create(rpc_struct.response.status()) instead of replacing the remote status code.

Comment thread
HappenLee marked this conversation as resolved.
Status st = Status::create(rpc_struct.response.status());
st.append(fmt::format(", Backend:{}, Materialization Sink node id:{}", backend_id,
node_id()));
return st;
}
rpc_struct.cntl->Reset();
}

Expand Down
Loading