Uh oh!
There was an error while loading. Please reload this page.
[branch-4.1](variant) Fix compaction failure on no-key table with variant column uid=0 #62571 - #62657
Conversation
…lumn uid=0 (apache#62571) For a no-key duplicate table with only variant columns, the first variant column has unique_id=0.
hello-stephen
commented
Apr 21, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
csun5285
commented
Apr 21, 2026
run buildall |
hello-stephen
commented
Apr 21, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Apr 21, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
csun5285
commented
Apr 21, 2026
/review |
There was a problem hiding this comment.
Reviewed the backport against the changed branch-4.1 codepaths and the upstream fixes.
- Correctness: Pass. The
uid == 0case is handled consistently across extracted-column classification, compaction schema merge, scanner access-path routing, and variant stats collection. - Compatibility: Pass. The follow-up
has_parrent_column_unique_id()change removes theuint32 >= 0compile hazard while preserving the intended runtime behavior foruid == 0. - Test coverage: Pass. The BE unit test exercises compaction on a no-key variant table with root
unique_id = 0, and the new regression test validates query results before and after cumulative compaction. - Performance and operational risk: Pass. The changes are narrowly scoped condition fixes with no material algorithmic impact.
- Blocking issues: None found.
Residual risk: there is still no targeted test for scanner access-path pruning on a uid == 0 variant column, but I did not find a correctness issue in the current implementation.
Uh oh!
There was an error while loading. Please reload this page.
pick from master #62571#62632