Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](fe) Fix isCountStar incorrectly treating count(null) as count(*) #62548 - #62667
Merged
Merged
Conversation
#62548) ### What problem does this PR solve? Problem Summary: `Count.isCountStar()` returns `true` for `count(null)` because it only checks `child(0) instanceof Literal` without excluding `NullLiteral`. Since `count(null)` always returns 0 (it counts non-null values of a constant null), it is semantically different from `count(*)` which counts all rows. This could cause incorrect results if downstream rewrite rules (e.g. `PushDownAggThroughJoin`, `SimplifyWindowExpression`, `PushCountIntoUnionAll`) use `isCountStar()` before `CountLiteralRewrite` has a chance to rewrite `count(null)` to `0`. ### Release note Fixed `count(null)` being incorrectly treated as `count(*)` in query optimizer, which could lead to wrong results in certain rewrite scenarios. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Thearas
commented
Apr 21, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Thearas
commented
Apr 21, 2026
Contributor
run buildall |
hello-stephen
commented
Apr 21, 2026
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Apr 22, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62548