Skip to content

branch-4.0: [fix](query) avoid missing result packet for query during master switch #62721 - #62773

Merged
morningman merged 1 commit into
branch-4.0from
auto-pick-62721-branch-4.0
Jun 26, 2026
Merged

branch-4.0: [fix](query) avoid missing result packet for query during master switch #62721#62773
morningman merged 1 commit into
branch-4.0from
auto-pick-62721-branch-4.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #62721

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
yiguoleiforce-pushed the auto-pick-62721-branch-4.0 branch 2 times, most recently from 2ecf1a6 to 5fd4aa8CompareMay 9, 2026 08:21
@yiguolei

yiguolei commented May 9, 2026

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 24, 2026
@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@HonestManXin@morningman
[fix](query) avoid missing result packet for query during master swit…
c014375
…ch (#62721)
When master switch happen, the follower will briefly enter the unknown
state.
At this time, isForwardedToMaster for every request will be determined
as true, and during the finalizeCommand response packet phase, the
master proxy result will be directly used as the result, leading to the
loss of the real ResultPacket. Ultimately, the client remains hung while
waiting for the result to return until the socket timeout.
In fact, point query will never forward to master at present.
@morningman
morningmanforce-pushed the auto-pick-62721-branch-4.0 branch from 5fd4aa8 to c014375CompareJune 24, 2026 09:43
@morningman

morningman commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

run buildall

@morningman
morningman merged commit 24d9185 into branch-4.0Jun 26, 2026
28 of 32 checks passed
@github-actions
github-actionsBot deleted the auto-pick-62721-branch-4.0 branch June 26, 2026 01:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@yiguoleiyiguoleiAwaiting requested review from yiguolei

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen@yiguolei@morningman@dataroaring@HonestManXin