Uh oh!
There was an error while loading. Please reload this page.
[fix](fe) Fix IAM role auth not working in S3 FS #62584 - #62775
Conversation
w41ter
commented
Apr 24, 2026
run buildall |
w41ter
commented
Apr 24, 2026
/review |
Thearas
commented
Apr 24, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
6a6549a to
df3df7aComparew41ter
commented
Apr 24, 2026
run buildall |
w41ter
commented
Apr 24, 2026
@copilot review this PR |
There was a problem hiding this comment.
Buildability: blocking. now calls in two constructors, but that helper is not defined anywhere in , so FE will not compile as submitted.\n\nCorrectness: blocked by the compile failure above. I traced the touched stage/internal-stage and meta-service paths and did not find another distinct blocker in this PR beyond that missing method.\n\nCompatibility: no additional user-provided review focus was supplied.\n\nTests: the new unit test is directionally useful for static-vs-assume-role provider selection, but it cannot catch the current compile break and does not exercise the full stage flow end to end.
| objectStoreInfoPB.getPrefix()); | ||
| this(objectStoreInfoPB.getProvider(), getCredProviderType(objectStoreInfoPB), | ||
| objectStoreInfoPB.getAk(), objectStoreInfoPB.getSk(), objectStoreInfoPB.getBucket(), | ||
| objectStoreInfoPB.getEndpoint(), objectStoreInfoPB.getRegion(), |
There was a problem hiding this comment.
getCredProviderType(objectStoreInfoPB) is used here and again in the private ObjectInfo(ObjectStoreInfoPB, ...) constructor below, but there is no helper with that name in RemoteBase. As written, FE will not compile. Please either add the missing helper or inline the enum extraction in both places before merging.
Review note: the submitted REQUEST_CHANGES summary body was shell-mangled by backticks in the automation wrapper. The intended summary is:\n\nBuildability: blocking. |
df3df7a to
8e41a9dComparew41ter
commented
Apr 24, 2026
run buildall |
hello-stephen
commented
Apr 24, 2026
FE Regression Coverage ReportIncrement line coverage |
wyxxxcat
commented
Apr 24, 2026
@wyxxxcat need support more credential provider type after this pr merged |
PR approved by at least one committer and no changes requested. |
8e41a9d to
d053ca3Compareyiguolei
commented
Apr 24, 2026
run buildall |
morningman
commented
Apr 24, 2026
run buildall |
d053ca3 to
d960e6eComparehello-stephen
commented
Apr 24, 2026
FE Regression Coverage ReportIncrement line coverage |
yiguolei
commented
Apr 25, 2026
skip buildall |
pick #62584