Skip to content

[enhance](function) add a lambda functor version for array_sort (#57828) - #62830

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
csun5285:fix-opensource-324-4.1
Apr 25, 2026
Merged

[enhance](function) add a lambda functor version for array_sort (#57828)#62830
yiguolei merged 1 commit into
apache:branch-4.1from
csun5285:fix-opensource-324-4.1

Conversation

@csun5285

@csun5285csun5285 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

pick from master #57828

@csun5285
csun5285 requested a review from yiguolei as a code ownerApril 24, 2026 15:33
@Thearas

Thearas commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285

csun5285 commented Apr 24, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage54.53% (20063/36791)
Line Coverage35.53% (181912/512058)
Region Coverage29.76% (133478/448494)
Branch Coverage31.31% (59456/189901)

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 15.49% (11/71) 🎉
Increment coverage report
Complete coverage report

@yiguolei
yiguoleiforce-pushed the fix-opensource-324-4.1 branch from 9485252 to 687bf53CompareApril 24, 2026 19:59
@yiguolei

yiguolei commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

run buildall

@wumeibanfa@morningman
[enhance](function) add a lambda functor version for array_sort (apac…
00c07df
…he#57828)
add a lambda functor version for array_sort
Issue Number: apache#48203
Problem Summary:
```text
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| array_sort((x, y) -> CASE WHEN x IS NULL THEN -1
WHEN y IS NULL THEN 1
WHEN x < y THEN 1
WHEN x = y THEN 0
ELSE -1 END,
[3, 2, null, 5, null, 1, 2]) |
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| [null, null, 5, 3, 2, 2, 1] |
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| array_sort((x, y) -> IF(length(x) < length(y), -1, IF(length(x) = length(y), 0, 1)), ['a', 'abcd', 'abc']) |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| ["a", "abc", "abcd"] |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
```
@morningman

morningman commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

run buildall

@morningman
morningmanforce-pushed the fix-opensource-324-4.1 branch from 687bf53 to 00c07dfCompareApril 24, 2026 20:22
@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.23% (20004/37577)
Line Coverage36.67% (188499/514003)
Region Coverage33.04% (146588/443642)
Branch Coverage34.11% (64117/187969)

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 1.41% (1/71) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage70.85% (26071/36796)
Line Coverage52.99% (271403/512185)
Region Coverage46.56% (208890/448656)
Branch Coverage49.90% (94784/189955)

@hello-stephen

hello-stephen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 92.96% (66/71) 🎉
Increment coverage report
Complete coverage report

@yiguolei

yiguolei commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

skip buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2026
@github-actions

github-actionsBot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 9bcf79c into apache:branch-4.1Apr 25, 2026
31 of 33 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csun5285@Thearas@hello-stephen@yiguolei@morningman@wumeibanfa