[fix](cloud) refresh event warmup backends by liaoxin01 · Pull Request #62839 · apache/doris

liaoxin01 · 2026-04-25T15:13:04Z

Proposed changes

Refresh the source BE address list before each event-driven cloud warm-up notification so newly added BEs can receive the SET_JOB event.

Add a unit test covering refresh of event-driven source backend addresses.

Testing

git diff --check
mvn -pl fe-core -am -Dtest=org.apache.doris.cloud.CloudWarmUpJobTest -DfailIfNoTests=false test

hello-stephen · 2026-04-25T15:13:10Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Copilot

Pull request overview

This PR ensures event-driven cloud warm-up notifications always target an up-to-date source backend list, so newly added BEs receive the SET_JOB event.

Changes:

Refresh source BE thrift address list before each event-driven warm-up notification.
Add a unit test intended to verify event-driven BE address refresh behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
fe/fe-core/src/main/java/org/apache/doris/cloud/CloudWarmUpJob.java	Refreshes BE address mapping prior to sending event-driven warm-up RPCs; resets cached client/address state.
fe/fe-core/src/test/java/org/apache/doris/cloud/CloudWarmUpJobTest.java	Adds a new unit test for refreshing event-driven source backend addresses.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-25T15:17:10Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-04-25T15:17:12Z

PR approved by anyone and no changes requested.

liaoxin01 · 2026-04-25T15:27:26Z

run buildall

liaoxin01 · 2026-04-25T15:53:39Z

Addressed review comments:

Rewrote CloudWarmUpJobTest to use Mockito/Mockito-inline instead of JMockit.
Reduced event-driven BE refresh INFO log to address counts and moved full address maps to DEBUG.

Verified with:

git diff --check
mvn -pl fe-core -am -Dtest=org.apache.doris.cloud.CloudWarmUpJobTest -DfailIfNoTests=false test

liaoxin01 · 2026-04-25T15:58:54Z

run buildall

hello-stephen · 2026-04-25T17:26:56Z

FE UT Coverage Report

Increment line coverage 69.23% (9/13) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-04-25T18:33:29Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/13) 🎉
Increment coverage report
Complete coverage report

github-actions · 2026-04-27T05:23:44Z

PR approved by at least one committer and no changes requested.

gavinchou

LGTM

Refresh the source BE address list before each event-driven cloud warm-up notification so newly added BEs can receive the SET_JOB event. Add a unit test covering refresh of event-driven source backend addresses.

Cherry-picked from #62839 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

Refresh the source BE address list before each event-driven cloud warm-up notification so newly added BEs can receive the SET_JOB event. Add a unit test covering refresh of event-driven source backend addresses.

CopilotAI review requested due to automatic review settings April 25, 2026 15:13

liaoxin01 requested review from dataroaring, gavinchou and w41ter as code owners April 25, 2026 15:13

Copilotstarted reviewing on behalf of liaoxin01 April 25, 2026 15:13 View session

gavinchou previously approved these changes Apr 25, 2026
View reviewed changes

gavinchou added dev/3.1.x dev/4.0.x dev/4.1.x labels Apr 25, 2026

CopilotAI reviewed Apr 25, 2026
View reviewed changes

Comment threadfe/fe-core/src/test/java/org/apache/doris/cloud/CloudWarmUpJobTest.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/cloud/CloudWarmUpJob.java

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2026

github-actionsBot added the reviewed label Apr 25, 2026

[fix](cloud) refresh event warmup backends
105551d

liaoxin01 dismissed gavinchou’s stale review via 105551dApril 25, 2026 15:51

liaoxin01 force-pushed the fix-load-event-warmup-be-refresh-pr branch from 447b47a to 105551dCompare April 25, 2026 15:51

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 25, 2026

bobhan1 approved these changes Apr 27, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 27, 2026

gavinchou approved these changes Apr 28, 2026
View reviewed changes

gavinchou merged commit d61e8eb into apache:masterApr 28, 2026
33 of 34 checks passed

github-actionsBot mentioned this pull request Apr 28, 2026
branch-4.0: [fix](cloud) refresh event warmup backends #62839 #62887
Merged

github-actionsBot mentioned this pull request Apr 28, 2026
branch-4.1: [fix](cloud) refresh event warmup backends #62839 #62888
Merged

yiguolei pushed a commit that referenced this pull request May 1, 2026
branch-4.1: [fix](cloud) refresh event warmup backends#62839(#62888)
99d645d
Cherry-picked from #62839 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

yiguolei added dev/4.1.1-merged and removed dev/4.1.x labels May 1, 2026

liaoxin01 removed the dev/3.1.x label May 6, 2026

yiguolei pushed a commit that referenced this pull request May 10, 2026
branch-4.0: [fix](cloud) refresh event warmup backends#62839(#62887)
4513560
Cherry-picked from #62839 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

yiguolei added dev/4.0.6-merged and removed dev/4.0.x labels May 10, 2026

yiguolei mentioned this pull request May 20, 2026
4.1.1 Release Notes #63426
Closed

morningman mentioned this pull request Jun 3, 2026
4.0.6 Release Notes #64065
Closed

Navigation Menu

Uh oh!

[fix](cloud) refresh event warmup backends - #62839

[fix](cloud) refresh event warmup backends#62839
gavinchou merged 1 commit into
apache:masterfrom
liaoxin01:fix-load-event-warmup-be-refresh-pr

liaoxin01 commented Apr 25, 2026•
edited
Loading

Uh oh!

hello-stephen commented Apr 25, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

hello-stephen commented Apr 25, 2026

Uh oh!

hello-stephen commented Apr 25, 2026

Uh oh!

github-actionsBot commented Apr 27, 2026

Uh oh!

gavinchou left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

liaoxin01 commented Apr 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Testing

Uh oh!

hello-stephen commented Apr 25, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

github-actionsBot commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

liaoxin01 commented Apr 25, 2026

Uh oh!

hello-stephen commented Apr 25, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Apr 25, 2026

FE Regression Coverage Report

Uh oh!

github-actionsBot commented Apr 27, 2026

Uh oh!

gavinchou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liaoxin01 commented Apr 25, 2026•
edited
Loading