Uh oh!
There was an error while loading. Please reload this page.
[branch-4.0](variant) Skip full footer scan when constructing VariantStatsCaculator (#62819) - #63113
Merged
Merged
Conversation
…culator (apache#62819) In **vertical compaction**, `SegmentWriter::init()` is called multiple times against the same writer (key columns first, then each value-column group). The footer **accumulates** across calls, so every additional `init()` re-scans an ever-larger footer — including entries from prior `init()`s that the current `column_ids` cannot address. | | Before | After | |---|---|---| | Single construction | O(footer accumulated size) | O(this init's column_ids size) | | N vertical-compaction `init()` calls | **O(N²)** | **O(N)** | Snapshot `_footer.columns_size()` **before** `_create_writers` appends new entries and pass it to `VariantStatsCaculator` as `footer_column_offset`. The constructor only walks `[offset, end)` — its own slice. When performing compaction with 10,000 columns in the variant, this method accounts for around 8% of CPU usage. After changing it to O(N), this section has disappeared from the flame graph. (cherry picked from commit ffefcae)
hello-stephen
commented
May 10, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
csun5285
commented
May 10, 2026
ContributorAuthor
run buildall |
…rized:: in variant_stats_calculator_test
csun5285
commented
May 10, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
May 10, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 10, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
commented
May 10, 2026
Contributor
skip buildall |
yiguolei
approved these changes
May 10, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from master #62819
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)