Skip to content

[refactor](storage) drop StorageField wrapper and clean up related dead code#63233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airborne12 merged 3 commits into from
May 21, 2026
Merged

[refactor](storage) drop StorageField wrapper and clean up related dead code #63233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f31d57
[refactor](storage) drop StorageField wrapper, use TabletColumn directly
csun5285 May 12, 2026
4cba47b
[refactor](storage) collapse redundant column params in variant write…
csun5285 May 14, 2026
c379e58
[refactor](storage) clean up dead refs to deleted classes in benchmar…
csun5285 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions be/benchmark/benchmark_zone_map_index.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,6 @@

#include "core/data_type/data_type_factory.hpp"
#include "core/string_ref.h"
#include "storage/field.h"
#include "storage/index/zone_map/zone_map_index.h"
#include "storage/tablet/tablet_schema.h"
#include "util/slice.h"
Expand DownExpand Up@@ -116,9 +115,8 @@ std::unique_ptr<ZoneMapIndexWriter> make_writer() {
col = make_column(FieldType::OLAP_FIELD_TYPE_VARCHAR, 64, 1);
dtype = DataTypeFactory::instance().create_data_type(TYPE_VARCHAR, false, 0, 0, 64);
}
std::unique_ptr<StorageField> field(StorageFieldFactory::create(*col));
std::unique_ptr<ZoneMapIndexWriter> w;
(void)ZoneMapIndexWriter::create(dtype, field.get(), w);
(void)ZoneMapIndexWriter::create(dtype, col.get(), w);
Comment thread
csun5285 marked this conversation as resolved.
return w;
}

Expand Down
5 changes: 0 additions & 5 deletions be/src/core/data_type/data_type_factory.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,14 +65,9 @@
#include "core/data_type/define_primitive_type.h"
#include "core/types.h"
#include "core/uint128.h"
#include "storage/field.h"
#include "storage/olap_common.h"

namespace doris {
DataTypePtr DataTypeFactory::create_data_type(const doris::StorageField& col_desc) {
return create_data_type(col_desc.get_desc(), col_desc.is_nullable());
}

DataTypePtr DataTypeFactory::create_data_type(const TabletColumn& col_desc, bool is_nullable) {
DataTypePtr nested = nullptr;
if (col_desc.type() == FieldType::OLAP_FIELD_TYPE_AGG_STATE) {
Expand Down
2 changes: 0 additions & 2 deletions be/src/core/data_type/data_type_factory.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,6 @@ namespace arrow {
class DataType;
} // namespace arrow
namespace doris {
class StorageField;
class PColumnMeta;
enum class FieldType;

Expand All@@ -52,7 +51,6 @@ class DataTypeFactory {
return instance;
}

DataTypePtr create_data_type(const doris::StorageField& col_desc);
DataTypePtr create_data_type(const TabletColumn& col_desc, bool is_nullable = false);

DataTypePtr create_data_type(const PColumnMeta& pcolumn);
Expand Down
57 changes: 0 additions & 57 deletions be/src/core/value/map_value.h
View file
Open in desktop

This file was deleted.

61 changes: 0 additions & 61 deletions be/src/core/value/struct_value.h
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions be/src/io/cache/cache_block_meta_store.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,8 +33,6 @@

#include "common/status.h"
#include "exec/common/hex.h"
#include "storage/field.h"
#include "storage/field.h" // For OLAP_FIELD_TYPE_BIGINT
#include "storage/key_coder.h"
#include "storage/olap_common.h"
#include "util/threadpool.h"
Expand Down
39 changes: 0 additions & 39 deletions be/src/runtime/collection_value.cpp
View file
Open in desktop

This file was deleted.

80 changes: 0 additions & 80 deletions be/src/runtime/collection_value.h
View file
Open in desktop

This file was deleted.

Loading
Loading