Uh oh!
There was an error while loading. Please reload this page.
[fix](iceberg) Allow disabling REST catalog view operations - #63319
Merged
morningman merged 1 commit intoMay 20, 2026
Conversation
(cherry picked from commit 1ba3699)
hello-stephen
commented
May 17, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new Iceberg REST property to toggle view support and updates Iceberg metadata operations to honor it (primarily to avoid calling view APIs when disabled).
Changes:
- Introduces
iceberg.rest.view-enabled(defaulttrue) inIcebergRestProperties. - Gates view-related metadata operations (
listViews,viewExists,loadView, etc.) behind a newisViewCatalogEnabled()check. - Adds unit tests for the new property and for
listTableNamesbehavior with views enabled/disabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/datasource/property/metastore/IcebergRestProperties.java | Adds the iceberg.rest.view-enabled connector property and accessor. |
| fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java | Uses the new toggle to conditionally enable/disable view operations in metadata flows. |
| fe/fe-core/src/test/java/org/apache/doris/datasource/property/metastore/IcebergRestPropertiesTest.java | Adds a test validating the new REST view-enabled behavior/default. |
| fe/fe-core/src/test/java/org/apache/doris/datasource/iceberg/IcebergMetadataOpTest.java | Adds tests to ensure listTableNames avoids listViews when view support is disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private void performDropView(String remoteDbName, String remoteViewName) throws DdlException { | ||
| if (!(catalog instanceof ViewCatalog)) { | ||
| if (!isViewCatalogEnabled()) { | ||
| throw new DdlException("Drop Iceberg view is not supported with not view catalog."); |
Comment on lines
190
to
196
| // IcebergMetadataOps handles listTableNames and listViewNames separately. | ||
| // listTableNames should only focus on the table type, | ||
| // but in reality, Iceberg's return includes views. Therefore, we added a filter to exclude views. | ||
| if (catalog instanceof ViewCatalog) { | ||
| if (isViewCatalogEnabled()) { | ||
| views = ((ViewCatalog) catalog).listViews(getNamespace(dbName)) | ||
| .stream().map(TableIdentifier::name).collect(Collectors.toList()); | ||
| } else { |
Comment on lines
+1185
to
+1195
| private boolean isViewCatalogEnabled() { | ||
| if (!(catalog instanceof ViewCatalog)) { | ||
| return false; | ||
| } | ||
| if (dorisCatalog instanceof IcebergRestExternalCatalog) { | ||
| MetastoreProperties metaProps = dorisCatalog.getCatalogProperty().getMetastoreProperties(); | ||
| if (metaProps instanceof IcebergRestProperties) { | ||
| return ((IcebergRestProperties) metaProps).isIcebergRestViewEnabled(); | ||
| } | ||
| } | ||
| return true; |
Comment on lines
+1119
to
1121
| if (!isViewCatalogEnabled()) { | ||
| return false; | ||
| } |
xylaaaaa
commented
May 17, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
May 17, 2026
Contributor
FE UT Coverage ReportIncrement line coverage |
morningman
approved these changes
May 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #62986
Problem Summary: Backport #62986 to branch-4.0. This allows Iceberg REST catalog users to disable view operations with
iceberg.rest.view-enabled=falsewhen the REST catalog does not support view endpoints. The default remains enabled.Release note
Add
iceberg.rest.view-enabledfor Iceberg REST catalog. It defaults to true and can be set to false to skip view operations.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)
Test
MAVEN_OPTS='-Xmx4g -XX:MaxMetaspaceSize=1g' FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.datasource.iceberg.IcebergMetadataOpTest,org.apache.doris.datasource.property.metastore.IcebergRestPropertiesTest