Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Remove unsafe JsonbWriter key overload #63355 - #63437
Merged
Conversation
Problem Summary: `JsonbWriter::writeKey(const char*)` inferred key length with `strlen`, which silently truncated byte strings that contained embedded NUL bytes. Remove this overload so callers must use the explicit-length API. ### Release note None ### Check List (For Author) - Test: Unit Test - `./run-be-ut.sh --run --filter=JsonbDocumentTest.*:JsonbSerializeTest.*:JsonbParserTest.*:ConvertFieldToTypeTest.*` - `build-support/clang-format.sh` - `build-support/check-format.sh` - `build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN` (failed: existing clang-tidy environment/pre-existing diagnostics report missing `stddef.h` and unmatched `NOLINTEND` in `be/src/core/types.h`) - Behavior changed: Yes. Internal C++ callers can no longer use `JsonbWriter::writeKey(const char*)` and must pass an explicit key length. - Does this need documentation: No
hello-stephen
commented
May 20, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
May 20, 2026
Contributor
run buildall |
yiguolei
approved these changes
May 21, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63355