Uh oh!
There was an error while loading. Please reload this page.
branch-4.1 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan (#62509) - #63538
Conversation
englefly
commented
May 22, 2026
run buildall |
hello-stephen
commented
May 22, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
englefly
commented
May 27, 2026
run buildall |
hello-stephen
commented
May 27, 2026
FE Regression Coverage ReportIncrement line coverage |
hello-stephen
commented
May 27, 2026
FE UT Coverage ReportIncrement line coverage |
englefly
commented
Jun 2, 2026
run buildall |
englefly
commented
Jun 2, 2026
run buildall |
hello-stephen
commented
Jun 2, 2026
FE Regression Coverage ReportIncrement line coverage |
englefly
commented
Jun 2, 2026
run external |
englefly
commented
Jun 2, 2026
/review |
There was a problem hiding this comment.
Review opinion: approve.
Critical checkpoints:
- Existing inline review threads: read; none were present, so there are no duplicate concerns to avoid.
- User focus points: read; no additional focus was provided, and no extra issue was found in that area.
- Repository instructions: checked AGENTS.md; the Nereids expression-specific checkLegalityBeforeTypeCoercion rule is not applicable to these changed files.
- Correctness: the actual GitHub PR diff only changes physical scan string formatting to print plan ids and preserves table/index/partition information in the toSqlString fields; I did not find a behavioral correctness regression.
- Tests: the partitionRowCount assertion was adjusted to avoid depending on unstable plan ids while still checking the relevant table/partition row-count output. No failing inline issue identified.
No inline comments submitted.
hello-stephen
commented
Jun 2, 2026
FE Regression Coverage ReportIncrement line coverage |
Uh oh!
There was an error while loading. Please reload this page.
pick #62576
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)