Uh oh!
There was an error while loading. Please reload this page.
branch-4.0 [opt](nerieds) PhysicalOlapScan and PhysicalFileScan should print its id in plan #62509 - #63586
Conversation
englefly
commented
May 25, 2026
run buildall |
hello-stephen
commented
May 25, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
englefly
commented
May 25, 2026
run buildall |
englefly
commented
Jun 2, 2026
run buildall |
englefly
commented
Jun 2, 2026
/review |
There was a problem hiding this comment.
I found one blocking issue in the updated regression test. The production toString() changes themselves look consistent with the stated goal of printing the relation id while preserving table information as a property, but the test change drops the actual row-count assertion that this suite is meant to protect.
Critical checkpoints:
- Correctness/regression coverage: blocking issue found;
partitionRowCountno longer asserts the expectedstats=4row count. - Compatibility/API surface: no new external API or persistence compatibility issue found in the GitHub PR diff.
- Tests: existing test was updated, but it is now too weak and should be tightened before merge.
- Existing review threads: none were present, so this is not a duplicate.
- User focus points: no additional user-provided review focus was supplied.
Uh oh!
There was an error while loading. Please reload this page.
englefly
commented
Jun 2, 2026
run cloud_p0 |
englefly
commented
Jun 2, 2026
run nonConcurrent |
Uh oh!
There was an error while loading. Please reload this page.
What problem does this PR solve?
pick #62509
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)