Skip to content

[fix](be) Fix unused constant/function build errors in md5.cpp - #63608

Open
zwy991114 wants to merge 1 commit into
apache:masterfrom
zwy991114:fix_be_build
Open

[fix](be) Fix unused constant/function build errors in md5.cpp #63608
zwy991114 wants to merge 1 commit into
apache:masterfrom
zwy991114:fix_be_build

Conversation

@zwy991114

@zwy991114zwy991114 commented May 25, 2026•
edited
Loading

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #63484

Problem Summary:

The constants MD5_A0/B0/C0/D0 and the helper functions md5_num_blocks / md5_pad_final_blocks in be/src/util/md5.cpp are only referenced inside the #ifdef __AVX2__ multi-buffer code path. On builds without AVX2 support, the compiler reports -Wunused-const-variable and -Wunused-function, which are promoted to errors via -Werror and break the build.

Move these AVX2-only declarations under the same #ifdef __AVX2__ guard that protects their sole consumer. MD5_DUMMY_INPUT and md5_to_hex remain outside the guard since both code paths use them.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zwy991114

zwy991114 commented May 25, 2026

Copy link
Copy Markdown
Author

/review

@hello-stephen

hello-stephen commented May 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow

morrySnow commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

run buildall

@morrySnow

morrySnow commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

/review

github-actions[bot]
github-actionsBot reviewed Jun 1, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Critical checkpoint conclusions:

  • Goal and tests: The PR aims to avoid unused constant/function build errors on non-AVX2 builds. The change accomplishes this by moving the AVX2-only constants and helpers under the same __AVX2__ guard as their only consumers. No new test is required for this mechanical build-guard adjustment.
  • Scope: The modification is small, clear, and focused on be/src/util/md5.cpp only.
  • Concurrency: No concurrency behavior is involved.
  • Lifecycle/static initialization: No non-trivial lifecycle or cross-translation-unit static initialization concern is introduced; the moved values are namespace-scope constexpr constants and local helpers.
  • Configuration: No configuration item is added or changed.
  • Compatibility: No function symbols, persisted data, wire protocol, or storage format are changed.
  • Parallel paths: Both AVX2 and non-AVX2 paths still keep the shared MD5_DUMMY_INPUT and md5_to_hex code available; AVX2-only helpers remain available only to the AVX2 path.
  • Conditional checks: The __AVX2__ guard matches the existing AVX2 implementation guard and is appropriate for these declarations.
  • Test coverage/results: Existing MD5 unit coverage remains applicable. No test result files are added or modified.
  • Observability: Not applicable; no runtime behavior or diagnostics are changed.
  • Transaction/persistence/data writes: Not applicable.
  • FE/BE variable passing: Not applicable.
  • Performance: No runtime performance impact expected.
  • Other issues: None identified.

User focus points: No additional user-provided review focus was present.

Review notes: I attempted a local non-AVX2 syntax/warning check for be/src/util/md5.cpp, but the standalone command could not complete in this runner because required third-party headers were not available through that ad hoc include path. The code review conclusion is based on the PR diff and surrounding implementation.

HappenLee
HappenLee approved these changes Jun 1, 2026
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 1, 2026
@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage63.81% (24320/38114)
Line Coverage47.50% (251292/529057)
Region Coverage44.57% (207571/465681)
Branch Coverage45.66% (89365/195715)

@hello-stephen

hello-stephen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28829 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c638814942225b9264511b0b59171f2e1057139, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17636	4042	4088	4042
q2	q3	10811	1356	797	797
q4	4685	476	336	336
q5	7559	890	584	584
q6	179	174	140	140
q7	773	849	636	636
q8	9544	1674	1524	1524
q9	7047	4463	4408	4408
q10	6803	1825	1493	1493
q11	434	276	246	246
q12	657	431	290	290
q13	18167	3437	2729	2729
q14	263	257	240	240
q15	q16	816	773	706	706
q17	1209	1053	847	847
q18	6642	5624	5531	5531
q19	1517	1328	1015	1015
q20	528	398	262	262
q21	6230	2854	2684	2684
q22	433	368	319	319
Total cold run time: 101933 ms
Total hot run time: 28829 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4838	4704	4912	4704
q2	q3	5016	5203	4560	4560
q4	2128	2231	1384	1384
q5	4871	4707	4730	4707
q6	224	180	132	132
q7	1847	1708	1590	1590
q8	2462	2096	1986	1986
q9	7402	7403	7333	7333
q10	4726	4655	4187	4187
q11	530	381	356	356
q12	728	730	533	533
q13	3058	3358	2766	2766
q14	274	281	265	265
q15	q16	677	708	607	607
q17	1260	1251	1241	1241
q18	7500	6833	6678	6678
q19	1092	1133	1122	1122
q20	2217	2206	1949	1949
q21	5259	4544	4440	4440
q22	522	469	427	427
Total cold run time: 56631 ms
Total hot run time: 50967 ms

@hello-stephen

hello-stephen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage63.81% (24320/38114)
Line Coverage47.50% (251292/529057)
Region Coverage44.57% (207571/465681)
Branch Coverage45.66% (89365/195715)

@hello-stephen

hello-stephen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 170766 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c638814942225b9264511b0b59171f2e1057139, data reload: false
query5	4353	653	521	521
query6	324	235	200	200
query7	4249	583	285	285
query8	325	235	224	224
query9	8801	4003	4009	4003
query10	450	353	305	305
query11	5753	2341	2143	2143
query12	190	138	130	130
query13	1328	607	430	430
query14	6112	5450	5122	5122
query14_1	4455	4483	4462	4462
query15	221	206	182	182
query16	1002	472	447	447
query17	1184	742	617	617
query18	2775	522	370	370
query19	231	214	183	183
query20	143	146	133	133
query21	223	148	132	132
query22	13646	13600	13448	13448
query23	17432	16497	16122	16122
query23_1	16280	16232	16349	16232
query24	7787	1774	1324	1324
query24_1	1313	1301	1351	1301
query25	606	513	456	456
query26	1324	329	171	171
query27	2713	603	345	345
query28	4716	2030	2040	2030
query29	1031	654	548	548
query30	316	245	201	201
query31	1155	1085	970	970
query32	94	78	77	77
query33	543	376	309	309
query34	1182	1136	658	658
query35	813	790	754	754
query36	1374	1406	1279	1279
query37	155	111	89	89
query38	3189	3186	3039	3039
query39	928	910	886	886
query39_1	887	879	860	860
query40	243	148	126	126
query41	66	64	62	62
query42	111	107	117	107
query43	333	328	288	288
query44 query45	211	203	204	203
query46	1069	1162	755	755
query47	2366	2406	2274	2274
query48	395	404	288	288
query49	641	495	389	389
query50	990	339	256	256
query51	4299	4294	4234	4234
query52	105	109	96	96
query53	260	286	215	215
query54	322	280	254	254
query55	92	94	85	85
query56	315	318	322	318
query57	1444	1441	1321	1321
query58	304	273	275	273
query59	1571	1649	1489	1489
query60	330	330	317	317
query61	165	161	156	156
query62	698	654	588	588
query63	246	202	207	202
query64	2405	823	683	683
query65 query66	1689	476	361	361
query67	29903	29822	29717	29717
query68 query69	453	338	300	300
query70	1060	1021	986	986
query71	348	276	268	268
query72	3097	2721	2410	2410
query73	846	749	426	426
query74	5120	4949	4776	4776
query75	2701	2616	2253	2253
query76	2306	1159	768	768
query77	402	409	345	345
query78	12372	12393	11902	11902
query79	1498	993	758	758
query80	1377	547	470	470
query81	516	279	241	241
query82	972	153	118	118
query83	341	282	252	252
query84	263	141	113	113
query85	939	538	457	457
query86	457	352	347	347
query87	3430	3391	3225	3225
query88	3663	2765	2750	2750
query89	462	398	346	346
query90	1934	189	178	178
query91	183	166	141	141
query92	81	77	75	75
query93	1647	1431	868	868
query94	741	368	301	301
query95	681	379	350	350
query96	1001	798	358	358
query97	2719	2736	2598	2598
query98	237	229	228	228
query99	1170	1178	1058	1058
Total cold run time: 256217 ms
Total hot run time: 170766 ms

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@HappenLeeHappenLeeHappenLee approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zwy991114@hello-stephen@morrySnow@HappenLee