Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [improvement](executor) use real elapsed time to compute workload group metrics refresh interval #63537 - #63667
Merged
Conversation
…up metrics refresh interval (#63537) The original implementation of `WorkloadGroupMetrics::refresh_metrics()` uses `config::workload_group_metrics_interval_ms / 1000` as a fixed divisor to compute per-second CPU and scan IO rates. This is inaccurate when: 1. The refresh thread is delayed due to system load or scheduling jitter 2. The configured interval is changed at runtime In both cases, the reported per-second CPU/IO rates diverge from reality. This PR replaces the fixed config-based interval with the actual monotonic time delta between two consecutive refreshes, so the rates stay accurate regardless of thread scheduling delays or runtime config changes. It also adds a division-by-zero guard for sub-second refresh intervals and corresponding unit tests. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hello-stephen
commented
May 26, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
May 26, 2026
Contributor
run buildall |
yiguolei
commented
Jun 5, 2026
Contributor
skip buildall |
yiguolei
approved these changes
Jun 5, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63537