[fix](fe) set cloud version_cache_ttl to 0 temporarily if retry a query with -230 by mymeiyi · Pull Request #63721 · apache/doris

mymeiyi · 2026-05-27T06:21:53Z

If a query get E-230 error and cloud_partition_version_cache_ttl_ms is not set to 0, this pr set the session var to 0 temporarily to get the newest version.

hello-stephen · 2026-05-27T06:21:58Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Copilot

Pull request overview

This PR updates FE query retry behavior in cloud mode to temporarily disable cloud partition/table version caching when retrying after an E-230 error, and adds regression/unit tests to validate the behavior and session variable restoration.

Changes:

In StmtExecutor.queryRetry, detect E-230 retry conditions and set cloud_*_version_cache_ttl_ms to 0 for the next retry attempt (via setVarOnce), relying on existing per-execution session var reversion.
Add FE unit tests covering the E-230 detection logic and the temporary TTL override + revert path.
Extend the cloud regression test to validate that session TTLs remain unchanged after a retry sequence triggered by injected E-230.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
regression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy	Adds a regression scenario verifying TTL values are restored after an E-230-triggered retry.
fe/fe-core/src/test/java/org/apache/doris/qe/StmtExecutorTest.java	Adds unit tests for E-230 detection and temporary TTL override + revert behavior.
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java	Implements cloud-mode E-230 retry hook to temporarily disable version caching for the next attempt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mymeiyi · 2026-05-27T06:37:24Z

/review

github-actions

Review summary:

No additional blocking issues found in the PR diff beyond the existing inline threads about the unconditional TTL log message and the typoed test future variable names.

Critical checkpoint conclusions:

Goal and proof: The PR targets E-230 retry failures caused by stale cloud version caches by temporarily forcing table/partition version TTLs to 0 for the next retry. The added unit tests cover the decision and revert path, and the cloud regression test covers retry success with restored session TTLs.
Scope and clarity: The production change is small and localized to StmtExecutor retry handling.
Concurrency: No new shared cross-session mutable state is introduced. The session variable changes are scoped to the current ConnectContext and restored through the existing execute() finally path.
Lifecycle: No new static initialization or object lifecycle concerns found. Config.cloud_unique_id changes in the unit test are restored in finally.
Configuration: No new config/session variables are added; existing cloud TTL session variables are temporarily overridden through existing SET_VAR-style machinery.
Compatibility: No FE-BE protocol, storage format, or persistence compatibility change found.
Parallel paths: The change applies to StmtExecutor query retry; async MTMV retry has separate existing coverage and was not modified here.
Conditional checks: The E-230/cloud-mode/TTL condition is consistent with the target failure mode.
Tests and results: Added tests are relevant. Existing review already covers a minor test readability typo.
Observability: Existing review already covers the misleading INFO log when setVarOnce fails; no additional observability blocker found.
Transactions/persistence/data writes: No new persistence path is introduced. For query retry, successful execution observes freshly fetched cloud versions while original session TTLs are restored afterward.
Performance: The extra work is only on retry after E-230 and consists of two session variable updates before replanning, so no hot-path performance issue found.

User focus: No additional user-provided review focus was supplied.

mymeiyi · 2026-05-27T06:46:32Z

/review

github-actions

I found one correctness issue in the retry path. The change handles normal session TTLs, but SQL-level SET_VAR hints can still overwrite the temporary zero before planning reads cloud visible versions.

Critical checkpoint conclusions:

Goal/test: the PR targets E-230 retries with stale cloud version cache and adds unit/regression coverage, but the SET_VAR hint path is not covered and can bypass the fix.
Scope: the implementation is small and focused.
Concurrency/lifecycle: no new shared mutable state, locks, or special lifecycle concerns found.
Config/compatibility: no new configuration or incompatible storage/protocol change.
Parallel paths: normal session variables are covered, but the SQL-level SET_VAR path is a parallel session-variable mutation path and needs handling.
Tests: added tests cover plain session TTL restore; they do not cover SET_VAR overriding the retry TTL.
Observability/performance/transactions: no additional blocking issue found beyond the existing known INFO-log review thread.

User focus: no additional user-provided review focus was specified.

mymeiyi · 2026-05-27T07:07:44Z

run buildall

hello-stephen · 2026-05-27T07:28:14Z

TPC-H: Total hot run time: 31011 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d5d55921b0b61c67bbfb77a3f8dd0ac6dc417e3, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17688	3969	3933	3933
q2	q3	10741	1371	788	788
q4	4685	468	342	342
q5	7632	2268	2087	2087
q6	241	173	134	134
q7	956	810	636	636
q8	9355	1724	1527	1527
q9	6644	4950	4900	4900
q10	6448	2249	1896	1896
q11	429	269	242	242
q12	697	414	295	295
q13	18266	3352	2780	2780
q14	267	259	237	237
q15	q16	819	774	707	707
q17	976	962	959	959
q18	6964	5861	5565	5565
q19	1286	1276	1011	1011
q20	498	394	249	249
q21	5603	2455	2416	2416
q22	433	360	307	307
Total cold run time: 100628 ms
Total hot run time: 31011 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4346	4263	4250	4250
q2	q3	4528	4936	4347	4347
q4	2096	2193	1389	1389
q5	4413	4312	4330	4312
q6	225	288	197	197
q7	2035	1942	1685	1685
q8	2439	2165	2117	2117
q9	7970	7947	7941	7941
q10	4821	4772	4479	4479
q11	573	400	376	376
q12	735	754	521	521
q13	3245	3698	2932	2932
q14	300	291	295	291
q15	q16	716	742	649	649
q17	1346	1327	1314	1314
q18	7938	7409	6808	6808
q19	1128	1142	1159	1142
q20	2205	2225	2001	2001
q21	5298	4537	4419	4419
q22	533	454	402	402
Total cold run time: 56890 ms
Total hot run time: 51572 ms

hello-stephen · 2026-05-27T07:39:13Z

TPC-DS: Total hot run time: 171852 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d5d55921b0b61c67bbfb77a3f8dd0ac6dc417e3, data reload: false
query5	4355	674	524	524
query6	321	234	204	204
query7	4254	559	307	307
query8	326	238	226	226
query9	8804	4010	3991	3991
query10	440	361	296	296
query11	5786	2578	2278	2278
query12	184	129	130	129
query13	1282	621	446	446
query14	6168	5452	5163	5163
query14_1	4486	4486	4482	4482
query15	211	206	185	185
query16	1014	455	430	430
query17	1134	722	576	576
query18	2658	481	372	372
query19	215	201	162	162
query20	138	133	130	130
query21	217	136	112	112
query22	13619	13637	13342	13342
query23	17150	16607	16250	16250
query23_1	16261	16364	16241	16241
query24	7401	1775	1265	1265
query24_1	1340	1319	1285	1285
query25	528	461	419	419
query26	837	327	178	178
query27	2710	603	333	333
query28	4436	1952	1935	1935
query29	926	640	505	505
query30	302	236	202	202
query31	1130	1065	944	944
query32	99	79	76	76
query33	582	365	313	313
query34	1174	1146	643	643
query35	778	804	715	715
query36	1414	1395	1273	1273
query37	150	114	91	91
query38	3241	3170	3163	3163
query39	952	924	898	898
query39_1	897	893	881	881
query40	229	151	127	127
query41	71	72	68	68
query42	109	112	110	110
query43	331	330	302	302
query44 query45	216	208	203	203
query46	1118	1215	782	782
query47	2426	2457	2261	2261
query48	433	418	318	318
query49	627	501	410	410
query50	1034	351	255	255
query51	4368	4463	4282	4282
query52	108	106	95	95
query53	260	279	202	202
query54	323	288	263	263
query55	96	98	88	88
query56	319	315	309	309
query57	1452	1439	1342	1342
query58	307	283	278	278
query59	1602	1700	1469	1469
query60	331	342	316	316
query61	185	181	181	181
query62	706	657	567	567
query63	245	208	238	208
query64	1932	833	679	679
query65 query66	1621	499	382	382
query67	29759	29601	29627	29601
query68 query69	460	336	303	303
query70	1043	1018	984	984
query71	318	277	272	272
query72	2924	2667	2354	2354
query73	835	764	453	453
query74	5135	4966	4772	4772
query75	2698	2603	2268	2268
query76	2320	1130	771	771
query77	400	387	334	334
query78	12436	12636	11939	11939
query79	1599	1078	747	747
query80	1280	545	460	460
query81	533	283	238	238
query82	956	163	158	158
query83	317	271	242	242
query84	261	145	110	110
query85	915	526	445	445
query86	460	363	293	293
query87	3431	3376	3229	3229
query88	3628	2721	2736	2721
query89	450	387	354	354
query90	1883	183	171	171
query91	177	166	137	137
query92	83	78	72	72
query93	1652	1404	947	947
query94	720	360	312	312
query95	686	490	334	334
query96	1042	782	363	363
query97	2762	2744	2648	2648
query98	238	231	224	224
query99	1182	1148	1044	1044
Total cold run time: 253967 ms
Total hot run time: 171852 ms

hello-stephen · 2026-05-27T09:36:45Z

FE Regression Coverage Report

Increment line coverage 1.64% (1/61) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-05-27T09:59:25Z

FE UT Coverage Report

Increment line coverage 50.00% (12/24) 🎉
Increment coverage report
Complete coverage report

deardeng

LGTM

github-actions · 2026-05-28T08:18:30Z

PR approved by at least one committer and no changes requested.

mymeiyi · 2026-06-11T02:01:43Z

run buildall

hello-stephen · 2026-06-11T03:47:07Z

FE UT Coverage Report

Increment line coverage 27.27% (6/22) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-06-11T04:10:59Z

TPC-H: Total hot run time: 29257 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cec9f2acf5f2028d52d55e0e21cdbf49f501db91, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17772	4158	4206	4158
q2	q3	10779	1448	803	803
q4	4681	465	338	338
q5	7516	885	574	574
q6	182	178	137	137
q7	761	844	621	621
q8	9813	1718	1563	1563
q9	7011	4525	4500	4500
q10	6811	1801	1503	1503
q11	433	270	254	254
q12	654	433	302	302
q13	18153	3469	2795	2795
q14	272	257	242	242
q15	q16	819	764	711	711
q17	1158	1035	1035	1035
q18	6804	5659	5411	5411
q19	1314	1409	1067	1067
q20	523	405	258	258
q21	6057	2735	2670	2670
q22	449	380	315	315
Total cold run time: 101962 ms
Total hot run time: 29257 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	5132	4839	4843	4839
q2	q3	5088	5154	4622	4622
q4	2145	2226	1403	1403
q5	4911	4865	4794	4794
q6	241	188	140	140
q7	1841	1766	1549	1549
q8	2677	2139	2044	2044
q9	7490	7491	7454	7454
q10	4754	4661	4225	4225
q11	546	417	384	384
q12	741	741	535	535
q13	3096	3459	2802	2802
q14	270	278	250	250
q15	q16	680	697	615	615
q17	1303	1287	1272	1272
q18	7520	6843	6865	6843
q19	1148	1091	1107	1091
q20	2237	2225	1986	1986
q21	5347	4709	4518	4518
q22	533	475	412	412
Total cold run time: 57700 ms
Total hot run time: 51778 ms

hello-stephen · 2026-06-11T04:22:01Z

TPC-DS: Total hot run time: 168992 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cec9f2acf5f2028d52d55e0e21cdbf49f501db91, data reload: false
query5	4320	608	485	485
query6	442	189	167	167
query7	5030	530	300	300
query8	377	213	188	188
query9	8752	4041	4051	4041
query10	449	312	260	260
query11	5955	2335	2141	2141
query12	161	102	97	97
query13	1301	619	425	425
query14	6417	5378	5053	5053
query14_1	4416	4416	4407	4407
query15	209	198	181	181
query16	1025	463	427	427
query17	1140	728	603	603
query18	2643	473	351	351
query19	201	188	148	148
query20	112	109	105	105
query21	219	146	124	124
query22	13628	13583	13450	13450
query23	17426	16552	16174	16174
query23_1	16280	16274	16250	16250
query24	7556	1793	1281	1281
query24_1	1303	1313	1328	1313
query25	565	454	395	395
query26	1363	306	161	161
query27	2674	587	340	340
query28	4487	2052	2028	2028
query29	1096	637	501	501
query30	312	239	199	199
query31	1134	1071	977	977
query32	107	62	63	62
query33	540	323	271	271
query34	1192	1180	646	646
query35	752	806	724	724
query36	1372	1411	1274	1274
query37	157	113	95	95
query38	3238	3187	3112	3112
query39	962	956	947	947
query39_1	926	941	904	904
query40	219	121	98	98
query41	65	64	61	61
query42	96	94	95	94
query43	326	330	285	285
query44 query45	190	182	176	176
query46	1068	1210	756	756
query47	2384	2348	2256	2256
query48	418	412	301	301
query49	637	459	346	346
query50	975	351	267	267
query51	4341	4400	4257	4257
query52	88	89	78	78
query53	240	264	184	184
query54	264	226	205	205
query55	81	75	70	70
query56	230	218	202	202
query57	1418	1408	1303	1303
query58	235	215	211	211
query59	1602	1657	1431	1431
query60	308	222	224	222
query61	156	149	154	149
query62	702	645	569	569
query63	237	183	190	183
query64	2486	788	614	614
query65 query66	1763	452	339	339
query67	29790	29729	29482	29482
query68 query69	407	308	271	271
query70	963	983	954	954
query71	301	223	211	211
query72	3042	2628	2303	2303
query73	806	727	434	434
query74	5129	4952	4761	4761
query75	2646	2577	2226	2226
query76	2315	1134	806	806
query77	369	370	272	272
query78	12560	12414	11816	11816
query79	1417	1124	789	789
query80	1291	468	374	374
query81	532	286	260	260
query82	637	160	118	118
query83	336	272	246	246
query84 query85	910	516	423	423
query86	429	301	289	289
query87	3387	3385	3177	3177
query88	3633	2771	2709	2709
query89	421	380	327	327
query90	1916	186	176	176
query91	173	156	132	132
query92	67	61	59	59
query93	1585	1417	880	880
query94	701	362	312	312
query95	688	374	437	374
query96	1095	788	311	311
query97	2702	2702	2570	2570
query98	212	209	205	205
query99	1139	1188	1035	1035
Total cold run time: 252721 ms
Total hot run time: 168992 ms

mymeiyi · 2026-06-11T06:43:04Z

run nonConcurrent

hello-stephen · 2026-06-11T09:05:26Z

FE Regression Coverage Report

Increment line coverage 2.67% (2/75) 🎉
Increment coverage report
Complete coverage report

…ry with -230

mymeiyi · 2026-06-30T07:11:15Z

run buildall

mymeiyi · 2026-06-30T07:25:14Z

run feut

hello-stephen · 2026-06-30T08:52:59Z

TPC-H: Total hot run time: 29450 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a66639465c5fc0df8b63b199dfccfca6201d15b3, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17674	3979	4000	3979
q2	2036	329	192	192
q3	10305	1483	836	836
q4	4681	470	353	353
q5	7514	992	596	596
q6	177	166	134	134
q7	800	859	636	636
q8	9366	1640	1759	1640
q9	5718	4451	4463	4451
q10	6904	1790	1557	1557
q11	455	286	247	247
q12	625	427	303	303
q13	18120	3404	2792	2792
q14	260	269	248	248
q15	q16	790	789	719	719
q17	1022	1010	922	922
q18	6951	6057	5701	5701
q19	1322	1204	1141	1141
q20	502	408	293	293
q21	6015	2713	2413	2413
q22	440	372	297	297
Total cold run time: 101677 ms
Total hot run time: 29450 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4315	4239	4218	4218
q2	289	317	221	221
q3	4614	4959	4461	4461
q4	2036	2138	1378	1378
q5	4482	4290	4275	4275
q6	233	179	127	127
q7	1739	1851	1920	1851
q8	2579	2200	2249	2200
q9	8100	8344	7839	7839
q10	4845	4748	4269	4269
q11	592	418	372	372
q12	760	767	535	535
q13	3297	3496	3002	3002
q14	297	287	289	287
q15	q16	707	730	642	642
q17	1368	1321	1331	1321
q18	7957	7360	7264	7264
q19	1190	1132	1113	1113
q20	2217	2200	1935	1935
q21	5238	4554	4460	4460
q22	503	454	399	399
Total cold run time: 57358 ms
Total hot run time: 52169 ms

hello-stephen · 2026-06-30T08:59:17Z

FE UT Coverage Report

Increment line coverage 27.27% (6/22) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-06-30T09:03:59Z

TPC-DS: Total hot run time: 173423 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a66639465c5fc0df8b63b199dfccfca6201d15b3, data reload: false
query5	4327	648	493	493
query6	442	185	173	173
query7	4831	575	313	313
query8	332	182	163	163
query9	8750	4091	4123	4091
query10	464	314	261	261
query11	5903	2365	2149	2149
query12	163	102	102	102
query13	1268	621	476	476
query14	6259	5360	4992	4992
query14_1	4331	4310	4334	4310
query15	215	203	182	182
query16	1008	464	451	451
query17	1135	750	590	590
query18	2445	484	357	357
query19	219	188	151	151
query20	124	111	110	110
query21	237	148	124	124
query22	13509	13589	13405	13405
query23	17255	16502	16189	16189
query23_1	16377	16223	16327	16223
query24	7666	1794	1317	1317
query24_1	1310	1325	1290	1290
query25	565	459	393	393
query26	1299	308	177	177
query27	2657	592	355	355
query28	4433	2075	2044	2044
query29	1112	634	499	499
query30	307	242	207	207
query31	1150	1081	935	935
query32	131	67	61	61
query33	532	322	274	274
query34	1201	1118	650	650
query35	774	780	665	665
query36	1421	1411	1239	1239
query37	197	103	90	90
query38	1898	1714	1669	1669
query39	920	929	889	889
query39_1	879	867	872	867
query40	250	119	114	114
query41	66	66	63	63
query42	91	90	89	89
query43	319	325	282	282
query44	1453	785	782	782
query45	202	197	185	185
query46	1115	1173	757	757
query47	2363	2402	2301	2301
query48	408	400	289	289
query49	582	423	317	317
query50	1006	356	260	260
query51	4472	4451	4354	4354
query52	80	80	69	69
query53	254	265	189	189
query54	266	219	218	218
query55	74	69	67	67
query56	231	234	211	211
query57	1465	1414	1342	1342
query58	248	217	212	212
query59	1550	1654	1409	1409
query60	289	247	235	235
query61	158	154	145	145
query62	708	656	582	582
query63	232	184	187	184
query64	2535	763	590	590
query65	4845	4788	4774	4774
query66	1804	459	330	330
query67	30003	29728	29701	29701
query68	3082	1652	949	949
query69	420	303	281	281
query70	1099	973	974	973
query71	289	232	215	215
query72	2953	2668	2356	2356
query73	847	823	443	443
query74	5113	4952	4848	4848
query75	2599	2534	2186	2186
query76	2316	1189	787	787
query77	356	400	294	294
query78	12503	12501	12081	12081
query79	1429	1189	781	781
query80	1274	470	395	395
query81	523	286	239	239
query82	1147	165	118	118
query83	341	277	255	255
query84	262	147	115	115
query85	931	540	418	418
query86	460	294	290	290
query87	1833	1831	1772	1772
query88	3728	2860	2816	2816
query89	441	392	338	338
query90	1920	184	176	176
query91	176	163	134	134
query92	66	61	54	54
query93	1608	1576	992	992
query94	795	372	303	303
query95	673	485	344	344
query96	1143	797	343	343
query97	2730	2717	2571	2571
query98	218	204	202	202
query99	1188	1157	1037	1037
Total cold run time: 259859 ms
Total hot run time: 173423 ms

hello-stephen · 2026-06-30T09:08:55Z

ClickBench: Total hot run time: 25.27 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a66639465c5fc0df8b63b199dfccfca6201d15b3, data reload: false
query1	0.01	0.01	0.00
query2	0.10	0.05	0.05
query3	0.26	0.13	0.13
query4	1.60	0.13	0.14
query5	0.24	0.23	0.23
query6	1.27	1.11	1.06
query7	0.04	0.01	0.01
query8	0.05	0.04	0.04
query9	0.37	0.31	0.30
query10	0.58	0.56	0.57
query11	0.20	0.15	0.14
query12	0.18	0.15	0.14
query13	0.46	0.46	0.49
query14	1.01	1.01	0.98
query15	0.61	0.59	0.60
query16	0.34	0.34	0.32
query17	1.12	1.12	1.07
query18	0.22	0.20	0.21
query19	2.03	1.99	2.00
query20	0.01	0.01	0.01
query21	15.43	0.22	0.14
query22	4.70	0.05	0.05
query23	16.14	0.30	0.12
query24	2.97	0.43	0.31
query25	0.13	0.06	0.04
query26	0.73	0.21	0.16
query27	0.04	0.05	0.04
query28	3.53	0.94	0.53
query29	12.49	4.30	3.45
query30	0.29	0.15	0.15
query31	2.78	0.60	0.32
query32	3.22	0.61	0.49
query33	3.29	3.19	3.25
query34	15.72	4.28	3.53
query35	3.49	3.52	3.52
query36	0.56	0.43	0.44
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.19	0.16	0.16
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 96.75 s
Total hot run time: 25.27 s

deardeng

LGTM

github-actions · 2026-06-30T12:14:28Z

PR approved by at least one committer and no changes requested.

mymeiyi · 2026-06-30T12:27:47Z

/review

github-actions

Review completed for PR 63721.

I am not adding new inline comments in this pass. The only substantive correctness problem I could substantiate is already covered by the existing inline thread on StmtExecutor for SQL-level SET_VAR hints overriding the retry attempt's temporary zero TTL before cloud visible-version lookup, so duplicating it here would add noise. The prior INFO-log concern is stale against the current head because the helper now assigns the TTL fields directly and restores them in finally; the remaining regression future-name typo is already covered by an existing thread.

Critical checkpoints:

Goal and scope: the change targets E-230 query retry in cloud mode by temporarily bypassing cloud table/partition visible-version caches for retry attempts, plus unit/regression coverage.
Focus and size: the code is narrowly scoped to StmtExecutor, one FE unit test, and the cloud retry regression.
Session/config behavior: retry TTL restoration is covered for ordinary session SET values, but the existing SET_VAR inline thread remains the important unresolved path.
Concurrency/lifecycle: no new shared concurrent state or lifecycle owner was introduced; the mutation is confined to the connection session variable and restored in a finally block.
Compatibility/parallel paths: cloud partition and table cache readers were checked; no additional non-cloud or parallel planner path issue was found beyond the existing SET_VAR thread.
Tests: added FE unit coverage for shouldDisableCloudVersionCacheOnRetry and a cloud regression path that checks restored TTLs and visible row count. Local FE/regression execution was not run in this checkout because thirdparty/installed/bin/protoc is absent.
Performance/observability: no separate performance issue found; logging is lightweight and the stale log concern from the old implementation no longer applies.

Subagent conclusions: optimizer-rewrite and tests-session-config both completed focused passes and then both returned NO_NEW_VALUABLE_FINDINGS in final convergence round 1 for the current ledger/comment set. No subagent candidates became new inline comments; duplicates/stale points were merged in the shared ledger.

User focus: no additional user-provided focus points were present.

dimiss

…ry with -230 (#63721) If a query get E-230 error and `cloud_partition_version_cache_ttl_ms` is not set to 0, this pr set the session var to 0 temporarily to get the newest version.

… retry a query with -230 #63721 (#65048) Cherry-picked from #63721 Co-authored-by: meiyi <meiyi@selectdb.com>

… retry a query with -230 (#63721) (#66142) pick #63721

CopilotAI review requested due to automatic review settings May 27, 2026 06:21

Copilotstarted reviewing on behalf of mymeiyi May 27, 2026 06:22 View session

CopilotAI reviewed May 27, 2026
View reviewed changes

Comment threadregression-test/suites/cloud_p0/query_retry/test_retry_e-230.groovy
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java Outdated

github-actionsBot reviewed May 27, 2026
View reviewed changes

github-actionsBot previously requested changes May 27, 2026
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java

deardeng previously approved these changes May 28, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 28, 2026

mymeiyi dismissed deardeng’s stale review via cec9f2aJune 10, 2026 10:49

mymeiyi force-pushed the fix-fe-230 branch from 8d5d559 to cec9f2aCompare June 10, 2026 10:49

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jun 10, 2026

gavinchou added dev/3.1.x dev/4.0.x dev/4.1.x labels Jun 30, 2026

gavinchou previously approved these changes Jun 30, 2026
View reviewed changes

mymeiyi dismissed gavinchou’s stale review via 994fdceJune 30, 2026 07:05

mymeiyi force-pushed the fix-fe-230 branch from cec9f2a to 994fdceCompare June 30, 2026 07:05

[fix](fe) set cloud version_cache_ttl to 0 temporarily if retry a que…
a666394
…ry with -230

mymeiyi force-pushed the fix-fe-230 branch from 994fdce to a666394Compare June 30, 2026 07:07

deardeng approved these changes Jun 30, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2026

github-actionsBot reviewed Jun 30, 2026
View reviewed changes

mymeiyi merged commit c23c991 into apache:masterJun 30, 2026
32 of 33 checks passed

github-actionsBot added the dev/4.0.x-conflict label Jun 30, 2026

github-actionsBot mentioned this pull request Jun 30, 2026
branch-4.1: [fix](fe) set cloud version_cache_ttl to 0 temporarily if retry a query with -230 #63721 #65048
Merged

yiguolei pushed a commit that referenced this pull request Jul 1, 2026
branch-4.1: [fix](fe) set cloud version_cache_ttl to 0 temporarily if…
5d0b249
… retry a query with -230 #63721 (#65048) Cherry-picked from #63721 Co-authored-by: meiyi <meiyi@selectdb.com>

yiguolei added dev/4.1.3-merged and removed dev/4.1.x labels Jul 1, 2026

yiguolei mentioned this pull request Jul 7, 2026
4.1.3 Release Note #65306
Closed

mymeiyi mentioned this pull request Jul 28, 2026
branch-4.0: [fix](fe) set cloud version_cache_ttl to 0 temporarily if retry a query with -230 (#63721) #66142
Merged

morningman pushed a commit that referenced this pull request Jul 29, 2026
branch-4.0: [fix](fe) set cloud version_cache_ttl to 0 temporarily if…
91eec7e
… retry a query with -230 (#63721) (#66142) pick #63721

morningman added dev/4.0.8-merged and removed dev/4.0.x dev/4.0.x-conflict labels Jul 29, 2026

morningman mentioned this pull request Aug 11, 2026
4.0.8 Release Notes #66642
Open

gavinchou removed the dev/3.1.x label Aug 13, 2026

Uh oh!

Conversation

mymeiyi commented May 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hello-stephen commented May 27, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

mymeiyi commented May 27, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

mymeiyi commented May 27, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mymeiyi commented May 27, 2026

Uh oh!

hello-stephen commented May 27, 2026

Uh oh!

hello-stephen commented May 27, 2026

Uh oh!

hello-stephen commented May 27, 2026

FE Regression Coverage Report

Uh oh!

hello-stephen commented May 27, 2026

FE UT Coverage Report

Uh oh!

deardeng left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

mymeiyi commented Jun 11, 2026

Uh oh!

hello-stephen commented Jun 11, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jun 11, 2026

Uh oh!

hello-stephen commented Jun 11, 2026

Uh oh!

mymeiyi commented Jun 11, 2026

Uh oh!

hello-stephen commented Jun 11, 2026

FE Regression Coverage Report

Uh oh!

mymeiyi commented Jun 30, 2026

Uh oh!

mymeiyi commented Jun 30, 2026

Uh oh!

hello-stephen commented Jun 30, 2026

Uh oh!

hello-stephen commented Jun 30, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jun 30, 2026

Uh oh!

hello-stephen commented Jun 30, 2026

Uh oh!

deardeng left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jun 30, 2026

Uh oh!

mymeiyi commented Jun 30, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mymeiyi commented May 27, 2026•
edited
Loading