Skip to content

[branch-4.0][fix](parquet) Fix wrong encoding for parquet page v2 #63305 - #63738

Merged
morningman merged 3 commits into
apache:branch-4.0from
Gabriel39:backport-63305-branch-4.0
May 28, 2026
Merged

[branch-4.0][fix](parquet) Fix wrong encoding for parquet page v2 #63305#63738
morningman merged 3 commits into
apache:branch-4.0from
Gabriel39:backport-63305-branch-4.0

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented May 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

pick #63305

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented May 27, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 28, 2026
@github-actions

github-actionsBot commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@Gabriel39Gabriel39 changed the title Backport 63305 branch 4.0[fix](parquet) Fix wrong encoding for parquet page v2 #63305May 28, 2026
@Gabriel39Gabriel39 changed the title [fix](parquet) Fix wrong encoding for parquet page v2 #63305[branch-4.0][fix](parquet) Fix wrong encoding for parquet page v2 #63305May 28, 2026
@Gabriel39@morningman
[fix](parquet) Fix wrong encoding for parquet page v2
8e9cbee
@Gabriel39@morningman
[test](parquet) Add page v2 encoding stats UT
1baddc1
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Add a BE unit test for rejecting Parquet DATA_PAGE_V2 chunks that contain non-dictionary data page encodings in encoding_stats.
None
- Test: Unit Test
- Added BE UT for RowGroupReader::is_dictionary_encoded DATA_PAGE_V2 encoding_stats handling. Attempted ./run-be-ut.sh --run --filter=ParquetThriftReaderTest.is_dictionary_encoded_rejects_plain_data_page_v2, but local environment has JAVA_HOME on JDK 11 and run-be-ut.sh requires JDK 17. Attempted build-support/clang-format.sh, but local environment lacks llvm@16.
- Behavior changed: No
- Does this need documentation: No
@Gabriel39@morningman
update
f63ac72
@morningman
morningmanforce-pushed the backport-63305-branch-4.0 branch from 61a0c16 to f63ac72CompareMay 28, 2026 02:44
@morningman

morningman commented May 28, 2026

Copy link
Copy Markdown
Contributor

run buildall

@morningman
morningman merged commit e12cce8 into apache:branch-4.0May 28, 2026
25 of 29 checks passed
@hello-stephen

hello-stephen commented May 28, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.52% (25530/35695)
Line Coverage54.35% (270442/497602)
Region Coverage51.76% (223279/431395)
Branch Coverage53.25% (96198/180665)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@yiguoleiyiguoleiAwaiting requested review from yiguolei

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gabriel39@hello-stephen@morningman