Skip to content

[fix](deps) change lzo download link - #63785

Merged
morningman merged 1 commit into
apache:masterfrom
morningman:fix-3rd-lzo
Jun 4, 2026
Merged

[fix](deps) change lzo download link#63785
morningman merged 1 commit into
apache:masterfrom
morningman:fix-3rd-lzo

Conversation

@morningman

Copy link
Copy Markdown
Contributor

the old one is invalid

@morningman

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.93% (20955/38855)
Line Coverage37.49% (198619/529763)
Region Coverage33.78% (155649/460771)
Branch Coverage34.78% (67773/194875)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.80% (28082/38054)
Line Coverage57.73% (305058/528407)
Region Coverage54.74% (254664/465186)
Branch Coverage56.38% (110288/195601)

@morningman

Copy link
Copy Markdown
ContributorAuthor

/review

@github-actions

Copy link
Copy Markdown
Contributor

OpenCode automated review failed and did not complete.

Error: Error: Token refresh failed: 401
Workflow run: https://github.com/apache/doris/actions/runs/26679173876

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@morningman

Copy link
Copy Markdown
ContributorAuthor

/review

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found. The PR replaces the LZO2 archive URL with the upstream oberhumer download URL; the new URL is reachable in this runner and the downloaded content matches the existing MD5 . The old fossies URL returns 401 here, so the change addresses the dependency download failure without changing the selected archive.

Critical checkpoint conclusions:

  • Goal and proof: The goal is to fix the LZO2 dependency download link. The URL fetch and checksum verification prove the new link supplies the same archive.
  • Scope: The change is minimal and focused: one URL line, with name/source/checksum unchanged.
  • Concurrency: Not applicable; this is build/dependency metadata only.
  • Lifecycle/static initialization: Not applicable.
  • Configuration: No runtime configuration added or changed.
  • Compatibility/storage/protocol: No incompatible storage, function symbol, or FE-BE protocol change.
  • Parallel code paths: No parallel Doris runtime paths are affected; this only changes third-party source acquisition.
  • Special conditionals: None added.
  • Test coverage: No code tests are needed for a URL-only dependency fix; I manually verified URL reachability and MD5 checksum.
  • Test results: No regression files are involved.
  • Observability: Not applicable.
  • Transaction/persistence/data writes: Not applicable.
  • FE-BE variables: Not applicable.
  • Performance: Not applicable beyond dependency download reliability.
  • User focus: No additional user-provided review focus was specified.

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found. The PR replaces the LZO2 archive URL with the upstream oberhumer download URL; the new URL is reachable in this runner and the downloaded content matches the existing MD5 39d3f3f9c55c87b1e5d6888e1420f4b5. The old fossies URL returns 401 here, so the change addresses the dependency download failure without changing the selected archive.

Critical checkpoint conclusions:

  • Goal and proof: The goal is to fix the LZO2 dependency download link. The URL fetch and checksum verification prove the new link supplies the same archive.
  • Scope: The change is minimal and focused: one URL line, with name/source/checksum unchanged.
  • Concurrency: Not applicable; this is build/dependency metadata only.
  • Lifecycle/static initialization: Not applicable.
  • Configuration: No runtime configuration added or changed.
  • Compatibility/storage/protocol: No incompatible storage, function symbol, or FE-BE protocol change.
  • Parallel code paths: No parallel Doris runtime paths are affected; this only changes third-party source acquisition.
  • Special conditionals: None added.
  • Test coverage: No code tests are needed for a URL-only dependency fix; I manually verified URL reachability and MD5 checksum.
  • Test results: No regression .out files are involved.
  • Observability: Not applicable.
  • Transaction/persistence/data writes: Not applicable.
  • FE-BE variables: Not applicable.
  • Performance: Not applicable beyond dependency download reliability.
  • User focus: No additional user-provided review focus was specified.

@morningman
morningman merged commit 58c101a into apache:masterJun 4, 2026
34 checks passed
github-actionsBot pushed a commit that referenced this pull request Jun 4, 2026
yiguolei pushed a commit that referenced this pull request Jun 5, 2026
Cherry-picked from #63785
Co-authored-by: Mingyu Chen (Rayner) <yunyou@selectdb.com>
@yiguoleiyiguolei mentioned this pull request Jun 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman@hello-stephen@Gabriel39@yiguolei