Uh oh!
There was an error while loading. Please reload this page.
[fix](test) Cast variant subcolumn as json in variant_hirachinal for stable output - #63828
Conversation
…stable output cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
csun5285
commented
May 28, 2026
run buildall |
hello-stephen
commented
May 28, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
eldenmoon
commented
May 28, 2026
/review |
There was a problem hiding this comment.
I found one blocking test-stability issue. The PR's goal is to remove flaky checked output caused by cast(v['c'] as string) on heterogeneous variant values, but the same suite still has an immediately preceding checked query using that exact pattern, so the regression can remain flaky under the same fuzzed session variables.
Critical checkpoints:
- Goal/test proof: The goal is to stabilize
variant_hirachinal; current change only partially accomplishes it because one checked output still uses unstable string serialization. - Scope/focus: The code change is small and focused, but incomplete for the stated failure mode.
- Concurrency/lifecycle/config/compatibility/data writes/FE-BE variable passing: Not applicable; this is a regression-test-only change.
- Parallel paths: A parallel checked query in the same suite remains unfixed.
- Test coverage/results: Existing
.outvalues are consistent with the changedjsoncasts, but coverage remains vulnerable to the same flake in the earlierqt_sql. - Observability/performance/transactions/persistence: Not applicable.
User focus points: No additional user-provided review focus was supplied.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…stable output (#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
…stable output (#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
…stable output (apache#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
…stable output (#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)