[fix](fe) Remove decimal literal debug logs by yujun777 · Pull Request #63841 · apache/doris

yujun777 · 2026-05-28T10:39:50Z

What problem does this PR solve?

Decimal literal cast and construction paths print high-frequency INFO debug logs. In FE runtime these logs can be routed through stderr and appear as ERROR lines, flooding FE logs during normal query traffic.

The noisy logs were introduced by #50940.

This PR removes the debug logs from the decimal literal hot paths.

Check List

Test: Unit Test
- LiteralTest
Behavior changed: No
Does this need documentation: No

Remove high-frequency decimal literal INFO logs from FE cast paths to prevent normal query traffic from flooding system.err as ERROR logs. Key changes: - Remove decimal literal conversion debug log in Literal.getDecimalLiteral - Remove DecimalV3Literal construction debug log and unused logger fields Unit Test: - LiteralTest

hello-stephen · 2026-05-28T10:39:55Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yujun777 · 2026-05-28T10:39:57Z

run buildall

morrySnow · 2026-05-28T10:44:30Z

/review

github-actions · 2026-05-28T11:19:43Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-05-28T11:19:47Z

PR approved by anyone and no changes requested.

hello-stephen · 2026-05-28T11:34:15Z

TPC-H: Total hot run time: 31934 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88e486994365d87f5f7c51262223346c4e9f2126, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17848	4164	4091	4091
q2	q3	10800	1422	815	815
q4	4685	470	340	340
q5	7638	2296	2106	2106
q6	243	177	136	136
q7	972	793	639	639
q8	9359	1716	1646	1646
q9	5217	4971	4981	4971
q10	6409	2193	1926	1926
q11	438	277	250	250
q12	638	424	293	293
q13	18108	3409	2810	2810
q14	268	260	235	235
q15	q16	824	763	709	709
q17	934	955	1003	955
q18	6842	5820	5575	5575
q19	1162	1297	1106	1106
q20	586	471	320	320
q21	5660	2810	2675	2675
q22	462	441	336	336
Total cold run time: 99093 ms
Total hot run time: 31934 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	5035	4933	5012	4933
q2	q3	4971	5295	4632	4632
q4	2104	2158	1432	1432
q5	5037	4683	4775	4683
q6	247	178	132	132
q7	1938	1820	1607	1607
q8	2625	2246	2129	2129
q9	7955	7444	7484	7444
q10	4733	4691	4235	4235
q11	538	382	352	352
q12	729	739	521	521
q13	3090	3317	2846	2846
q14	269	290	268	268
q15	q16	683	702	632	632
q17	1286	1258	1268	1258
q18	7554	7071	6932	6932
q19	1082	1091	1100	1091
q20	2227	2225	1954	1954
q21	5230	4583	4511	4511
q22	506	454	399	399
Total cold run time: 57839 ms
Total hot run time: 51991 ms

github-actions

Review result: no blocking issues found.

Critical checkpoints:

Goal/test: The PR removes noisy INFO logs from decimal literal cast/construction hot paths; the diff directly accomplishes that by deleting the logger fields, imports, and log calls. The PR reports LiteralTest coverage; I did not rerun tests in this runner.
Scope/focus: The change is minimal and focused, with no unrelated code movement.
Concurrency/lifecycle: No shared state, locks, threads, or lifecycle-sensitive initialization remain affected; removing static logger fields reduces initialization surface.
Configuration/compatibility/protocol: No new config, serialization, storage, FE-BE protocol, or rolling-upgrade compatibility impact.
Parallel paths: The changed DecimalV3Literal constructor and Literal.getDecimalLiteral helper cover the noisy decimal literal creation/cast paths shown in the diff; no additional equivalent debug log in the same literal package was found.
Error handling/data correctness: No Status/exception/data visibility semantics changed; only logging side effects were removed.
Tests/results: No test result files changed; this is appropriate for a log-only removal. Existing LiteralTest coverage is sufficient for behavior preservation if it passes.
Observability: This intentionally reduces excessive INFO observability in hot paths; no critical diagnostic signal is lost because the removed messages logged normal decimal conversion details per invocation.
Performance: Removing string concatenation and INFO log calls in hot cast/construction paths is a direct performance/log-volume improvement.

User focus: No additional user-provided review focus was present.

hello-stephen · 2026-05-28T11:45:17Z

TPC-DS: Total hot run time: 172445 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 88e486994365d87f5f7c51262223346c4e9f2126, data reload: false
query5	4320	657	516	516
query6	345	225	203	203
query7	4230	634	331	331
query8	329	244	231	231
query9	8824	4121	4110	4110
query10	473	355	310	310
query11	5812	2570	2245	2245
query12	194	128	126	126
query13	1280	633	449	449
query14	6188	5482	5212	5212
query14_1	4537	4534	4502	4502
query15	219	207	187	187
query16	1029	466	472	466
query17	1163	749	616	616
query18	2739	509	366	366
query19	227	209	170	170
query20	138	134	127	127
query21	221	149	121	121
query22	13657	13595	13447	13447
query23	17496	16510	16311	16311
query23_1	16336	16335	16471	16335
query24	7549	1847	1330	1330
query24_1	1353	1332	1329	1329
query25	588	510	453	453
query26	1312	331	182	182
query27	2677	569	355	355
query28	4425	2019	2027	2019
query29	1026	648	538	538
query30	312	239	204	204
query31	1154	1091	950	950
query32	107	76	79	76
query33	579	374	315	315
query34	1179	1173	664	664
query35	804	794	707	707
query36	1404	1387	1260	1260
query37	160	110	88	88
query38	3234	3146	3098	3098
query39	925	922	881	881
query39_1	871	888	853	853
query40	226	147	128	128
query41	67	64	63	63
query42	111	109	108	108
query43	341	348	307	307
query44 query45	219	199	200	199
query46	1084	1186	779	779
query47	2373	2363	2250	2250
query48	403	428	304	304
query49	634	495	383	383
query50	981	373	253	253
query51	4420	4293	4329	4293
query52	108	105	97	97
query53	251	289	203	203
query54	308	284	259	259
query55	94	93	90	90
query56	315	313	310	310
query57	1428	1396	1329	1329
query58	314	285	279	279
query59	1646	1764	1498	1498
query60	328	330	314	314
query61	157	163	159	159
query62	704	658	589	589
query63	242	206	210	206
query64	2406	782	629	629
query65 query66	1682	495	369	369
query67	29913	29770	29637	29637
query68 query69	472	348	313	313
query70	1096	1042	981	981
query71	314	264	273	264
query72	3036	2683	2442	2442
query73	886	768	457	457
query74	5130	5020	4818	4818
query75	2699	2625	2265	2265
query76	2322	1155	767	767
query77	414	425	352	352
query78	12413	12441	11846	11846
query79	1488	1068	753	753
query80	658	526	469	469
query81	464	282	244	244
query82	1370	162	123	123
query83	375	288	248	248
query84	264	144	112	112
query85	899	529	464	464
query86	398	353	319	319
query87	3468	3438	3241	3241
query88	3681	2742	2717	2717
query89	443	407	348	348
query90	1987	188	192	188
query91	178	171	142	142
query92	82	78	73	73
query93	1481	1445	947	947
query94	549	371	320	320
query95	695	378	357	357
query96	1103	816	351	351
query97	2731	2766	2628	2628
query98	234	225	226	225
query99	1139	1185	1039	1039
Total cold run time: 255617 ms
Total hot run time: 172445 ms

hello-stephen · 2026-05-28T14:14:59Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/32) 🎉
Increment coverage report
Complete coverage report

yujun777 · 2026-05-28T15:37:11Z

run feut

hello-stephen · 2026-05-28T17:03:41Z

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

### What problem does this PR solve? Decimal literal cast and construction paths print high-frequency INFO debug logs. In FE runtime these logs can be routed through stderr and appear as ERROR lines, flooding FE logs during normal query traffic. The noisy logs were introduced by #50940. This PR removes the debug logs from the decimal literal hot paths. ### Check List - Test: Unit Test - LiteralTest - Behavior changed: No - Does this need documentation: No

### What problem does this PR solve? Decimal literal cast and construction paths print high-frequency INFO debug logs. In FE runtime these logs can be routed through stderr and appear as ERROR lines, flooding FE logs during normal query traffic. The noisy logs were introduced by apache#50940. This PR removes the debug logs from the decimal literal hot paths. ### Check List - Test: Unit Test - LiteralTest - Behavior changed: No - Does this need documentation: No

Cherry-picked from #63841 Co-authored-by: yujun <yujun@selectdb.com>

morrySnow approved these changes May 28, 2026
View reviewed changes

morrySnow added dev/4.0.x dev/4.1.x labels May 28, 2026

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 28, 2026

github-actionsBot added the reviewed label May 28, 2026

github-actionsBot reviewed May 28, 2026
View reviewed changes

morrySnow merged commit 2570dd8 into apache:masterMay 29, 2026
35 checks passed

github-actionsBot mentioned this pull request May 29, 2026
branch-4.0: [fix](fe) Remove decimal literal debug logs #63841 #63879
Merged

github-actionsBot mentioned this pull request May 29, 2026
branch-4.1: [fix](fe) Remove decimal literal debug logs #63841 #63880
Merged

yiguolei pushed a commit that referenced this pull request Jun 4, 2026
branch-4.1: [fix](fe) Remove decimal literal debug logs#63841(#63880)
dc49f22
Cherry-picked from #63841 Co-authored-by: yujun <yujun@selectdb.com>

yiguolei added dev/4.1.2-merged and removed dev/4.1.x labels Jun 4, 2026

morningman pushed a commit that referenced this pull request Jun 30, 2026
branch-4.0: [fix](fe) Remove decimal literal debug logs#63841(#63879)
ce8af3d
Cherry-picked from #63841 Co-authored-by: yujun <yujun@selectdb.com>

morningman added dev/4.0.7-merged and removed dev/4.0.x labels Jun 30, 2026

Navigation Menu

Uh oh!

[fix](fe) Remove decimal literal debug logs - #63841

[fix](fe) Remove decimal literal debug logs#63841
morrySnow merged 1 commit into
apache:masterfrom
yujun777:fix-decimal-literal-log-spam

yujun777 commented May 28, 2026•
edited
Loading

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

yujun777 commented May 28, 2026

Uh oh!

morrySnow commented May 28, 2026

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

github-actionsBot left a comment

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

yujun777 commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

yujun777 commented May 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

yujun777 commented May 28, 2026

Uh oh!

morrySnow commented May 28, 2026

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

hello-stephen commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

FE Regression Coverage Report

Uh oh!

yujun777 commented May 28, 2026

Uh oh!

hello-stephen commented May 28, 2026

FE UT Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yujun777 commented May 28, 2026•
edited
Loading