Skip to content

branch-4.0: [fix](fe) Skip dropped columns in follower stats sync #63882 - #63947

Merged
morningman merged 1 commit into
apache:branch-4.0from
yujun777:branch-4.0-pick-63882
Jun 26, 2026
Merged

branch-4.0: [fix](fe) Skip dropped columns in follower stats sync #63882#63947
morningman merged 1 commit into
apache:branch-4.0from
yujun777:branch-4.0-pick-63882

Conversation

@yujun777

@yujun777yujun777 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

cherry-pick: #63882

@hello-stephen

hello-stephen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777

yujun777 commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yujun777

yujun777 commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@yujun777

yujun777 commented Jun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

run nonConcurrent

@morningman
morningmanforce-pushed the branch-4.0-pick-63882 branch from 3b18692 to 4bdc131CompareJune 24, 2026 10:45
@morningman

morningman commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2026
@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉
Increment coverage report
Complete coverage report

@yujun777@morningman
[fix](fe) Skip dropped columns in follower stats sync (apache#63882)
fb7ad23
### What problem does this PR solve?
FollowerColumnSender drains queued column references on follower FEs and
syncs the columns that still need analysis to the master. A queued
column can become stale after DDL changes. If the table still exists but
the queued column has been dropped, table.getColumn(column.colName)
returns null and the sender throws a NullPointerException while reading
the type.
This patch skips dropped columns before checking the column type, so the
daemon does not emit periodic ERROR logs and can continue processing the
remaining queued columns.
@morningman
morningmanforce-pushed the branch-4.0-pick-63882 branch from 4bdc131 to fb7ad23CompareJune 26, 2026 01:52
@morningman

morningman commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉
Increment coverage report
Complete coverage report

@morningman
morningman merged commit ab5c1cc into apache:branch-4.0Jun 26, 2026
26 of 29 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@yiguoleiyiguoleiAwaiting requested review from yiguolei

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yujun777@hello-stephen@morningman