Skip to content

branch-4.0: [opt](memory) optimize row-store memtable flush memory in the row-store scenario - #64056

Merged
morningman merged 2 commits into
apache:branch-4.0from
sollhui:4.0_pick_63342
Jun 11, 2026
Merged

branch-4.0: [opt](memory) optimize row-store memtable flush memory in the row-store scenario#64056
morningman merged 2 commits into
apache:branch-4.0from
sollhui:4.0_pick_63342

Conversation

@sollhui

@sollhuisollhui commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

pick #63342

@sollhui
sollhui requested a review from morningman as a code ownerJune 3, 2026 06:20
@sollhui

sollhui commented Jun 3, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.48% (86/92) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.56% (25549/35705)
Line Coverage54.38% (270612/497673)
Region Coverage51.92% (224065/431559)
Branch Coverage53.45% (96618/180780)

@sollhui
[chore](be) Format vertical segment writer declaration
c1aa311
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Fix a clang-format style issue in vertical_segment_writer.h by keeping row_pos and num_rows on the same declaration line and wrapping cid to the next line.
### Release note
None
### Check List (For Author)
- Test: build-support/check-format.sh
- No need to test (format-only change)
- Behavior changed: No
- Does this need documentation: No
@sollhui

sollhui commented Jun 9, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 29.35% (27/92) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.25% (19423/36474)
Line Coverage36.40% (181458/498571)
Region Coverage33.00% (140984/427251)
Branch Coverage33.88% (61029/180158)

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.48% (86/92) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.47% (25520/35706)
Line Coverage54.31% (270283/497677)
Region Coverage52.02% (224491/431561)
Branch Coverage53.34% (96432/180780)

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.48% (86/92) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.47% (25519/35706)
Line Coverage54.31% (270301/497677)
Region Coverage52.04% (224590/431561)
Branch Coverage53.35% (96442/180780)

@morningman
morningman merged commit 3fe1140 into apache:branch-4.0Jun 11, 2026
28 of 31 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sollhui@hello-stephen@morningman