Uh oh!
There was an error while loading. Please reload this page.
[branch-4.1](compaction) remove single replica compaction (#63771) - #64061
Merged
Conversation
hello-stephen
commented
Jun 3, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
csun5285
commented
Jun 3, 2026
ContributorAuthor
run buildall |
csun5285force-pushed
the
pick-63771-branch-4.1
branch
from
June 3, 2026 07:31
0f7804e to
f03cea1Comparecsun5285
commented
Jun 3, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
Jun 3, 2026
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 3, 2026
Contributor
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Jun 3, 2026
Contributor
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Jun 3, 2026
Contributor
FE Regression Coverage ReportIncrement line coverage |
Remove the single replica compaction (SRC) feature end-to-end across BE, FE and regression tests. Doc: apache/doris-website#3870 ### Why remove it The main reason is **correctness risk in peer selection**. A follower replica had to pick a peer holding a "proper" version (`_find_rowset_to_fetch`) and fetch its compacted result, based on replica info that was only refreshed periodically. Because replicas progress through versions independently and this "leader" selection ran against a stale, time-sensitive view of the cluster, the hoice of which peer to fetch from — and which version — was racy and could select a peer whose state no longer matched, leading to subtle inconsistencies.
csun5285force-pushed
the
pick-63771-branch-4.1
branch
from
June 3, 2026 14:35
f03cea1 to
9d24026Compareyiguolei
commented
Jun 4, 2026
Contributor
skip buildall |
yiguolei
approved these changes
Jun 4, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from master #63771