Skip to content

[Feature] Support exact percentile aggregate function - #6410

Merged
morningman merged 8 commits into
apache:masterfrom
e0c9:support-percentile-accurate
Aug 18, 2021
Merged

[Feature] Support exact percentile aggregate function#6410
morningman merged 8 commits into
apache:masterfrom
e0c9:support-percentile-accurate

Conversation

@e0c9

@e0c9e0c9 commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Proposed changes

Support to calculate the exact percentile value array of numeric column col at the given percentage(s).

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix[Feature] Support exact percentile aggregate function #6419) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

@EmmyMiao87

Copy link
Copy Markdown
Contributor

Please add a issue, Explain roughly the requirements and design

@e0c9

e0c9 commented Aug 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Please add a issue, Explain roughly the requirements and design

I have created an issue.

@e0c9e0c9 changed the title Support exact percentile aggregate function[Feature] Support exact percentile aggregate functionAug 10, 2021
Comment threadbe/src/util/counts.h Outdated
Comment threadbe/src/util/counts.h Outdated
Comment threadbe/src/exprs/aggregate_functions.cpp Outdated

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please doc of this function

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature. labels Aug 16, 2021
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2021
@morningman
morningman merged commit 66a7a4b into apache:masterAug 18, 2021
@morningmanmorningman mentioned this pull request Oct 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/sql/functionIssues or PRs related to the SQL functionskind/featureCategorizes issue or PR as related to a new feature.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support exact percentile aggregate function

4 participants

@e0c9@EmmyMiao87@morningman@HappenLee