Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [fix](filecache) exclude warmup reads from file cache hit ratio metrics(pick#63394) - #64232
Merged
morningman merged 2 commits intoJun 24, 2026
Conversation
hello-stephen
commented
Jun 8, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
freemandealer
commented
Jun 8, 2026
MemberAuthor
run buildall |
Issue Number: N/A Related PR: N/A Problem Summary: File cache hit ratio metrics are derived from global file cache read bytes, but warmup reads from manual warmup, periodic warmup, event-driven warmup, and rebalance-triggered warmup used to update the same counters as query reads. This polluted the query hit ratio. Mixed hit/miss reads could also be attributed to one source for the whole request. This change skips warmup updates to global file cache read metrics while preserving per-IOContext profile stats, records local/remote/peer bytes by actual returned bytes, and avoids updating metrics for failed reads. It also fixes direct-read partial continuation and no-warmup miss-only hit ratio refresh. After rebase, the warmup metrics UT exposed a separate ASAN issue because the test snapshot helper triggered all metric hooks, including a stale StorageEngine hook that captured a destroyed engine. The test now snapshots FileCacheMetrics directly, and StorageEngine deregisters its hook on destruction. File cache hit ratio metrics now exclude warmup reads. - Test: Regression test / Unit Test - Unit Test: DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 sh run-be-ut.sh --run --filter=BlockFileCacheTest.cached_remote_file_reader_warmup_does_not_update_global_metrics - Unit Test: DORIS_TOOLCHAIN=clang DISABLE_BE_JAVA_EXTENSIONS=ON ENABLE_INJECTION_POINT=ON ENABLE_CACHE_LOCK_DEBUG=0 ENABLE_PCH=0 sh run-be-ut.sh --run --filter='BlockFileCacheTest.cached_remote_file_reader*' - Behavior changed: Yes. Warmup reads no longer contribute to global file cache read metrics used for query hit ratio; per-IOContext profile stats are preserved. - Does this need documentation: No Picked from: apache#63394
freemandealerforce-pushed
the
pick-branch-4.0-pr-63394
branch
from
June 9, 2026 03:11
d98af62 to
b30ed19Comparefreemandealer
commented
Jun 9, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Jun 9, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
freemandealer
commented
Jun 17, 2026
MemberAuthor
run buildall |
freemandealerforce-pushed
the
pick-branch-4.0-pr-63394
branch
from
June 17, 2026 02:47
d266575 to
6889a38Comparefreemandealer
commented
Jun 17, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Jun 17, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 17, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Jun 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #63394
Picked to: branch-4.0
Pick branch: freemandealer:pick-branch-4.0-pr-63394
Validation:
Notes:
Resolved cached_remote_file_reader.cpp and block_file_cache_test.cpp conflicts against branch-4.0 file layout. Fixed block_file_cache_test.cpp to use branch-4.0 olap_define.h include path and FileReader interface.