Skip to content

branch-4.0: [fix](s3) Avoid retrying object storage SlowDown errors #63776 - #64326

Merged
morningman merged 1 commit into
branch-4.0from
auto-pick-63776-branch-4.0
Jun 24, 2026
Merged

branch-4.0: [fix](s3) Avoid retrying object storage SlowDown errors #63776#64326
morningman merged 1 commit into
branch-4.0from
auto-pick-63776-branch-4.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #63776

@wyxxxcatYour Name
[fix](s3) Avoid retrying object storage SlowDown errors (#63776)
280025f
### What problem does this PR solve?
Object storage throttling errors can be retried by the SDK retry policy.
When requests are already rate limited, these retries add **extra sleep
time** and delay the caller from entering the next processing flow.
This change disables retry for throttling responses in object storage
clients:
- S3 `SlowDown` errors are not retried.
- Azure 429 `TooManyRequests` is not added to retryable status codes.
Other retryable errors keep the existing retry behavior.
@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.48% (1845/2351)
Line Coverage65.24% (33125/50776)
Region Coverage65.61% (16320/24875)
Branch Coverage56.21% (8694/15466)

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.49% (25526/35704)
Line Coverage54.34% (270458/497742)
Region Coverage51.97% (224340/431646)
Branch Coverage53.34% (96435/180804)

@morningmanmorningman reopened this Jun 10, 2026
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 10, 2026
@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 5dc358a into branch-4.0Jun 24, 2026
29 of 32 checks passed
@github-actions
github-actionsBot deleted the auto-pick-63776-branch-4.0 branch June 24, 2026 12:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@morningman@wyxxxcat