Skip to content

branch-4.1: [fix](s3) Avoid retrying object storage SlowDown errors #63776 - #64327

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-63776-branch-4.1
Jun 10, 2026
Merged

branch-4.1: [fix](s3) Avoid retrying object storage SlowDown errors #63776#64327
yiguolei merged 1 commit into
branch-4.1from
auto-pick-63776-branch-4.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #63776

@wyxxxcatYour Name
[fix](s3) Avoid retrying object storage SlowDown errors (#63776)
72db490
### What problem does this PR solve?
Object storage throttling errors can be retried by the SDK retry policy.
When requests are already rate limited, these retries add **extra sleep
time** and delay the caller from entering the next processing flow.
This change disables retry for throttling responses in object storage
clients:
- S3 `SlowDown` errors are not retried.
- Azure 429 `TooManyRequests` is not added to retryable status codes.
Other retryable errors keep the existing retry behavior.
@github-actions
github-actionsBot requested a review from yiguolei as a code ownerJune 9, 2026 13:55
@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.38% (1903/2428)
Line Coverage64.81% (33931/52353)
Region Coverage65.29% (17485/26781)
Branch Coverage53.96% (9277/17192)

@hello-stephen

hello-stephen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.75% (26567/37027)
Line Coverage54.85% (282283/514621)
Region Coverage52.25% (234955/449644)
Branch Coverage53.55% (101767/190037)

@yiguoleiyiguolei reopened this Jun 10, 2026
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 10, 2026
@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 9eac4a5 into branch-4.1Jun 10, 2026
29 of 32 checks passed
@morningman
morningman deleted the auto-pick-63776-branch-4.1 branch July 8, 2026 14:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@yiguolei@wyxxxcat