Uh oh!
There was an error while loading. Please reload this page.
branch-4.1:[fix](maxcompute)Fix MaxCompute IN predicate pushdown polarity (#65083) - #64358
Conversation
hello-stephen
commented
Jun 10, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
6792355 to
c85a5f9Comparehubgeter
commented
Jun 25, 2026
run buildall |
hubgeter
commented
Jun 25, 2026
/review |
There was a problem hiding this comment.
Automated review found one required cleanup.
Critical checkpoints:
- MaxCompute IN/NOT IN polarity: the production mapping now matches Doris
InPredicate.isNotIn(), and I did not find a semantic regression in the MaxCompute scan/filter path. - Regression coverage and session/config: the added remote MaxCompute cases exercise single and multi
IN/NOT INplus non-pushdown comparisons; no separate session/config propagation issue was found. - CI/style:
git diff --check f5561492338cc1d27eedb6ac4e0e75593befc218 c85a5f903fb9a8c448b8120567146f6ce770089bfails because the new expected-output file has a blank line at EOF; see the inline comment. - User focus: no additional user-provided review focus was present.
Subagent conclusions:
- optimizer-rewrite: no candidates became inline comments; convergence round CR-1 returned
NO_NEW_VALUABLE_FINDINGS. - tests-session-config:
TSC-001was accepted asM-001and submitted as the inline comment; convergence round CR-1 returnedNO_NEW_VALUABLE_FINDINGS.
| -- !not_in_non_pushdown -- | ||
| 2 string_value | ||
| 4 string_value | ||
There was a problem hiding this comment.
This new expected-output file leaves an extra blank line after the final row, and the patch currently fails git diff --check with new blank line at EOF on this file. Please remove the trailing blank line so the PR passes the repository's whitespace check.
hello-stephen
commented
Jun 25, 2026
FE UT Coverage ReportIncrement line coverage |
hubgeter
commented
Jun 25, 2026
run buildall |
hello-stephen
commented
Jun 25, 2026
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Jun 25, 2026
FE Regression Coverage ReportIncrement line coverage |
9e64059 to
1b6d475Comparehubgeter
commented
Jul 1, 2026
run buildall |
hello-stephen
commented
Jul 1, 2026
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Jul 1, 2026
FE Regression Coverage ReportIncrement line coverage |
Uh oh!
There was an error while loading. Please reload this page.
What problem does this PR solve?
bp #65083
Problem Summary:
fix maxcompute error in predicate pushdown.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)