Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Escape JSONB path member control characters #63517 - #64364
Merged
Conversation
### What problem does this PR solve? Issue Number: None Problem Summary: JSONB path serialization emitted raw control characters in member names. This could make paths returned by JSON functions or shown in diagnostics contain raw newlines/tabs and fail path round-trip parsing. Escape JSONB path member names with JSON-compatible sequences, decode those sequences while parsing path members, and reset per-leg escape parser state so escaped nested members followed by additional legs round-trip correctly. ### Release note None ### Check List (For Author) - Test: - Unit Test: `./run-be-ut.sh --run --filter=JsonbDocumentTest.jsonb_path_member_to_string_escapes_control_characters -j 16` - Unit Test: standalone JsonbPath nested escaped-member repro compiled and ran successfully - Build check: `DORIS_HOME=$PWD ninja -C be/ut_build_ASAN test/CMakeFiles/doris_be_test.dir/core/jsonb/jsonb_document_test.cpp.o` - Format check: `build-support/clang-format.sh`; `build-support/check-format.sh`; `git diff --check` - Static Analysis: attempted `build-support/run-clang-tidy.sh --base d7d516f --build-dir be/ut_build_ASAN`, blocked by existing clang-tidy/toolchain diagnostics outside the change - Full `doris_be_test` link: attempted locally, but stopped because this worktree triggered a large 1955-target rebuild - Behavior changed: Yes. JSONB path member serialization now escapes control characters instead of emitting raw control bytes, and escaped nested path members followed by additional legs now parse and round-trip correctly. - Does this need documentation: No
hello-stephen
commented
Jun 10, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Jun 10, 2026
Contributor
run buildall |
hello-stephen
commented
Jun 10, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
commented
Jun 11, 2026
Contributor
skip buildall |
yiguolei
approved these changes
Jun 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63517